Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the MCE CPAN distribution.

Report information
The Basics
Id: 102040
Status: resolved
Priority: 0/
Queue: MCE
People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.600
Fixed in: 1.601
Attachments
MCE-1.600-Install-mce_grep.patch

History Show all quoted text
  Tue Feb 10 05:45:43 2015 ppisar [...] redhat.com - Ticket created
Subject: bin/mce_grep is not installed
Is there a reason why bin/mce_grep is not installed? I can see the EXE_FILES are explicitly empty in the Makefile.PL.
  Tue Feb 10 06:40:13 2015 ppisar [...] redhat.com - Correspondence added
From: ppisar [...] redhat.com
Dne Út 10.úno.2015 05:45:43, ppisar napsal(a): Show quoted text
> Is there a reason why bin/mce_grep is not installed? I can see the > EXE_FILES are explicitly empty in the Makefile.PL.
Attached patch fixes it. -- Petr
Subject: MCE-1.600-Install-mce_grep.patch
From 9d9cce744e8cb9c6573578beb18cb25089cd6b86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 10 Feb 2015 11:44:18 +0100 Subject: [PATCH] Install mce_grep MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CPAN RT#102040 Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index 9508423..6fdf236 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -33,7 +33,9 @@ WriteMakefile( VERSION => '1.600', - EXE_FILES => [], + EXE_FILES => [ + 'bin/mce_grep' + ], (($ExtUtils::MakeMaker::VERSION lt '6.25') ? (PL_FILES => { }) : ()), -- 1.9.3
  Tue Feb 10 12:37:27 2015 marioeroy [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #102040] bin/mce_grep is not installed
Date: Tue, 10 Feb 2015 12:37:14 -0500
To: bug-MCE [...] rt.cpan.org
From: Mario Roy <marioeroy [...] gmail.com>
Hi Petr, No reason really. This is fixed in trunk for the upcoming MCE 1.601 release. https://code.google.com/p/many-core-engine-perl/source/detail?r=788 Thanks, Mario
  Tue Feb 10 12:37:28 2015 The RT System itself - Status changed from 'new' to 'open'
  Tue Feb 10 13:31:50 2015 marioeroy [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #102040] bin/mce_grep is not installed
Date: Tue, 10 Feb 2015 13:31:42 -0500
To: bug-MCE [...] rt.cpan.org
From: Mario Roy <marioeroy [...] gmail.com>
It is likely for grep.exe to be missing on Windows. Therefore, Makefile.PL does not install bin/mce_grep if the grep binary itself is not found in the PATH.
  Wed Feb 11 04:09:23 2015 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #102040] bin/mce_grep is not installed
Date: Wed, 11 Feb 2015 10:09:10 +0100
To: Mario Roy via RT <bug-MCE [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Tue, Feb 10, 2015 at 01:31:50PM -0500, Mario Roy via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=102040 > > > It is likely for grep.exe to be missing on Windows. Therefore, Makefile.PL > does not install bin/mce_grep if the grep binary itself is not found in the > PATH. >
The build-time check undermines crossbuilding when the software is built on different host than it is run later. E.g. any Linux distribution packaging this CPAN distribution into its native packaging format will be affected. One will have to build-require grep even if it's not necessary (the mce_grep is not run during the tests), or hack the Makefile.PL. If you still think the build-time heuristics is good and necessary, could you add a knob overriding the check (e.g. "if ($ENV{MCE_INSTALL_TOOLS} {}")? -- Petr
Download (untitled)
application/pgp-signature 213b

Message body not shown because it is not plain text.

  Wed Feb 11 10:37:51 2015 marioeroy [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #102040] bin/mce_grep is not installed
Date: Wed, 11 Feb 2015 10:37:37 -0500
To: bug-MCE [...] rt.cpan.org
From: Mario Roy <marioeroy [...] gmail.com>
I changed the build-time heuristics to knob instead. The bin/mce_grep script already exits gracefully (e.g. building on Windows with MCE_INSTALL_TOOLS=1 and lacking grep.exe). This allows Activestate to include bin/mce_grep if desired. https://code.google.com/p/many-core-engine-perl/source/detail?r=789 Thanks.
  Sun Mar 15 22:09:57 2015 MARIOROY [...] cpan.org - Correspondence added
MCE 1.601 has been released resolving this issue. Thank you.
  Sun Mar 15 22:09:57 2015 MARIOROY [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Mar 16 10:13:42 2015 MARIOROY [...] cpan.org - Fixed in 1.601 added