Skip Menu |

This queue is for tickets about the Module-Starter-Plugin-CGIApp CPAN distribution.

Report information
The Basics
Id: 101894
Status: open
Priority: 0/
Queue: Module-Starter-Plugin-CGIApp

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.42
Fixed in: 0.43



Subject: Fails with Module-Starter-1.70 and higher
As per subject. Sample fail report: http://www.cpantesters.org/cpan/report/48377cbe-a163-11e4-854e-855b8971dd2f Downgrading to XSAWYERX/Module-Starter-1.62.tar.gz is good for a workaround as I have just verified. HTH&&Thanks, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)
From: ppisar [...] redhat.com
Dne Po 02.úno.2015 23:14:58, ANDK napsal(a): Show quoted text
> As per subject. Sample fail report: > > http://www.cpantesters.org/cpan/report/48377cbe-a163-11e4-854e- > 855b8971dd2f > > Downgrading to XSAWYERX/Module-Starter-1.62.tar.gz is good for a > workaround as I have just verified. >
This fails because Module::Starter::Plugin::CGIApp::create_t() calls private _create_t() which changed prototype in Module-Starter-1.70. It used to expect (file_name, file_content) and it used to create the file_name under t subdirectory. Now it expects (subdirectory_name, file_name, file_content). The subdirectory_name should be "t" or "xt". However, after adapting to this change, I get different failure: t/extutils-makemaker.t .. 1/3 # Failed test 'different files' # at t/common.pm line 114. # got: '1' # expected: '0' # /home/test/fedora/perl-Module-Starter-Plugin-CGIApp/Module-Starter-Plugin-CGIApp-0.42/t/Example-Dist/MANIFEST # Looks like you failed 1 test of 3. t/extutils-makemaker.t .. Dubious, test returned 1 (wstat 256, 0x100) and the same for module_build.t and module_install.t.
From: ppisar [...] redhat.com
Dne St 06.Květen.2015 10:55:59, ppisar napsal(a): Show quoted text
> However, after adapting to this change, I get different failure: > > t/extutils-makemaker.t .. 1/3 > # Failed test 'different files' > # at t/common.pm line 114. > # got: '1' > # expected: '0' > # /home/test/fedora/perl-Module-Starter-Plugin-CGIApp/Module-Starter- > Plugin-CGIApp-0.42/t/Example-Dist/MANIFEST > # Looks like you failed 1 test of 3. > t/extutils-makemaker.t .. Dubious, test returned 1 (wstat 256, 0x100) > > and the same for module_build.t and module_install.t.
The difference is newer Module-Starter creates boilerplate.t in xt instead of in t subdirectory.
From: ppisar [...] redhat.com
Dne Po 02.úno.2015 23:14:58, ANDK napsal(a): Show quoted text
> As per subject. Sample fail report: > > http://www.cpantesters.org/cpan/report/48377cbe-a163-11e4-854e- > 855b8971dd2f > > Downgrading to XSAWYERX/Module-Starter-1.62.tar.gz is good for a > workaround as I have just verified. >
This patch fixes it. Though it's not compatible with Module-Starter before 1.70. -- Petr
Subject: Module-Starter-Plugin-CGIApp-0.42-Adapt-to-Module-Starter-1.71.patch
From a1e8f3b6937be2c8c03de3dfb09ca53ca62be88a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Thu, 7 May 2015 13:37:53 +0200 Subject: [PATCH] Adapt to Module-Starter-1.71 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Module-Starter 1.70 and 1.71 changed how test files are created. This adjusts to the change. Filtering t/boilerplate.t from MANIFEST is a hack. I don't understand why it's not created into xt directory. https://bugzilla.redhat.com/show_bug.cgi?id=1189463 https://rt.cpan.org/Public/Bug/Display.html?id=101894 https://github.com/xsawyerx/module-starter/issues/47#issuecomment-73425236 Signed-off-by: Petr Písař <ppisar@redhat.com> --- lib/Module/Starter/Plugin/CGIApp.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/Module/Starter/Plugin/CGIApp.pm b/lib/Module/Starter/Plugin/CGIApp.pm index cb0f1b7..f3aa37b 100644 --- a/lib/Module/Starter/Plugin/CGIApp.pm +++ b/lib/Module/Starter/Plugin/CGIApp.pm @@ -125,7 +125,6 @@ sub create_distro { push @files, $self->create_modules( @{ $self->{modules} } ); push @files, $self->create_t( @{ $self->{modules} } ); - push @files, $self->create_xt( @{ $self->{modules} } ); push @files, $self->create_tmpl(); my %build_results = $self->create_build(); push @files, @{ $build_results{files} }; @@ -147,7 +146,7 @@ sub _create_manifest { my $file = File::Spec->catfile( $self->{basedir}, 'MANIFEST' ); open my $fh, '>', $file or croak "Can't open file $file: $OS_ERROR\n"; - foreach my $file ( sort @files ) { + foreach my $file ( grep !m{^\Qt/boilerplate.t\E$}, sort @files ) { print {$fh} "$file\n" or croak "$OS_ERROR\n"; } close $fh or croak "Can't close file $file: $OS_ERROR\n"; @@ -261,9 +260,7 @@ in the distribution. sub create_t { my ( $self, @modules ) = @_; - my %t_files = $self->t_guts(@modules); - - my @files = map { $self->_create_t( $_, $t_files{$_} ) } keys %t_files; + my @files = $self->SUPER::create_t(@modules); # This next part is for the static files dir t/www my @dirparts = ( $self->{basedir}, 't', 'www' ); -- 2.1.0
In Debian we are currently applying the following patch to Module-Starter-Plugin-CGIApp. We thought you might be interested in it too. Description: adjust to Module::Starter 1.70/1.71 * _create_t() API changed, needs t or xt as first parameter now * t/boilerplate.t gets installed now Origin: vendor Bug-Debian: https://bugs.debian.org/796535 Author: gregor herrmann <gregoa@debian.org> Last-Update: 2015-09-19 Thanks for considering, gregor herrmann, Debian Perl Group

Message body is not shown because sender requested not to inline it.