Bug #101794 for Parse-DNS-Zone: Parse::DNS::Zone requires Test::Distribution 2.0

Wed Jan 28 12:01:29 2015 Dan [...] DWright.Org - Ticket created

Subject:

Parse::DNS::Zone requires Test::Distribution 2.0

Parse::DNS::Zone has an undocumented dependency on Test::Distribution. Also, I've found that older versions of Test::Distribution will fail. I recommend adding Test::Distribution => 2.0 Inside your PREREQ block. -Dan

Wed Jan 28 13:22:29 2015 olof [...] ethup.se - Correspondence added

Subject:	Re: [rt.cpan.org #101794] Parse::DNS::Zone requires Test::Distribution 2.0
Date:	Wed, 28 Jan 2015 19:22:17 +0100
To:	"Daniel J. Wright via RT" <bug-Parse-DNS-Zone [...] rt.cpan.org>
From:	Olof Johansson <olof [...] ethup.se>

On 2015-01-28 12:01 -0500, Daniel J. Wright via RT wrote: Show quoted text

> Parse::DNS::Zone has an undocumented dependency on > Test::Distribution.

Its usage is conditional: .... eval { require Test::Distribution; }; if($@) { plan skip_all => 'Test::Distribution not installed'; .... For this reason I'm hesitant to add this as a prereq. Or do you get errors without it present? Show quoted text

> Also, I've found that older versions of Test::Distribution will fail.

In what way? Thanks, -- --------------------------------------------------------------- | Olof Johansson http://stdlib.se/ | | irc: zibri https://github.com/olof | ---------------------------------------------------------------

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Wed Jan 28 13:22:30 2015 The RT System itself - Status changed from 'new' to 'open'

Wed Jan 28 14:15:14 2015 Dan [...] DWright.Org - Correspondence added

Subject:	Re: [rt.cpan.org #101794] Parse::DNS::Zone requires Test::Distribution 2.0
Date:	Wed, 28 Jan 2015 14:15:00 -0500
To:	bug-Parse-DNS-Zone [...] rt.cpan.org
From:	Daniel Wright <dan [...] dwright.org>

Show quoted text

> On Jan 28, 2015, at 1:22 PM, Olof Johansson via RT <bug-Parse-DNS-Zone@rt.cpan.org> wrote: > > Its usage is conditional: > > .... > eval { > require Test::Distribution; > };

The problem is that this approach only answers “Is Test::Distribution” installed. It does not answer “what version is installed?” So, if a server has an older Test::Distribution installed, it will still try to apply the tests. But in the end, they will fail. Show quoted text

>> Also, I've found that older versions of Test::Distribution will fail.

> > In what way?

If you attempt to run regression tests on Parse::DNS::Zone using an older version of Test::Distribution, the tests will fail with the following output: ==> MISMATCHED content between MANIFEST and distribution files! <== # Failed test 'Valid signature' # at /usr/local/lib/perl5/site_perl/5.8.8/Test/Distribution.pm line 356. # got: -5 # expected: 0 # Looks like you failed 1 test of 11.

Sun Feb 01 11:37:23 2015 olof [...] ethup.se - Correspondence added

Subject:	Re: [rt.cpan.org #101794] Parse::DNS::Zone requires Test::Distribution 2.0
Date:	Sun, 1 Feb 2015 17:37:12 +0100
To:	"Daniel J. Wright via RT" <bug-Parse-DNS-Zone [...] rt.cpan.org>
From:	Olof Johansson <olof [...] ethup.se>

On 2015-01-28 14:15 -0500, Daniel J. Wright via RT wrote: Show quoted text

> If you attempt to run regression tests on Parse::DNS::Zone using an > older version of Test::Distribution, the tests will fail with the > following output: > > ==> MISMATCHED content between MANIFEST and distribution files! <==

This is a real bug (although not one you should have to care about). I've decided to make the Test::Distribution suite conditional on the environment variable RELEASE_TESTING being set. I've also regenerated the MANIFEST file and tweaked the MANIFEST.SKIP. This will be part of a 0.5 release, which should happen shortly. Just wanted to give you the opportunity to comment on my patch for #101719 first. Thanks for the report, -- --------------------------------------------------------------- | Olof Johansson http://stdlib.se/ | | irc: zibri https://github.com/olof | ---------------------------------------------------------------

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Mon Feb 16 06:12:32 2015 olof [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Feb 16 06:12:34 2015 olof [...] cpan.org - Fixed in 0.5 added

Mon Feb 16 06:12:57 2015 olof [...] cpan.org - Status changed from 'resolved' to 'open'

Mon Feb 16 06:12:57 2015 olof [...] cpan.org - Fixed in 0.5 deleted

Mon Feb 16 06:13:33 2015 olof [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Feb 16 06:13:33 2015 olof [...] cpan.org - Taken

Mon Feb 16 06:13:35 2015 olof [...] cpan.org - Fixed in 0.5 added

Bug #101794 for Parse-DNS-Zone: Parse::DNS::Zone requires Test::Distribution 2.0

Preferred bug tracker