Bug #101654 for Font-FreeType: Missing -L and nonportable -I

Wed Jan 21 03:56:27 2015 dmacks [...] netspace.org - Ticket created

Subject:	Missing -L and nonportable -I
Date:	Wed, 21 Jan 2015 03:56:15 -0500
To:	bug-Font-FreeType [...] rt.cpan.org
From:	"Daniel Macks" <dmacks [...] netspace.org>

I have several different freetype libraries installed, one supplied by vendor, one by a third-party package, etc. None of the headers are in a default search location, so I need to patch the hardcoded -I in Makefile.PL to select the one I want. And I also need to insert a hardcoded -L to find the library that goes with it (rather than the one in the compiler's default search path), both for the Devel::CheckLib::check_lib_or_exit() and the actual WriteMakefile(). That's a lot of hacking and non-portable hardcoding. Bug #50287 only scratches the surface (the /opt path is just one possible place that Mac users might have freetype depending on their x11 version). Freetype already publishes, via a freetype-config script and a freetype2.pc pkg-config file, the full and consistent set of flags to use (which may also entail other -I and -L/-l for freetype's own dependencies). A portable solution for determining the self-consistent paths and platform-specific flags is therefore just to ask freetype. The only setting one would have to do is (using standard shell env-vars) make sure the right -config or .pc is being used. dan -- Daniel Macks dmacks@netspace.org

Wed Jan 21 14:38:38 2015 DMOL [...] cpan.org - Correspondence added

Thanks for the bugreport. Patches are welcome :) , although I'm not fond direct invocation of pkg_config. (It should be correctly handled situation where pkg_config isn't present, it is planned to be buildable on Windows, etc.). You may try to use ExtUtils::PkgConfig.

Wed Jan 21 14:38:38 2015 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 22 22:26:19 2015 zaki.mughal [...] gmail.com - Correspondence added

CC:	;
Subject:	Re: [rt.cpan.org #101654] Missing -L and nonportable -I
Date:	Thu, 22 Jan 2015 21:25:27 -0600
To:	"dmacks [...] netspace.org via RT" <bug-Font-FreeType [...] rt.cpan.org>
From:	Zakariyya Mughal <zaki.mughal [...] gmail.com>

On 2015-01-21 at 03:56:27 -0500, dmacks@netspace.org via RT wrote: Show quoted text

> Wed Jan 21 03:56:27 2015: Request 101654 was acted upon. > Transaction: Ticket created by dmacks@netspace.org > Queue: Font-FreeType > Subject: Missing -L and nonportable -I > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dmacks@netspace.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101654 > > > > Freetype already publishes, via a freetype-config script and a freetype2.pc pkg-config file, the full and consistent set of flags to use (which may also entail other -I and -L/-l for freetype's own dependencies). A portable solution for determining the self-consistent paths and platform-specific flags is therefore just to ask freetype. The only setting one would have to do is (using standard shell env-vars) make sure the right -config or .pc is being used. >

OK, what do you all think of this as a first go at the problem? <https://github.com/zmughal/p5-Font-FreeType/pull/16> Cheers, - Zaki Mughal Show quoted text

> dan > > -- > Daniel Macks > dmacks@netspace.org > >

Sat Jul 04 13:46:22 2015 zaki.mughal [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #101654] Missing -L and nonportable -I
Date:	Sat, 4 Jul 2015 12:46:09 -0500
To:	Zakariyya Mughal via RT <bug-Font-FreeType [...] rt.cpan.org>
From:	Zakariyya Mughal <zaki.mughal [...] gmail.com>

On 2015-01-22 at 22:26:20 -0500, Zakariyya Mughal via RT wrote: Show quoted text

> Queue: Font-FreeType > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101654 > > > On 2015-01-21 at 03:56:27 -0500, dmacks@netspace.org via RT wrote:

> > Wed Jan 21 03:56:27 2015: Request 101654 was acted upon. > > Transaction: Ticket created by dmacks@netspace.org > > Queue: Font-FreeType > > Subject: Missing -L and nonportable -I > > Broken in: (no value) > > Severity: (no value) > > Owner: Nobody > > Requestors: dmacks@netspace.org > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101654 > > > > > > > Freetype already publishes, via a freetype-config script and a freetype2.pc pkg-config file, the full and consistent set of flags to use (which may also entail other -I and -L/-l for freetype's own dependencies). A portable solution for determining the self-consistent paths and platform-specific flags is therefore just to ask freetype. The only setting one would have to do is (using standard shell env-vars) make sure the right -config or .pc is being used. > >

> > OK, what do you all think of this as a first go at the problem? > > <https://github.com/zmughal/p5-Font-FreeType/pull/16>

The above changes have been merged for months and CPAN testers seems happy, so I'm going to close this. Cheers, - Zaki Show quoted text

> > Cheers, > - Zaki Mughal >

> > dan > > > > -- > > Daniel Macks > > dmacks@netspace.org > > > >

>

Sat Jul 04 13:47:00 2015 zmughal [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Jul 04 13:47:00 2015 zmughal [...] cpan.org - Taken

Sat Jul 04 13:47:01 2015 zmughal [...] cpan.org - Fixed in 0.05 added

Sat Jul 04 15:33:11 2015 dmacks [...] netspace.org - Correspondence added

Subject:	Re: [rt.cpan.org #101654] Missing -L and nonportable -I
Date:	Sat, 04 Jul 2015 15:32:55 -0400
To:	bug-Font-FreeType [...] rt.cpan.org
From:	"Daniel Macks" <dmacks [...] netspace.org>

0.05 looks fine for me. Thanks! dan