Skip Menu |

This queue is for tickets about the version CPAN distribution.

Report information
The Basics
Id: 101647
Status: resolved
Priority: 0/
Queue: version
People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jan 20 23:05:08 2015 dagolden [...] cpan.org - Ticket created
Subject: unused qv variable in Perl_vnormal
Looking at the diff to 0.9909, the qv variable gets set but appears unused. @@ -890,6 +914,7 @@ Perl_vnormal(pTHX_ SV *vs) { I32 i, len, digit; bool alpha = FALSE; + bool qv = FALSE; SV *sv; AV *av; @@ -902,6 +927,9 @@ Perl_vnormal(pTHX_ SV *vs) if ( hv_exists(MUTABLE_HV(vs), "alpha", 5 ) ) alpha = TRUE; + if ( hv_exists(MUTABLE_HV(vs), "qv", 2) ) + qv = TRUE; + av = MUTABLE_AV(SvRV(*hv_fetchs(MUTABLE_HV(vs), "version", FALSE))); len = av_len(av); @@ -1082,3 +1110,5 @@ Perl_vcmp(pTHX_ SV *lhv, SV *rhv) } return retval; }
  Fri Jan 01 08:42:51 2016 jpeacock [...] cpan.org - Correspondence added
On Tue Jan 20 23:05:08 2015, DAGOLDEN wrote: Show quoted text
> Looking at the diff to 0.9909, the qv variable gets set but appears unused.
Resolved in 0.9913
  Fri Jan 01 08:42:51 2016 The RT System itself - Status changed from 'new' to 'open'
  Fri Jan 01 08:42:59 2016 jpeacock [...] cpan.org - Status changed from 'open' to 'resolved'