Bug #101487 for ExtUtils-Constant: [PATCH] reduce compiler warnings and stderr noise

Mon Dec 13 18:18:49 2010 zefram [...] fysh.org - Ticket #63888: Ticket created

Subject:	uninit warning
Date:	Mon, 13 Dec 2010 23:18:38 +0000
To:	bug-ExtUtils-Constant [...] rt.cpan.org
From:	Zefram <zefram [...] fysh.org>

This warning comes up in the core test suite if I've forced -Wall on: cpan/ExtUtils-Constant/t/Constant..............................ExtTest.c: In function 'XS_ExtTest_constant': ExtTest.xs:209: warning: 'iv' may be used uninitialized in this function ExtTest.xs:209: note: 'iv' was declared here ok -zefram

Thu Jan 01 11:18:35 2015 jkeenan [...] cpan.org - Ticket #63888: Correspondence added

On Mon Dec 13 18:18:49 2010, zefram@fysh.org wrote: Show quoted text

> This warning comes up in the core test suite if I've forced -Wall on: > > cpan/ExtUtils- > Constant/t/Constant..............................ExtTest.c: In > function 'XS_ExtTest_constant': > ExtTest.xs:209: warning: 'iv' may be used uninitialized in this > function > ExtTest.xs:209: note: 'iv' was declared here > ok > > -zefram

Attached is recent output from running t/Constant.t in the Perl 5 core test suite. Configuration: sh ./Configure -des -Dusedevel commit 6ed80d55657304061a4d51a3aa68a5ec84f59881 (Nov 21 2014: tag v5.21.6) Also: This distribution is maintained outside of the Perl 5 repository. If its repository were on, say, github.com, I could submit patches or pull requests for some of the other bugs in this queue. Thank you very much. Jim Keenan

Subject:

ExtUtils_Constant_t_Constant_t_warnings.txt

Message body is not shown because it is too large.

Subject:

perl_V.txt

Summary of my perl5 (revision 5 version 21 subversion 6) configuration: Commit id: 6ed80d55657304061a4d51a3aa68a5ec84f59881 Platform: osname=linux, osvers=3.13.0-43-generic, archname=x86_64-linux uname='linux zareason 3.13.0-43-generic #72-ubuntu smp mon dec 8 19:35:06 utc 2014 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel' hint=recommended, useposix=true, d_sigaction=define useithreads=undef, usemultiplicity=undef use64bitint=define, use64bitall=define, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2', cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include' ccversion='', gccversion='4.8.2', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='cc', ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib libs=-lnsl -ldl -lm -lcrypt -lutil -lc perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a gnulibc_version='2.19' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector' Characteristics of this binary (from libperl): Compile-time options: HAS_TIMES PERLIO_LAYERS PERL_DONT_CREATE_GVSV PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO USE_PERL_ATOF Built under linux Compiled at Jan 1 2015 10:51:35 %ENV: PERL5LIB="/home/jkeenan/perl5/lib/perl5" PERLBREW_BASHRC_VERSION="0.67" PERLBREW_HOME="/home/jkeenan/.perlbrew" PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.20.1/man" PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin:/home/jkeenan/perl5/perlbrew/perls/perl-5.20.1/bin" PERLBREW_PERL="perl-5.20.1" PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew" PERLBREW_VERSION="0.67" PERL_LOCAL_LIB_ROOT="/home/jkeenan/perl5" PERL_MB_OPT="--install_base "/home/jkeenan/perl5"" PERL_MM_OPT="INSTALL_BASE=/home/jkeenan/perl5" PERL_WORKDIR="gitwork/perl" @INC: lib /home/jkeenan/perl5/lib/perl5/x86_64-linux /home/jkeenan/perl5/lib/perl5 /usr/local/lib/perl5/site_perl/5.21.6/x86_64-linux /usr/local/lib/perl5/site_perl/5.21.6 /usr/local/lib/perl5/5.21.6/x86_64-linux /usr/local/lib/perl5/5.21.6

Thu Jan 01 11:18:35 2015 The RT System itself - Ticket #63888: Status changed from 'new' to 'open'

Mon Jan 12 09:53:19 2015 davem [...] iabyn.com - Ticket created

Subject:	[PATCH] reduce compiler warnings and stderr noise
Date:	Mon, 12 Jan 2015 14:53:08 +0000
To:	bug-ExtUtils-Constant [...] rt.cpan.org
From:	Dave Mitchell <davem [...] iabyn.com>

Dear maintainer of a dual-lived CPAN distribution: I'm currently attempting to get bleadperl to be warnings-clean; i.e. where (./Configure && make) 2>errs leaves no lines in 'errs'. Recently bleadperl made the -W options passed to the C compiler more fascist, and in addition we're trying to get blead to compile and run cleanly under clang's -fsanitize=undefined option. Due to that and other reasons, bleadperl's build is currently very noisy. Attached (hopefully) to this ticket is one or more patches that reduce the noise of your distribution when built as part of bleadperl. It would be great if they could make it into a new release of your distribution in time for incorporation into perl-5.22.0. Our timetable is: 2015-01-20 5.21.8 Contentious changes freeze 2015-02-20 5.21.9 User-visible changes freeze 2015-03-20 5.21.10 Full code freeze 2015-05-20 5.22.0 Stable release! so for example if a new release of your distribution included contentious features, then it would need to be merged into blead *prior* to the 20th of Jan. Thanks, Dave M. -- A power surge on the Bridge is rapidly and correctly diagnosed as a faulty capacitor by the highly-trained and competent engineering staff. -- Things That Never Happen in "Star Trek" #9

Message body is not shown because sender requested not to inline it.

Sun Mar 08 09:12:02 2015 jkeenan [...] cpan.org - Correspondence added

On Mon Jan 12 09:53:19 2015, davem@iabyn.com wrote: Show quoted text

> Dear maintainer of a dual-lived CPAN distribution: I'm currently attempting > to get bleadperl to be warnings-clean; i.e. where > (./Configure && make) 2>errs > leaves no lines in 'errs'. Recently bleadperl made the -W options passed > to the C compiler more fascist, and in addition we're trying to get blead > to compile and run cleanly under clang's -fsanitize=undefined option. Due > to that and other reasons, bleadperl's build is currently very noisy. > > Attached (hopefully) to this ticket is one or more patches that reduce the > noise of your distribution when built as part of bleadperl. > > It would be great if they could make it into a new release of your > distribution in time for incorporation into perl-5.22.0. Our > timetable is: > > 2015-01-20 5.21.8 Contentious changes freeze > 2015-02-20 5.21.9 User-visible changes freeze > 2015-03-20 5.21.10 Full code freeze > 2015-05-20 5.22.0 Stable release! >

ExtUtils::Constant maintainers: I, too, would like to see these warnings silenced. They are currently the only C-level warnings being displayed during a run of 'make test' on blead. If you do not have time to do this, please consider giving comaint privileges to someone competent to maintain the code. Thank you very much. Jim Keenan

Sun Mar 08 09:12:02 2015 The RT System itself - Status changed from 'new' to 'open'

Mon May 11 14:13:40 2015 ether [...] cpan.org - Cc ETHER added

Sun Aug 30 08:56:43 2015 RURBAN [...] cpan.org - Ticket #63888: Correspondence added

On Mon Dec 13 18:18:49 2010, zefram@fysh.org wrote: Show quoted text

> This warning comes up in the core test suite if I've forced -Wall on: > > cpan/ExtUtils- > Constant/t/Constant..............................ExtTest.c: In > function 'XS_ExtTest_constant': > ExtTest.xs:209: warning: 'iv' may be used uninitialized in this > function > ExtTest.xs:209: note: 'iv' was declared here > ok

The compiler warning is ok, but can be ignored, as the uninitialized variables are not used. The iv missing case always returns PERL_constant_NOTFOUND which is immediately handled after. We could add a dummy assignment with DEBUGGING. type = constant(aTHX_ s, len, &iv); /* Return 1 or 2 items. First is error message, or undef if no error. Second, if present, is found value */ switch (type) { case PERL_constant_NOTFOUND: sv = sv_2mortal(newSVpvf("%s is not a valid ExtTest macro", s)); PUSHs(sv); break; ... -- Reini Urban

Sat Jun 24 15:54:15 2017 nwc10+please+use+perlbug+for+perl+queries [...] colon.colondot.net - Correspondence added

On Mon Jan 12 09:53:19 2015, davem@iabyn.com wrote: Show quoted text

> Attached (hopefully) to this ticket is one or more patches that reduce the > noise of your distribution when built as part of bleadperl.

Now applied and uploaded to CPAN as part of the dev release 0.23_50. Sorry for the delay, and that it missed your proposed schedule. Nicholas Clark

Sat Jun 24 15:59:28 2017 nwc10+please+use+perlbug+for+perl+queries [...] colon.colondot.net - Ticket #63888: Merged into ticket #101487

Sat Jun 24 15:59:28 2017 nwc10+please+use+perlbug+for+perl+queries [...] colon.colondot.net - Merged into ticket #101487

Sat Jun 24 16:01:08 2017 nwc10+please+use+perlbug+for+perl+queries [...] colon.colondot.net - Status changed from 'open' to 'patched'