Bug #101457 for IO-Async: Use accept4 instead of accept by default where available?

Sun Jan 11 09:55:23 2015 TEAM [...] cpan.org - Ticket created

Subject:

Use accept4 instead of accept by default where available?

Since everything in IO::Async should probably be O_NONBLOCK by default, and sane close-on-exec handling is at least a nice-to-have, any chance of (IO::Async::OS::linux?) using accept4() instead of accept()? http://linux.die.net/man/2/accept4 Might be something that has to be plumbed in at IO::Socket::IP or lower levels, alternatively there's a couple of implementations of accept4() floating around on CPAN if this would be better as a "use it if we have it" feature. (obviously needs SOCK_NONBLOCK | SOCK_CLOEXEC flags to make any difference) cheers, Tom

Sun Jan 11 09:57:32 2015 TEAM [...] cpan.org - Correspondence added

I'd argue that accept4() should be the syscall that perldoc -f accept uses if available, but getting that past p5p might take longer than the CPAN route! On Sun Jan 11 14:55:23 2015, TEAM wrote: Show quoted text

> > Since everything in IO::Async should probably be O_NONBLOCK by > default, and sane close-on-exec handling is at least a nice-to-have, > any chance of (IO::Async::OS::linux?) using accept4() instead of > accept()? > > http://linux.die.net/man/2/accept4 > > Might be something that has to be plumbed in at IO::Socket::IP or > lower levels, alternatively there's a couple of implementations of > accept4() floating around on CPAN if this would be better as a "use it > if we have it" feature. > > (obviously needs SOCK_NONBLOCK | SOCK_CLOEXEC flags to make any > difference) > > cheers, > > Tom

Sun Jan 11 11:34:54 2015 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Getting accept4() into Socket.xs is going to be vastly easier than getting a new core function to wrap it ;) (IMHO longterm a lot of the socket-calling core ops may want to become XS functions in Socket /anyway/, but that's an argument for another day). -- Paul Evans

Sun Jan 11 11:34:54 2015 The RT System itself - Status changed from 'new' to 'open'