Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 101454
Status: rejected
Priority: 0/
Queue: Pod-Simple
People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sun Jan 11 09:16:17 2015 jkeenan [...] cpan.org - Ticket created
Subject: Files listed in MANIFEST not found in distribution
Today I updated my local git for Pod-Simple from github. I am at commit bb23b85400868c1da9b938748edac3eb7f4f1f64. I wanted to test the correction provided for https://rt.cpan.org/Ticket/Display.html?id=91851. In particular, I wanted to see how Pod-Simple's HEAD would fare if pulled into the Perl 5 core distribution. So I had occasion to compare sorted versions of the 'cpan/Pod-Simple' tree in the core with the MANIFEST of HEAD. ##### $ diff -w pod-simple-tree-in-core.txt pod-simple-own-manifest.txt 0a1 Show quoted text
> ChangeLog
12a14 Show quoted text
> lib/Pod/Simple/Pod.pm
30a33,36 Show quoted text
> Makefile.PL > MANIFEST.SKIP > MANIFEST This list of files > README
62a69,72 Show quoted text
> t/corpus/enc_char_directive.txt > t/corpus/enc_char_directive.xml > t/corpus/enc_char_wrong_directive.txt > t/corpus/enc_char_wrong_directive.xml
158a169,170 Show quoted text
> t/simple01.t > t/simple_corpus.t
##### When I called 'perl Makefile.PL' on HEAD, I got this output: ##### [pod-simple] 118 $ perl Makefile.PL Checking if your kit is complete... Warning: the following files are missing in your kit: lib/Pod/Simple/Pod.pm t/simple01.t t/simple_corpus.t Please inform the author. Generating a Unix-style Makefile Writing Makefile for Pod::Simple Writing MYMETA.yml and MYMETA.json ##### So there are 3 non-existent files in the Pod-Simple distribution residing on github. The fact that MANIFEST and MANIFEST.SKIP are found in .gitignore may have prevented this oversight from being detected. Thank you very much. Jim Keenan
  Sun Jan 11 09:23:29 2015 jkeenan [...] cpan.org - Correspondence added
On Sun Jan 11 09:16:17 2015, JKEENAN wrote: [snip] Show quoted text
> > So there are 3 non-existent files in the Pod-Simple distribution > residing on github. The fact that MANIFEST and MANIFEST.SKIP are > found in .gitignore may have prevented this oversight from being > detected. >
Correction: MANIFEST.SKIP is not in .gitignore. I recommend removing MANIFEST from .gitignore.
  Sun Jan 11 09:27:55 2015 jkeenan [...] cpan.org - Correspondence added
On Sun Jan 11 09:23:29 2015, JKEENAN wrote: Show quoted text
> On Sun Jan 11 09:16:17 2015, JKEENAN wrote: > [snip] >
> > > > So there are 3 non-existent files in the Pod-Simple distribution > > residing on github. The fact that MANIFEST and MANIFEST.SKIP are > > found in .gitignore may have prevented this oversight from being > > detected. > >
> > Correction: MANIFEST.SKIP is not in .gitignore. I recommend removing > MANIFEST from .gitignore.
Further diagnosis. I think what happened was: 1. I already had a git clone of Pod-Simple on disk. The three non-existent files were probably in that repo's MANIFEST. 2. I fetched and rebase from github. 3. Because MANIFEST was in .gitignore, the MANIFEST was not updated. 'perl Makefile.PL' was working from an outdated MANIFEST. So I think the solution is still to remove MANIFEST from .gitignore so as to prevent this problem going forward.
  Sun Jan 11 09:31:19 2015 jkeenan [...] cpan.org - Correspondence added
On Sun Jan 11 09:27:55 2015, JKEENAN wrote: Show quoted text
> > So I think the solution is still to remove MANIFEST from .gitignore so > as to prevent this problem going forward.
Patch attached. Thank you very much. Jim Keenan
Subject: 101454-0001-Remove-MANIFEST-from-.gitignore.patch
From 21ee4988036a0f71da237e780e20d3bec44ce532 Mon Sep 17 00:00:00 2001 From: James E Keenan <jkeenan@cpan.org> Date: Sun, 11 Jan 2015 09:28:22 -0500 Subject: [PATCH] Remove MANIFEST from .gitignore. --- .gitignore | 3 +- MANIFEST | 202 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 203 insertions(+), 2 deletions(-) create mode 100644 MANIFEST diff --git a/.gitignore b/.gitignore index 9f2c986..7b661d9 100644 --- a/.gitignore +++ b/.gitignore @@ -1,8 +1,7 @@ _build blib Pod-Simple-* -MANIFEST -MANIFEST.bak +*.bak *META.* Build Makefile diff --git a/MANIFEST b/MANIFEST new file mode 100644 index 0000000..6fa09ae --- /dev/null +++ b/MANIFEST @@ -0,0 +1,202 @@ +ChangeLog +lib/Pod/Simple.pm +lib/Pod/Simple.pod +lib/Pod/Simple/BlackBox.pm +lib/Pod/Simple/Checker.pm +lib/Pod/Simple/Debug.pm +lib/Pod/Simple/DumpAsText.pm +lib/Pod/Simple/DumpAsXML.pm +lib/Pod/Simple/HTML.pm +lib/Pod/Simple/HTMLBatch.pm +lib/Pod/Simple/HTMLLegacy.pm +lib/Pod/Simple/LinkSection.pm +lib/Pod/Simple/Methody.pm +lib/Pod/Simple/Progress.pm +lib/Pod/Simple/PullParser.pm +lib/Pod/Simple/PullParserEndToken.pm +lib/Pod/Simple/PullParserStartToken.pm +lib/Pod/Simple/PullParserTextToken.pm +lib/Pod/Simple/PullParserToken.pm +lib/Pod/Simple/RTF.pm +lib/Pod/Simple/Search.pm +lib/Pod/Simple/SimpleTree.pm +lib/Pod/Simple/Subclassing.pod +lib/Pod/Simple/Text.pm +lib/Pod/Simple/TextContent.pm +lib/Pod/Simple/TiedOutFH.pm +lib/Pod/Simple/Transcode.pm +lib/Pod/Simple/TranscodeDumb.pm +lib/Pod/Simple/TranscodeSmart.pm +lib/Pod/Simple/XHTML.pm +lib/Pod/Simple/XMLOutStream.pm +Makefile.PL +MANIFEST This list of files +MANIFEST.SKIP +README +t/00about.t +t/20_skip.t +t/ac_d.t +t/accept01.t +t/accept05.t +t/basic.t +t/begin.t +t/cbacks.t +t/chunking.t +t/closeys.t +t/corpus.t +t/corpus/2202jp.txt +t/corpus/2202jp.xml +t/corpus/2202jpx.txt +t/corpus/2202jpx.xml +t/corpus/2202jpy.txt +t/corpus/2202jpy.xml +t/corpus/2202jpz.txt +t/corpus/2202jpz.xml +t/corpus/8859_7.pod +t/corpus/8859_7.xml +t/corpus/cp1256.txt +t/corpus/cp1256.xml +t/corpus/enc_char_directive.txt +t/corpus/enc_char_directive.xml +t/corpus/enc_char_wrong_directive.txt +t/corpus/enc_char_wrong_directive.xml +t/corpus/encwarn01.txt +t/corpus/encwarn01.xml +t/corpus/encwarn02.txt +t/corpus/encwarn02.xml +t/corpus/encwarn03.txt +t/corpus/encwarn03.xml +t/corpus/encwarn04.txt +t/corpus/encwarn04.xml +t/corpus/fet_cont.txt +t/corpus/fet_cont.xml +t/corpus/fet_dup.txt +t/corpus/fet_dup.xml +t/corpus/iso6.txt +t/corpus/iso6.xml +t/corpus/koi8r.txt +t/corpus/koi8r.xml +t/corpus/laozi38.txt +t/corpus/laozi38.xml +t/corpus/laozi38b.txt +t/corpus/laozi38b.xml +t/corpus/laozi38p.pod +t/corpus/laozi38p.xml +t/corpus/lat1fr.txt +t/corpus/lat1fr.xml +t/corpus/lat1frim.txt +t/corpus/lat1frim.xml +t/corpus/nonesuch.txt +t/corpus/nonesuch.xml +t/corpus/pasternak_cp1251.txt +t/corpus/pasternak_cp1251.xml +t/corpus/plain.txt +t/corpus/plain.xml +t/corpus/plain_explicit.txt +t/corpus/plain_explicit.xml +t/corpus/plain_latin1.txt +t/corpus/plain_latin1.xml +t/corpus/plain_utf8.txt +t/corpus/plain_utf8.xml +t/corpus/polish_utf8.txt +t/corpus/polish_utf8.xml +t/corpus/s2763_sjis.txt +t/corpus/s2763_sjis.xml +t/corpus/thai_iso11.txt +t/corpus/thai_iso11.xml +t/corpus2/fiqhakbar_iso6.txt +t/corpus2/fiqhakbar_iso6.xml +t/corpus2/polish_implicit_utf8.txt +t/corpus2/polish_utf16be_bom.txt +t/corpus2/polish_utf16le_bom.txt +t/corpus2/polish_utf8_bom.txt +t/corpus2/polish_utf8_bom.xml +t/corpus2/polish_utf8_bom2.txt +t/corpus2/polish_utf8_bom2.xml +t/corpus2/README +t/emptylists.t +t/enc-chars.t +t/encod01.t +t/encod02.t +t/encod03.t +t/encod04.t +t/end_over.t +t/eol.t +t/eol2.t +t/fake-closers.t +t/fcodes.t +t/fcodes_e.t +t/fcodes_l.t +t/fcodes_s.t +t/for.t +t/fornot.t +t/heads.t +t/html01.t +t/html02.t +t/html03.t +t/htmlbat.t +t/items.t +t/items02.t +t/itemstar.t +t/junk1.pod +t/junk1o.txt +t/junk2.pod +t/junk2o.txt +t/linkclas.t +t/output.t +t/perlcyg.pod +t/perlcygo.txt +t/perlfaq.pod +t/perlfaqo.txt +t/perlvar.pod +t/perlvaro.txt +t/puller.t +t/pulltitl.t +t/reinit.t +t/render.t +t/search05.t +t/search10.t +t/search12.t +t/search20.t +t/search22.t +t/search25.t +t/search26.t +t/search27.t +t/search28.t +t/search29.t +t/search50.t +t/stree.t +t/strpvbtm.t +t/testlib1/Blorm.pm +t/testlib1/hinkhonk/Glunk.pod +t/testlib1/hinkhonk/readme.txt +t/testlib1/hinkhonk/Vliff.pm +t/testlib1/pod/perlflif.pod +t/testlib1/pod/perlthng.pod +t/testlib1/squaa.pm +t/testlib1/squaa/Glunk.pod +t/testlib1/squaa/Vliff.pm +t/testlib1/zikzik.pod +t/testlib1/Zonk/Fiddle.txt +t/testlib1/Zonk/Pronk.pm +t/testlib1/Zonk/Veng.pm +t/testlib2/hinkhonk/Glunk.pod +t/testlib2/hinkhonk/readme.txt +t/testlib2/hinkhonk/Vliff.pm +t/testlib2/pod/perlthng.pod +t/testlib2/pod/perlzuk.pod +t/testlib2/squaa/Vliff.pm +t/testlib2/squaa/Wowo.pod +t/testlib2/Suzzle.pm +t/testlib3/squaa/Vliff.pm +t/tiedfh.t +t/verb_fmt.t +t/verbatim.t +t/whine.t +t/x_nixer.t +t/xhtml-bkb.t +t/xhtml01.t +t/xhtml05.t +t/xhtml10.t +t/xhtml15.t +t/xhtml20.t -- 1.9.1
  Sun Jan 11 17:23:41 2015 dwheeler [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #101454] Files listed in MANIFEST not found in distribution
Date: Sun, 11 Jan 2015 14:23:26 -0800
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Jan 11, 2015, at 6:27 AM, James E Keenan via RT <bug-Pod-Simple@rt.cpan.org> wrote: Show quoted text
> So I think the solution is still to remove MANIFEST from .gitignore so as to prevent this problem going forward.
No, I wanted MANIFEST to be generated on release. Here’s how I build a new release from Git: git clean -dfx perl Makefile.PL make manifest make disttest make dist Best, David
  Sun Jan 11 17:23:41 2015 The RT System itself - Status changed from 'new' to 'open'
  Sun Jan 11 17:24:40 2015 dwheeler [...] cpan.org - Status changed from 'open' to 'rejected'