Bug #101443 for Math-GMP: Math::GMP needs bool overload

Sat Jan 10 10:36:54 2015 HVDS [...] cpan.org - Ticket created

Subject:

Math::GMP needs bool overload

Math::GMP->new($obj) can fail if $obj is already a Math::GMP object for a large number. This is because in new we have C< my $ival = shift || 0; >, and the boolean check falls back to the intify overload in the absence of an explicit bool overload (and the intify is truncating). Attached change is enough to fix that (forcing it to use the <=> overload instead); intify() itself could also do with improvement, but I haven't attempted that at this point. Hugo

Subject:

Math-GMP-bool-overload

Download Math-GMP-bool-overload
application/octet-stream 2k

Message body not shown because it is not plain text.

Sun Jun 07 19:44:56 2015 DANAJ [...] cpan.org - Correspondence added

It sounds like perhaps 92564 (incorrect intify) is the root cause?

Sun Jun 07 19:44:57 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 28 13:22:15 2015 SHLOMIF [...] cpan.org - Correspondence added

On Sat Jan 10 10:36:54 2015, HVDS wrote: Show quoted text

> Math::GMP->new($obj) can fail if $obj is already a Math::GMP object > for a large number. This is because in new we have C< my $ival = shift > || 0; >, and the boolean check falls back to the intify overload in > the absence of an explicit bool overload (and the intify is > truncating). > > Attached change is enough to fix that (forcing it to use the <=> > overload instead); intify() itself could also do with improvement, but > I haven't attempted that at this point. > > Hugo

Thanks for the patch. I applied a modified version of it in commit 28f3f97f3686ca6f3e037cd1e466ddace8c0c05c in the repository. See: https://github.com/turnstep/Math-GMP/commit/28f3f97f3686ca6f3e037cd1e466ddace8c0c05c RESOLVEDing. Regards, -- Shlomi Fish

Tue Jul 28 13:22:17 2015 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'