Bug #101413 for XML-LibXSLT: allow for setting of maxvars

Thu Jan 08 13:43:54 2015 krichel [...] openlib.org - Ticket created

Subject:	allow for setting of maxvars
Date:	Thu, 8 Jan 2015 18:43:35 +0000
To:	LibXSLT bug <bug-XML-LibXSLT [...] rt.cpan.org>
From:	Thomas Krichel <krichel [...] openlib.org>

This is a feature request rather than a bug report. XML::LibXSLT should support maxvars. maxvars XML::LibXSLT->maxvars(1000000); This option sets the maximum number of variables for a stylesheet. Default 15000. Otherwise is difficult write templates that are recursive. In many cases, a default of 15000 is not sufficient when recursion involves a function that carries many parameters. -- Cheers, Thomas Krichel http://openlib.org/home/krichel skype:thomaskrichel

Wed Jan 14 11:04:23 2015 SHLOMIF [...] cpan.org - Correspondence added

On Thu Jan 08 13:43:54 2015, krichel@openlib.org wrote: Show quoted text

> > This is a feature request rather than a bug report. > > XML::LibXSLT should support maxvars. > > maxvars > XML::LibXSLT->maxvars(1000000); > > This option sets the maximum number of variables for a > stylesheet. Default 15000. > > Otherwise is difficult write templates that are recursive. > In many cases, a default of 15000 is not sufficient when > recursion involves a function that carries many parameters. > >

I'd like to add this feature but I'm not sure this is the reason why it fails in Perl and XML::LibXSLT and succeeds in xsltproc, because xsltproc uses the same default value for that. Regards, -- Shlomi Fish

Wed Jan 14 11:04:24 2015 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 15 11:44:39 2015 krichel [...] openlib.org - Correspondence added

Subject:	Re: [rt.cpan.org #101413] allow for setting of maxvars
Date:	Thu, 15 Jan 2015 16:44:20 +0000
To:	Shlomi Fish via RT <bug-XML-LibXSLT [...] rt.cpan.org>
From:	Thomas Krichel <krichel [...] openlib.org>

Shlomi Fish via RT writes Show quoted text

> I'd like to add this feature

That would be wonderful. Show quoted text

> but I'm not sure this is the reason why it fails in Perl and > XML::LibXSLT and succeeds in xsltproc, because xsltproc uses the > same default value for that.

For me, it also fails in xsltproc. I did run it to save output and error krichel@trabbi:~/public_html/home/krichel/maxvars$ xsltproc maxvars.xslt.xml maxvars_big.xml > xsltproc_output 2> xsltproc_error This is now on the site http://openlib.org/home/krichel/maxvars/ Maybe you ran the xsltproc in maxvars_small.xml? This is only for illustration that the template would complete in case the data is small. This is to demonstrated that there is nothing wrong with the template itself. Or maybe you have a different version of xsltproc. Mine is krichel@trabbi:~/public_html/home/krichel/maxvars$ xsltproc --version Using libxml 20901, libxslt 10128 and libexslt 817 xsltproc was compiled against libxml 20902, libxslt 10128 and libexslt 817 libxslt 10128 was compiled against libxml 20902 libexslt 817 was compiled against libxml 20902 Thanks and cheers, Thomas Krichel http://openlib.org/home/krichel skype:thomaskrichel

Sat Jan 17 14:05:58 2015 SHLOMIF [...] cpan.org - Correspondence added

Hi Thomas, please see: https://metacpan.org/source/SHLOMIF/XML-LibXSLT-1.93/Changes This was implemented without a test (as "max_vars" for consistency with "max_depth"). Please let me know if it fixes your issue. Regards, -- Shlomi Fish

Sun Jan 18 12:32:05 2015 krichel [...] openlib.org - Correspondence added

Subject:	Re: [rt.cpan.org #101413] allow for setting of maxvars
Date:	Sun, 18 Jan 2015 17:31:49 +0000
To:	Shlomi Fish via RT <bug-XML-LibXSLT [...] rt.cpan.org>
From:	Thomas Krichel <krichel [...] openlib.org>

Shlomi Fish via RT writes Show quoted text

> please see: > > https://metacpan.org/source/SHLOMIF/XML-LibXSLT-1.93/Changes > > This was implemented without a test (as "max_vars" for consistency with "max_depth"). Please let me know if it fixes your issue. >

It does. It took me a while to figure out how to get it to run but it works perfectly. Thank you so much. You are my hero. Let me know when/if you make it to NYC. -- Cheers, Thomas Krichel http://openlib.org/home/krichel skype:thomaskrichel

Sun Jan 18 12:39:30 2015 SHLOMIF [...] cpan.org - Correspondence added

Hi Thomas, On Sun Jan 18 12:32:05 2015, krichel@openlib.org wrote: Show quoted text

> Shlomi Fish via RT writes >

> > please see: > > > > https://metacpan.org/source/SHLOMIF/XML-LibXSLT-1.93/Changes > > > > This was implemented without a test (as "max_vars" for consistency > > with "max_depth"). Please let me know if it fixes your issue. > >

> > It does. It took me a while to figure out how to get it to run but > it works perfectly.

Nice! I'm glad. Show quoted text

> Thank you so much. You are my hero.

Thanks and - you're welcome. :-). Show quoted text

> Let me know > when/if you make it to NYC.

:-) Closing this bug then as RESOLVED. -- Shlomi Fish

Sun Jan 18 12:39:32 2015 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'