Bug #101374 for Archive-Zip: broken testZip autodetection

Wed Jan 07 09:02:37 2015 zefram [...] fysh.org - Ticket created

Subject:	broken testZip autodetection
Date:	Wed, 7 Jan 2015 14:02:22 +0000
To:	bug-Archive-Zip [...] rt.cpan.org
From:	Zefram <zefram [...] fysh.org>

If the unzip(1) program isn't available, Archive-Zip's test suite attempts to use it to test zip files, and so spuriously fails. The attached patch fixes the autodetection logic. -zefram

Message body is not shown because sender requested not to inline it.

Fri Jan 09 21:47:15 2015 PHRED [...] cpan.org - Correspondence added

Thanks, resolved with 1.41 which is enroute to CPAN.

Fri Jan 09 21:47:16 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Jan 09 21:47:22 2015 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jan 11 19:36:21 2015 PHRED [...] cpan.org - Correspondence added

Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 Please take a look and submit a new patch, have to revert this one.

Sun Jan 11 19:36:27 2015 PHRED [...] cpan.org - Status changed from 'resolved' to 'open'

Mon Jan 12 07:04:53 2015 zefram [...] fysh.org - Correspondence added

CC:	zefram [...] fysh.org, SMPETERS [...] cpan.org
Subject:	Re: [rt.cpan.org #101374] broken testZip autodetection
Date:	Mon, 12 Jan 2015 12:04:29 +0000
To:	bug-Archive-Zip [...] rt.cpan.org
From:	Zefram <zefram [...] fysh.org>

Show quoted text

>Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 > >Please take a look and submit a new patch, have to revert this one.

Those errors do not appear to be caused by my patch. They appear to be genuine test failures, of a variety of types. The simplest type depends on choice of directory separator, which I'm quite sure my patch doesn't affect. Clearly you need to adjust those tests for Windows, and the fact that you didn't see the failures before implies that they weren't running on Windows before. So I think you have a bunch of tests that were being erroneously skipped before, and my patch has incidentally fixed the test suite to run them. This is probably down to the extraneous "local" that my patch removed. I haven't caused new faults; I've uncovered preexisting faults that were hidden by another bug. -zefram

Mon Jan 12 13:11:09 2015 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #101374] broken testZip autodetection
Date:	Mon, 12 Jan 2015 10:10:56 -0800
To:	bug-Archive-Zip [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

Ok I'll take another look at this tonight and reapply. Maybe I can get a windows CI environment hooked up somehow. On Mon, Jan 12, 2015 at 4:04 AM, Zefram via RT <bug-Archive-Zip@rt.cpan.org> wrote: Show quoted text

> Queue: Archive-Zip > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101374 > >

>>Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 >> >>Please take a look and submit a new patch, have to revert this one.

> > Those errors do not appear to be caused by my patch. They appear to > be genuine test failures, of a variety of types. The simplest type > depends on choice of directory separator, which I'm quite sure my patch > doesn't affect. Clearly you need to adjust those tests for Windows, > and the fact that you didn't see the failures before implies that they > weren't running on Windows before. > > So I think you have a bunch of tests that were being erroneously skipped > before, and my patch has incidentally fixed the test suite to run them. > This is probably down to the extraneous "local" that my patch removed. > I haven't caused new faults; I've uncovered preexisting faults that were > hidden by another bug. > > -zefram >

Tue Jan 13 01:32:44 2015 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #101374] broken testZip autodetection
Date:	Mon, 12 Jan 2015 22:32:34 -0800
To:	bug-Archive-Zip [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

I pushed this change back on github. Will check cpantester reports when the machine is back up, should be a couple days. On Mon, Jan 12, 2015 at 10:11 AM, fred@redhotpenguin.com via RT <bug-Archive-Zip@rt.cpan.org> wrote: Show quoted text

> Queue: Archive-Zip > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101374 > > > Ok I'll take another look at this tonight and reapply. Maybe I can get > a windows CI environment hooked up somehow. > > On Mon, Jan 12, 2015 at 4:04 AM, Zefram via RT > <bug-Archive-Zip@rt.cpan.org> wrote:

>> Queue: Archive-Zip >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101374 > >>

>>>Patch to this issue caused https://rt.cpan.org/Ticket/Display.html?id=101442 >>> >>>Please take a look and submit a new patch, have to revert this one.

>> >> Those errors do not appear to be caused by my patch. They appear to >> be genuine test failures, of a variety of types. The simplest type >> depends on choice of directory separator, which I'm quite sure my patch >> doesn't affect. Clearly you need to adjust those tests for Windows, >> and the fact that you didn't see the failures before implies that they >> weren't running on Windows before. >> >> So I think you have a bunch of tests that were being erroneously skipped >> before, and my patch has incidentally fixed the test suite to run them. >> This is probably down to the extraneous "local" that my patch removed. >> I haven't caused new faults; I've uncovered preexisting faults that were >> hidden by another bug. >> >> -zefram >>

>

Thu Jan 15 00:34:45 2015 PWR [...] cpan.org - Correspondence added

Without this change I cannot install 1.42, linux 5.20.1, but can install 1.41. Installing unzip allowed me to install 1.42. I could not install 1.40 either but could 1.39. On windows, strawberry perl same version, I cannot install anything newer than 1.38, which is also shipped with the distribution.

Thu Jan 15 01:37:03 2015 PHRED [...] cpan.org - Correspondence added

Ok 1.43 is up on CPAN with this change. Will keep an eye on cpantesters to see if there are any effects.

Thu Jan 15 01:37:05 2015 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'