Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Date-Holidays CPAN distribution.

Report information
The Basics
Id: 101366
Status: open
Priority: 0/
Queue: Date-Holidays
People
Owner: jonasbn [...] cpan.org
Requestors: SNOOPYJC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 1.00
Fixed in: (no value)

History Show all quoted text
  Wed Jan 07 01:00:37 2015 SNOOPYJC [...] cpan.org - Ticket created
Subject: Date::Holidays->new doesn't pass state/province and other selectors to the sub-modules
Date::Holidays->new() doesn't pass along {province=>'BC', language='EN'} to Date::Holidays::CA or {state=>'NJ'} to Date::Holidays::US (which I'm writing). There is a "TODO" in your source code that mentions this fact!
  Wed Jan 07 15:23:21 2015 ether [...] cpan.org - Broken in 0.01 deleted
  Wed Jan 07 15:23:22 2015 ether [...] cpan.org - Broken in 0.02 deleted
  Wed Jan 07 15:23:22 2015 ether [...] cpan.org - Broken in 0.03 deleted
  Wed Jan 07 15:23:23 2015 ether [...] cpan.org - Broken in 0.04 deleted
  Wed Jan 07 15:23:23 2015 ether [...] cpan.org - Broken in 0.05 deleted
  Wed Jan 07 15:23:23 2015 ether [...] cpan.org - Broken in 0.06 deleted
  Wed Jan 07 15:23:24 2015 ether [...] cpan.org - Broken in 0.07 deleted
  Wed Jan 07 15:23:24 2015 ether [...] cpan.org - Broken in 0.08 deleted
  Wed Jan 07 15:23:26 2015 ether [...] cpan.org - Broken in 0.09 deleted
  Wed Jan 07 15:23:26 2015 ether [...] cpan.org - Broken in 0.10 deleted
  Wed Jan 07 15:23:26 2015 ether [...] cpan.org - Broken in 0.11 deleted
  Wed Jan 07 15:23:27 2015 ether [...] cpan.org - Broken in 0.12 deleted
  Wed Jan 07 15:23:27 2015 ether [...] cpan.org - Broken in 0.13 deleted
  Wed Jan 07 15:23:27 2015 ether [...] cpan.org - Broken in 0.14 deleted
  Wed Jan 07 15:23:28 2015 ether [...] cpan.org - Broken in 0.15 deleted
  Wed Jan 07 15:23:28 2015 ether [...] cpan.org - Broken in 0.16 deleted
  Wed Jan 07 15:23:28 2015 ether [...] cpan.org - Broken in 0.17 deleted
  Wed Jan 07 15:23:29 2015 ether [...] cpan.org - Broken in 0.18 deleted
  Wed Jan 07 15:23:30 2015 ether [...] cpan.org - Broken in 0.19 deleted
  Wed Jan 07 15:23:30 2015 ether [...] cpan.org - Broken in 0.20 deleted
  Wed Jan 07 15:23:31 2015 ether [...] cpan.org - Broken in 0.21 deleted
  Wed Jan 07 15:23:31 2015 ether [...] cpan.org - Broken in 0.22 deleted
  Mon Aug 10 16:39:54 2015 jonasbn [...] cpan.org - Correspondence added
This has been addressed in an earlier release, but I found some TODO markers in the code so I have revisited this in release 1.03, which has just been uploaded to CPAN. Thanks for the bug report, please let me know if you experience any further issues, take care. jonasbn
  Mon Aug 10 16:39:55 2015 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 10 16:39:57 2015 jonasbn [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Aug 10 16:46:07 2015 jonasbn [...] cpan.org - Correspondence added
Hmm, I addressed the TODOs, but that does not really account for the issue, you describe. I have re-opened the ticket in order to look into the constructor and your particular distribution with some extra test scenarios. Sorry for any confusion, it is all mine. jonasbn
  Mon Aug 10 16:46:08 2015 jonasbn [...] cpan.org - Status changed from 'resolved' to 'open'
  Mon Aug 31 13:48:03 2015 jonasbn [...] cpan.org - Reference to ticket #106793 added
  Mon Aug 31 13:48:32 2015 jonasbn [...] cpan.org - Reference to ticket #106793 deleted
  Mon Aug 31 13:48:32 2015 jonasbn [...] cpan.org - Dependency on ticket #106793 added
  Tue Jun 06 15:57:18 2017 jonasbn [...] cpan.org - Correspondence added
Migrated to Github. https://github.com/jonasbn/perl-date-holidays/issues/12