Bug #101345 for Encode: [PATCH] reduce compiler warnings and stderr noise

Tue Jan 06 08:45:17 2015 davem [...] iabyn.com - Ticket created

Subject:	[PATCH] reduce compiler warnings and stderr noise
Date:	Tue, 6 Jan 2015 13:45:08 +0000
To:	bug-Encode [...] rt.cpan.org
From:	Dave Mitchell <davem [...] iabyn.com>

Dear maintainer of a dual-lived CPAN distribution: I'm currently attempting to get bleadperl to be warnings-clean; i.e. where (./Configure && make) 2>errs leaves no lines in 'errs'. Recently bleadperl made the -W options passed to the C compiler more fascist, and in addition we're trying to get blead to compile and run cleanly under clang's -fsanitize=undefined option. Due to that and other reasons, bleadperl's build is currently very noisy. Attached (hopefully) to this ticket is one or more patches that reduce the noise of your distribution when built as part of bleadperl. It would be great if they could make it into a new release of your distribution in time for incorporation into perl-5.22.0. Our timetable is: 2015-01-20 5.21.8 Contentious changes freeze 2015-02-20 5.21.9 User-visible changes freeze 2015-03-20 5.21.10 Full code freeze 2015-05-20 5.22.0 Stable release! so for example if a new release of your distribution included contentious features, then it would need to be merged into blead *prior* to the 20th of Jan. Thanks, Dave M. -- The Enterprise is involved in a bizarre time-warp experience which is in some way unconnected with the Late 20th Century. -- Things That Never Happen in "Star Trek" #14

Message body is not shown because sender requested not to inline it.

Tue Jan 06 09:31:15 2015 DANKOGAI [...] cpan.org - Correspondence added

Thank you. Your patch is in: https://github.com/dankogai/p5-encode/commit/aec2497d30ecdceb37c2a09804b11305b3e5552e Dan the Maintainer Thereof On Tue Jan 06 08:45:17 2015, davem@iabyn.com wrote: Show quoted text

> Dear maintainer of a dual-lived CPAN distribution: I'm currently attempting > to get bleadperl to be warnings-clean; i.e. where > (./Configure && make) 2>errs > leaves no lines in 'errs'. Recently bleadperl made the -W options passed > to the C compiler more fascist, and in addition we're trying to get blead > to compile and run cleanly under clang's -fsanitize=undefined option. Due > to that and other reasons, bleadperl's build is currently very noisy. > > Attached (hopefully) to this ticket is one or more patches that reduce the > noise of your distribution when built as part of bleadperl. > > It would be great if they could make it into a new release of your > distribution in time for incorporation into perl-5.22.0. Our > timetable is: > > 2015-01-20 5.21.8 Contentious changes freeze > 2015-02-20 5.21.9 User-visible changes freeze > 2015-03-20 5.21.10 Full code freeze > 2015-05-20 5.22.0 Stable release! > > so for example if a new release of your distribution included contentious > features, then it would need to be merged into blead *prior* to the 20th > of Jan. > > Thanks, > > Dave M. > >

Tue Jan 06 09:31:15 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 06 09:31:26 2015 DANKOGAI [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jan 06 14:03:19 2015 SREZIC [...] cpan.org - Correspondence added

I am not sure I like this change. Usually stderr is used for diagnostic messages and stdout for payload content. This is also reflected in the default flushing policy: stderr is autoflushed, while stdout not (to improve performance when used in pipes). The stuff which used to be written by enc2xs to stderr is clearly diagnostic, so I would expect that it still should go to stderr. What about a new quiet option instead to cease all diagnostic messages? But unfortunately -q and -Q are already taken :-( Regards, Slaven On 2015-01-06 09:31:15, DANKOGAI wrote: Show quoted text

> Thank you. Your patch is in: > > https://github.com/dankogai/p5- > encode/commit/aec2497d30ecdceb37c2a09804b11305b3e5552e > > Dan the Maintainer Thereof > > On Tue Jan 06 08:45:17 2015, davem@iabyn.com wrote:

> > Dear maintainer of a dual-lived CPAN distribution: I'm currently > > attempting > > to get bleadperl to be warnings-clean; i.e. where > > (./Configure && make) 2>errs > > leaves no lines in 'errs'. Recently bleadperl made the -W options > > passed > > to the C compiler more fascist, and in addition we're trying to get > > blead > > to compile and run cleanly under clang's -fsanitize=undefined option. > > Due > > to that and other reasons, bleadperl's build is currently very noisy. > > > > Attached (hopefully) to this ticket is one or more patches that > > reduce the > > noise of your distribution when built as part of bleadperl. > > > > It would be great if they could make it into a new release of your > > distribution in time for incorporation into perl-5.22.0. Our > > timetable is: > > > > 2015-01-20 5.21.8 Contentious changes freeze > > 2015-02-20 5.21.9 User-visible changes freeze > > 2015-03-20 5.21.10 Full code freeze > > 2015-05-20 5.22.0 Stable release! > > > > so for example if a new release of your distribution included > > contentious > > features, then it would need to be merged into blead *prior* to the > > 20th > > of Jan. > > > > Thanks, > > > > Dave M. > > > >

Tue Jan 06 14:11:48 2015 DANKOGAI [...] cpan.org - Correspondence added

I have to admit I did not think much when I accepted your patch. While -[qQ] are taken, -[vV] are still available... Dan the Maintainer Thereof On Tue Jan 06 14:03:19 2015, SREZIC wrote: Show quoted text

> I am not sure I like this change. Usually stderr is used for > diagnostic messages and stdout for payload content. This is also > reflected in the default flushing policy: stderr is autoflushed, while > stdout not (to improve performance when used in pipes). The stuff > which used to be written by enc2xs to stderr is clearly diagnostic, so > I would expect that it still should go to stderr. What about a new > quiet option instead to cease all diagnostic messages? But > unfortunately -q and -Q are already taken :-( > > Regards, > Slaven > > On 2015-01-06 09:31:15, DANKOGAI wrote:

> > Thank you. Your patch is in: > > > > https://github.com/dankogai/p5- > > encode/commit/aec2497d30ecdceb37c2a09804b11305b3e5552e > > > > Dan the Maintainer Thereof > > > > On Tue Jan 06 08:45:17 2015, davem@iabyn.com wrote:

> > > Dear maintainer of a dual-lived CPAN distribution: I'm currently > > > attempting > > > to get bleadperl to be warnings-clean; i.e. where > > > (./Configure && make) 2>errs > > > leaves no lines in 'errs'. Recently bleadperl made the -W options > > > passed > > > to the C compiler more fascist, and in addition we're trying to get > > > blead > > > to compile and run cleanly under clang's -fsanitize=undefined > > > option. > > > Due > > > to that and other reasons, bleadperl's build is currently very > > > noisy. > > > > > > Attached (hopefully) to this ticket is one or more patches that > > > reduce the > > > noise of your distribution when built as part of bleadperl. > > > > > > It would be great if they could make it into a new release of your > > > distribution in time for incorporation into perl-5.22.0. Our > > > timetable is: > > > > > > 2015-01-20 5.21.8 Contentious changes freeze > > > 2015-02-20 5.21.9 User-visible changes freeze > > > 2015-03-20 5.21.10 Full code freeze > > > 2015-05-20 5.22.0 Stable release! > > > > > > so for example if a new release of your distribution included > > > contentious > > > features, then it would need to be merged into blead *prior* to the > > > 20th > > > of Jan. > > > > > > Thanks, > > > > > > Dave M. > > > > > >

Tue Jan 06 14:11:54 2015 DANKOGAI [...] cpan.org - Status changed from 'resolved' to 'open'

Tue Jan 06 14:27:44 2015 DANKOGAI [...] cpan.org - Correspondence added

Added -v (and $ENV{ENC2XS_VERBOSE}). https://github.com/dankogai/p5-encode/commit/f5240ca80607eac7d0bb61cc0ab6a2d0b998b2b0 How's this? Dan the Maintainer Thereof On Tue Jan 06 14:03:19 2015, SREZIC wrote: Show quoted text

> I am not sure I like this change. Usually stderr is used for > diagnostic messages and stdout for payload content. This is also > reflected in the default flushing policy: stderr is autoflushed, while > stdout not (to improve performance when used in pipes). The stuff > which used to be written by enc2xs to stderr is clearly diagnostic, so > I would expect that it still should go to stderr. What about a new > quiet option instead to cease all diagnostic messages? But > unfortunately -q and -Q are already taken :-( > > Regards, > Slaven > > On 2015-01-06 09:31:15, DANKOGAI wrote:

> > Thank you. Your patch is in: > > > > https://github.com/dankogai/p5- > > encode/commit/aec2497d30ecdceb37c2a09804b11305b3e5552e > > > > Dan the Maintainer Thereof > > > > On Tue Jan 06 08:45:17 2015, davem@iabyn.com wrote:

> > > Dear maintainer of a dual-lived CPAN distribution: I'm currently > > > attempting > > > to get bleadperl to be warnings-clean; i.e. where > > > (./Configure && make) 2>errs > > > leaves no lines in 'errs'. Recently bleadperl made the -W options > > > passed > > > to the C compiler more fascist, and in addition we're trying to get > > > blead > > > to compile and run cleanly under clang's -fsanitize=undefined > > > option. > > > Due > > > to that and other reasons, bleadperl's build is currently very > > > noisy. > > > > > > Attached (hopefully) to this ticket is one or more patches that > > > reduce the > > > noise of your distribution when built as part of bleadperl. > > > > > > It would be great if they could make it into a new release of your > > > distribution in time for incorporation into perl-5.22.0. Our > > > timetable is: > > > > > > 2015-01-20 5.21.8 Contentious changes freeze > > > 2015-02-20 5.21.9 User-visible changes freeze > > > 2015-03-20 5.21.10 Full code freeze > > > 2015-05-20 5.22.0 Stable release! > > > > > > so for example if a new release of your distribution included > > > contentious > > > features, then it would need to be merged into blead *prior* to the > > > 20th > > > of Jan. > > > > > > Thanks, > > > > > > Dave M. > > > > > >

Tue Jan 06 14:27:50 2015 DANKOGAI [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jan 06 15:16:02 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-01-06 14:27:44, DANKOGAI wrote: Show quoted text

> Added -v (and $ENV{ENC2XS_VERBOSE}). > > https://github.com/dankogai/p5- > encode/commit/f5240ca80607eac7d0bb61cc0ab6a2d0b998b2b0 > > How's this?

Better! Show quoted text

> > Dan the Maintainer Thereof > > On Tue Jan 06 14:03:19 2015, SREZIC wrote:

> > I am not sure I like this change. Usually stderr is used for > > diagnostic messages and stdout for payload content. This is also > > reflected in the default flushing policy: stderr is autoflushed, > > while > > stdout not (to improve performance when used in pipes). The stuff > > which used to be written by enc2xs to stderr is clearly diagnostic, > > so > > I would expect that it still should go to stderr. What about a new > > quiet option instead to cease all diagnostic messages? But > > unfortunately -q and -Q are already taken :-( > > > > Regards, > > Slaven > > > > On 2015-01-06 09:31:15, DANKOGAI wrote:

> > > Thank you. Your patch is in: > > > > > > https://github.com/dankogai/p5- > > > encode/commit/aec2497d30ecdceb37c2a09804b11305b3e5552e > > > > > > Dan the Maintainer Thereof > > > > > > On Tue Jan 06 08:45:17 2015, davem@iabyn.com wrote:

> > > > Dear maintainer of a dual-lived CPAN distribution: I'm currently > > > > attempting > > > > to get bleadperl to be warnings-clean; i.e. where > > > > (./Configure && make) 2>errs > > > > leaves no lines in 'errs'. Recently bleadperl made the -W options > > > > passed > > > > to the C compiler more fascist, and in addition we're trying to > > > > get > > > > blead > > > > to compile and run cleanly under clang's -fsanitize=undefined > > > > option. > > > > Due > > > > to that and other reasons, bleadperl's build is currently very > > > > noisy. > > > > > > > > Attached (hopefully) to this ticket is one or more patches that > > > > reduce the > > > > noise of your distribution when built as part of bleadperl. > > > > > > > > It would be great if they could make it into a new release of > > > > your > > > > distribution in time for incorporation into perl-5.22.0. Our > > > > timetable is: > > > > > > > > 2015-01-20 5.21.8 Contentious changes freeze > > > > 2015-02-20 5.21.9 User-visible changes freeze > > > > 2015-03-20 5.21.10 Full code freeze > > > > 2015-05-20 5.22.0 Stable release! > > > > > > > > so for example if a new release of your distribution included > > > > contentious > > > > features, then it would need to be merged into blead *prior* to > > > > the > > > > 20th > > > > of Jan. > > > > > > > > Thanks, > > > > > > > > Dave M. > > > > > > > >