Bug #101263 for Git-Bunch: Test suite may fail with non-English locale (0.41)

Sat Jan 03 05:11:15 2015 SREZIC [...] cpan.org - Ticket created

Subject:

Test suite may fail with non-English locale (0.41)

The test suite fails if a git with localized messages is used, for example: # Failed test 'repo1 is unclean (message)' # at t/01-basics.t line 88. # 'Unknown (exit=0, output=Auf Branch master # Änderungen, die nicht zum Commit vorgemerkt sind: # (benutzen Sie "git add <Datei>..." um die Änderungen zum Commit vorzumerken) # (benutzen Sie "git checkout -- <Datei>..." um die Änderungen im Arbeitsverzeichnis zu verwerfen) # # modified: d/b # # keine Änderungen zum Commit vorgemerkt (benutzen Sie "git add" und/oder "git commit -a") # )' # doesn't match '(?^i:needs commit)' # Looks like you failed 1 test of 3.

Sat Jan 03 06:47:48 2015 PERLANCAR [...] cpan.org - Correspondence added

On Sat Jan 03 05:11:15 2015, SREZIC wrote: Show quoted text

> The test suite fails if a git with localized messages is used, for > example: > > # Failed test 'repo1 is unclean (message)' > # at t/01-basics.t line 88. > # 'Unknown (exit=0, output=Auf Branch master > # Änderungen, die nicht zum Commit vorgemerkt sind: > # (benutzen Sie "git add <Datei>..." um die Änderungen zum Commit > vorzumerken) > # (benutzen Sie "git checkout -- <Datei>..." um die Änderungen im > Arbeitsverzeichnis zu verwerfen) > # > # modified: d/b > # > # keine Änderungen zum Commit vorgemerkt (benutzen Sie "git add" > und/oder "git commit -a") > # )' > # doesn't match '(?^i:needs commit)' > # Looks like you failed 1 test of 3.

I've peppered more "LANG=C" to the rest of 'git' commands. Released 0.42. Regards, Steven

Sat Jan 03 06:47:48 2015 The RT System itself - Status changed from 'new' to 'open'

Sat Jan 03 06:47:49 2015 PERLANCAR [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Jan 03 07:07:28 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-01-03 06:47:48, PERLANCAR wrote: Show quoted text

> On Sat Jan 03 05:11:15 2015, SREZIC wrote:

> > The test suite fails if a git with localized messages is used, for > > example: > > > > # Failed test 'repo1 is unclean (message)' > > # at t/01-basics.t line 88. > > # 'Unknown (exit=0, output=Auf Branch master > > # Änderungen, die nicht zum Commit vorgemerkt sind: > > # (benutzen Sie "git add <Datei>..." um die Änderungen zum Commit > > vorzumerken) > > # (benutzen Sie "git checkout -- <Datei>..." um die Änderungen im > > Arbeitsverzeichnis zu verwerfen) > > # > > # modified: d/b > > # > > # keine Änderungen zum Commit vorgemerkt (benutzen Sie "git add" > > und/oder "git commit -a") > > # )' > > # doesn't match '(?^i:needs commit)' > > # Looks like you failed 1 test of 3.

> > I've peppered more "LANG=C" to the rest of 'git' commands. Released 0.42.

Setting LANG does not help. LANG has a very low precedence and is overruled by a LC_ALL setting. 0.42 still fails if LC_ALL is set to a non-English locale. Additionally Linux (but not FreeBSD) seems to have an env variable LANGUAGE which is set to something like "en_US:en" or "de_DE:de". It's not clear to me how LANGUAGE plays here, if it has a higher or lower precedence than the other env variables.

Sat Jan 03 07:07:35 2015 SREZIC [...] cpan.org - Status changed from 'resolved' to 'open'

Sat Jan 03 23:18:23 2015 PERLANCAR [...] cpan.org - Correspondence added

On Sat Jan 03 07:07:28 2015, SREZIC wrote: Show quoted text

> On 2015-01-03 06:47:48, PERLANCAR wrote:

> > On Sat Jan 03 05:11:15 2015, SREZIC wrote:

> > > The test suite fails if a git with localized messages is used, for > > > example: > > > > > > # Failed test 'repo1 is unclean (message)' > > > # at t/01-basics.t line 88. > > > # 'Unknown (exit=0, output=Auf Branch master > > > # Änderungen, die nicht zum Commit vorgemerkt sind: > > > # (benutzen Sie "git add <Datei>..." um die Änderungen zum Commit > > > vorzumerken) > > > # (benutzen Sie "git checkout -- <Datei>..." um die Änderungen im > > > Arbeitsverzeichnis zu verwerfen) > > > # > > > # modified: d/b > > > # > > > # keine Änderungen zum Commit vorgemerkt (benutzen Sie "git add" > > > und/oder "git commit -a") > > > # )' > > > # doesn't match '(?^i:needs commit)' > > > # Looks like you failed 1 test of 3.

> > > > I've peppered more "LANG=C" to the rest of 'git' commands. Released > > 0.42.

> > Setting LANG does not help. LANG has a very low precedence and is > overruled by a LC_ALL setting. 0.42 still fails if LC_ALL is set to a > non-English locale. > > Additionally Linux (but not FreeBSD) seems to have an env variable > LANGUAGE which is set to something like "en_US:en" or "de_DE:de". It's > not clear to me how LANGUAGE plays here, if it has a higher or lower > precedence than the other env variables.

In my testing, LANGUAGE is higher in precedence than LANG but lower than LC_*. Ok, 0.42 failed spectacularly. I'm now uploading 0.43 which sets LC_ALL+LANGUAGE+LANG (I'm extracting this functionality to a separate module and avoid using ad-hoc LANG=... prefix, which isn't supported in some shells like fish).

Sun Jan 04 05:29:46 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-01-03 23:18:23, PERLANCAR wrote: Show quoted text

> On Sat Jan 03 07:07:28 2015, SREZIC wrote:

> > On 2015-01-03 06:47:48, PERLANCAR wrote:

> > > On Sat Jan 03 05:11:15 2015, SREZIC wrote:

> > > > The test suite fails if a git with localized messages is used, > > > > for > > > > example: > > > > > > > > # Failed test 'repo1 is unclean (message)' > > > > # at t/01-basics.t line 88. > > > > # 'Unknown (exit=0, output=Auf Branch master > > > > # Änderungen, die nicht zum Commit vorgemerkt sind: > > > > # (benutzen Sie "git add <Datei>..." um die Änderungen zum > > > > Commit > > > > vorzumerken) > > > > # (benutzen Sie "git checkout -- <Datei>..." um die Änderungen > > > > im > > > > Arbeitsverzeichnis zu verwerfen) > > > > # > > > > # modified: d/b > > > > # > > > > # keine Änderungen zum Commit vorgemerkt (benutzen Sie "git add" > > > > und/oder "git commit -a") > > > > # )' > > > > # doesn't match '(?^i:needs commit)' > > > > # Looks like you failed 1 test of 3.

> > > > > > I've peppered more "LANG=C" to the rest of 'git' commands. Released > > > 0.42.

> > > > Setting LANG does not help. LANG has a very low precedence and is > > overruled by a LC_ALL setting. 0.42 still fails if LC_ALL is set to a > > non-English locale. > > > > Additionally Linux (but not FreeBSD) seems to have an env variable > > LANGUAGE which is set to something like "en_US:en" or "de_DE:de". > > It's > > not clear to me how LANGUAGE plays here, if it has a higher or lower > > precedence than the other env variables.

> > In my testing, LANGUAGE is higher in precedence than LANG but lower > than LC_*. > > Ok, 0.42 failed spectacularly. I'm now uploading 0.43 which sets > LC_ALL+LANGUAGE+LANG (I'm extracting this functionality to a separate > module and avoid using ad-hoc LANG=... prefix, which isn't supported > in some shells like fish).

0.43 looks fine.

Sun Jan 04 05:29:47 2015 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jan 04 05:29:47 2015 SREZIC [...] cpan.org - Fixed in 0.43 added