Bug #101240 for Archive-Zip: Possible issue with zero length files on Win32 when UNICODE is enabled

Thu Jan 01 19:16:44 2015 pmqs [...] cpan.org - Ticket created

Subject:

Possible issue with zero length files on Win32 when UNICODE is enabled

This section of code in extractToFileNamed doesn't look right. I don't have a Win32 setup to test it, but my reading of the code suggests that a zero length file stored in a zip archive will not be unzipped correctly when $Archive::Zip::UNICODE has been set. if ($^O eq 'MSWin32' && $Archive::Zip::UNICODE) { $name = decode_utf8(Win32::GetFullPathName($name)); mkpath_win32($name); if ($self->{'compressedSize'} == 0) { return; } else { Win32::CreateFile($name); } I think that any leading path will get created ok (via mkpath_win32), but the test for compressedSize == 0 will prevent the zero length file from getting created.

Sun Jan 11 07:07:13 2015 pmqs [...] cpan.org - Correspondence added

Found a Windows setup to verify that empty members don't get extracted when UNICODE is enabled. Health Warning - I don't do Winows development, so the enclosed patch needs verified by someone who does.

Subject:

101240.patch

diff --git a/MANIFEST b/MANIFEST index 2f9d199..17d481f 100644 --- a/MANIFEST +++ b/MANIFEST @@ -51,6 +51,7 @@ t/15_decrypt.t t/16_decrypt.t t/17_101092.t t/18_bug_92205.t +t/19_bug_101240.t t/badjpeg/expected.jpg t/badjpeg/source.zip t/common.pm diff --git a/lib/Archive/Zip/Member.pm b/lib/Archive/Zip/Member.pm index f440a36..b2ae11a 100644 --- a/lib/Archive/Zip/Member.pm +++ b/lib/Archive/Zip/Member.pm @@ -496,11 +496,7 @@ sub extractToFileNamed { if ($^O eq 'MSWin32' && $Archive::Zip::UNICODE) { $name = decode_utf8(Win32::GetFullPathName($name)); mkpath_win32($name); - if ($self->{'compressedSize'} == 0) { - return; - } else { - Win32::CreateFile($name); - } + Win32::CreateFile($name); ($status, $fh) = _newFileHandle(Win32::GetANSIPathName($name), 'w'); } else { mkpath(dirname($name)); # croaks on error

Subject:

101240.tar

Download 101240.tar
application/x-tar 10k

Message body not shown because it is not plain text.

Sun Jan 11 19:45:34 2015 PHRED [...] cpan.org - Correspondence added

Thanks, releasing 1.42 with this today. Removed 1.41 changes also since regression was caused.

Sun Jan 11 19:45:35 2015 The RT System itself - Status changed from 'new' to 'open'

Sun Jan 11 19:45:40 2015 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jan 11 19:45:41 2015 PHRED [...] cpan.org - Correspondence added

Thanks, releasing 1.42 with this today. Removed 1.41 changes also since regression was caused.