Bug #101220 for Fsdb: Possible longdouble issue

Wed Dec 31 09:05:45 2014 HMBRAND [...] cpan.org - Ticket created

Subject:

Possible longdouble issue

My perl is compiled with -Duselongdouble This is perl 5, version 20, subversion 1 (v5.20.1) built for x86_64-linux-thread-multi-ld The error I see doesn't hint me in anyway to what might be wrong (I tested this distribution as it depends on Text::CSV_XS, which is mine and I test against all depending releases before making a new release) not ok 43 - TEST/dbcolmovingstats_rounding_error.cmd # Failed test 'TEST/dbcolmovingstats_rounding_error.cmd' # at t/test_command.t line 208. # #### output of some failed tests # # TEST/dbcolmovingstats_rounding_error # #fsdb -F t a_short moving_mean moving_stddev diff # 0.8307 0.85053 0.035783 ~ # 0.7976 0.84881 0.037506 ~ # 0.8178 0.84727 0.038142 ~ # 0.806 0.84931 0.035787 ~ # 0.7293 0.78536 0.050969 ~ # 0.7474 0.77379 0.04636 ~ # 0.7938 0.76523 0.04191 ~ # 0.8144 0.76484 0.041385 ~ # 0.833 0.76449 0.040741 ~ # 0.8647 0.76864 0.047607 ~ # 0.8782 0.77374 0.053553 ~ # 0.8904 0.78083 0.059144 ~ # 0.9014 0.7915 0.060745 ~ # 0.9112 0.8011 0.063812 ~ # 0.9201 0.81224 0.064185 ~ # 0.8781 0.81977 0.062534 ~ # 0.883 0.85136 0.057396 ~ # 0.9052 0.86535 0.04945 ~ # 0.9203 0.92093 0.029494 ~ # 0.8904 0.91945 0.030268 ~ # 0.9112 0.9205 0.029558 ~ # 0.9201 0.92095 0.029476 ~ # 0.9039 0.92835 0.02642 ~ # 0.9352 0.91909 0.01577 ~ # 0.9242 0.87672 0.045342 ~ # 0.9318 0.87655 0.045117 ~ # 0.9448 0.87876 0.047242 ~ # 0.9553 0.8828 0.051682 ~ # 0.9097 0.88452 0.051991 ~ # 0.9188 0.88607 0.052553 ~ # 0.9342 0.89597 0.050234 ~ # 0.9017 0.90624 0.036043 ~ # 0.9283 0.9181 0.022076 ~ # 0.9355 0.92129 0.019475 ~ # 0.833 0.90084 0.036118 ~ # 0.8333 0.88796 0.042898 ~ # 0.85 0.88375 0.042248 ~ # 0.7585 0.8728 0.05209 ~ # 0.8311 0.83582 0.039875 ~ # 0.7647 0.82388 0.041509 ~ # 0.7282 0.81523 0.042559 ~ # 0.7554 0.80745 0.038121 ~ # 0.7799 0.80378 0.03699 ~ # 0.8019 0.80048 0.033772 ~ # 0.8217 0.80084 0.033967 ~ # 0.8106 0.79671 0.031104 ~ # 0.8381 0.81723 0.029996 ~ # 0.882 0.83063 0.029285 ~ # 0.8094 0.83273 0.028153 ~ # 0.8456 0.83443 0.027801 ~ # 0.83 0.83356 0.0277 ~ # 0.8284 0.8582 0.022608 ~ # 0.816 0.85364 0.026568 ~ # 0.801 0.85045 0.029192 ~ # 0.7835 0.83302 0.036542 ~ # 0.8246 0.82991 0.036678 ~ # 0.7629 0.82014 0.036537 ~ # 0.7866 0.81479 0.032862 ~ # 0.808 0.81248 0.031543 ~ # 0.8272 0.8104 0.028894 ~ # 0.8445 0.80853 0.024966 ~ # 0.9173 0.82936 0.047818 ~ # 0.9397 0.84624 0.060246 ~ # 0.9013 0.89255 0.060355 ~ # 0.9201 0.90664 0.044906 ~ # Looks like you failed 1 test of 275. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/275 subtests Test Summary Report ------------------- t/test_command.t (Wstat: 256 Tests: 275 Failed: 1) Failed test: 43 Non-zero exit status: 1 Files=1, Tests=275, 141 wallclock secs ( 0.10 usr 0.01 sys + 41.55 cusr 5.92 csys = 47.58 CPU) Result: FAIL

Thu Jan 01 18:53:41 2015 johnh [...] isi.edu - Correspondence added

Subject:	Re: [rt.cpan.org #101220] Possible longdouble issue
Date:	Thu, 01 Jan 2015 15:53:01 -0800
To:	bug-Fsdb [...] rt.cpan.org
From:	John Heidemann <johnh [...] isi.edu>

On Wed, 31 Dec 2014 09:05:46 -0500, "H.Merijn Brand via RT" wrote: Show quoted text

>Wed Dec 31 09:05:45 2014: Request 101220 was acted upon. >Transaction: Ticket created by HMBRAND > Queue: Fsdb > Subject: Possible longdouble issue > Broken in: 2.54 > Severity: (no value) > Owner: Nobody > Requestors: HMBRAND@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101220 > > > >My perl is compiled with -Duselongdouble > >This is perl 5, version 20, subversion 1 (v5.20.1) built for x86_64-linux-thread-multi-ld > >The error I see doesn't hint me in anyway to what might be wrong >(I tested this distribution as it depends on Text::CSV_XS, which is mine and I test against all depending releases before making a new release) > >not ok 43 - TEST/dbcolmovingstats_rounding_error.cmd > ># Failed test 'TEST/dbcolmovingstats_rounding_error.cmd' ># at t/test_command.t line 208. > ># #### output of some failed tests ># # TEST/dbcolmovingstats_rounding_error ># #fsdb -F t a_short moving_mean moving_stddev diff ># 0.8307 0.85053 0.035783 ~

... Show quoted text

># 0.9397 0.84624 0.060246 ~ ># 0.9013 0.89255 0.060355 ~ ># 0.9201 0.90664 0.044906 ~ ># Looks like you failed 1 test of 275. >Dubious, test returned 1 (wstat 256, 0x100) >Failed 1/275 subtests > >Test Summary Report >------------------- >t/test_command.t (Wstat: 256 Tests: 275 Failed: 1) > Failed test: 43 > Non-zero exit status: 1 >Files=1, Tests=275, 141 wallclock secs ( 0.10 usr 0.01 sys + 41.55 cusr 5.92 csys = 47.58 CPU) >Result: FAIL >

Thanks, Merijn, for posting this. I've trying to tracking down, slowly, the set of test failures I get on a few platforms on this test case for a long time. I'm fairly certain this is just a test case failure that results from different FP precision, and I need to fix it by making the tests more accepting. But to confirm, can you please post the file TEST/dbcolmovingstats_rounding_error.trial as an attachment to this ticket? (This is the output the test suite generates that does not end up matching what I expect in TEST/dbcolmovingstats_rounding_error.out.) Thanks, -John

Thu Jan 01 18:53:42 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Jan 02 02:20:05 2015 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #101220] Possible longdouble issue
Date:	Fri, 2 Jan 2015 08:19:39 +0100
To:	bug-Fsdb [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Thu, 1 Jan 2015 18:53:42 -0500, "John Heidemann via RT" <bug-Fsdb@rt.cpan.org> wrote: Show quoted text

> But to confirm, can you please post the file > TEST/dbcolmovingstats_rounding_error.trial as an attachment to this > ticket? (This is the output the test suite generates that does not end > up matching what I expect in TEST/dbcolmovingstats_rounding_error.out.)

-- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.21 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Download dbcolmovingstats_rounding_error.trial
application/octet-stream 109.1k

Message body not shown because it is not plain text.

Download (untitled)
application/pgp-signature 490b

Message body not shown because it is not plain text.

Sun Jan 04 19:36:45 2015 johnh [...] isi.edu - Correspondence added

Subject:	Re: [rt.cpan.org #101220] Possible longdouble issue
Date:	Sun, 04 Jan 2015 16:36:04 -0800
To:	bug-Fsdb [...] rt.cpan.org
From:	John Heidemann <johnh [...] isi.edu>

On Fri, 02 Jan 2015 02:20:05 -0500, "h.m.brand@xs4all.nl via RT" wrote: Show quoted text

> Queue: Fsdb > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101220 > > >On Thu, 1 Jan 2015 18:53:42 -0500, "John Heidemann via RT" ><bug-Fsdb@rt.cpan.org> wrote: >

>> But to confirm, can you please post the file >> TEST/dbcolmovingstats_rounding_error.trial as an attachment to this >> ticket? (This is the output the test suite generates that does not end >> up matching what I expect in TEST/dbcolmovingstats_rounding_error.out.)

> >-- >H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ >using perl5.00307 .. 5.21 porting perl5 on HP-UX, AIX, and openSUSE >http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ >http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/ >

Can you please try http://www.isi.edu/~johnh/Fsdb-pre-2.55.tar.gz and see if it passes this test for you? I have not yet released this version, but will do so when it passes. Thanks, -John Heidemann

Mon Jan 05 02:17:13 2015 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #101220] Possible longdouble issue
Date:	Mon, 5 Jan 2015 08:15:24 +0100
To:	bug-Fsdb [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Sun, 4 Jan 2015 19:36:45 -0500, "John Heidemann via RT" <bug-Fsdb@rt.cpan.org> wrote: Show quoted text

> On Fri, 02 Jan 2015 02:20:05 -0500, "h.m.brand@xs4all.nl via RT" wrote:

>> Queue: Fsdb >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101220 > >> >>On Thu, 1 Jan 2015 18:53:42 -0500, "John Heidemann via RT" <bug-Fsdb@rt.cpan.org> wrote: >>

>>> But to confirm, can you please post the file >>> TEST/dbcolmovingstats_rounding_error.trial as an attachment to this >>> ticket? (This is the output the test suite generates that does not end >>> up matching what I expect in TEST/dbcolmovingstats_rounding_error.out.)

> > Can you please try http://www.isi.edu/~johnh/Fsdb-pre-2.55.tar.gz > and see if it passes this test for you?

t/00-load.t ....... 1/1 # Testing Fsdb 2.55, Perl 5.020001, /pro/bin/perl5.20.1 t/00-load.t ....... ok t/boilerplate.t ... ok t/find_epsilon.t .. ok t/pod-coverage.t .. ok t/pod.t ........... ok t/test_command.t .. 99/275 # test TEST/dbfilealter_compress_gzip.cmd skipped (disabled in .cmd) t/test_command.t .. ok All tests successful. Files=6, Tests=477, 142 wallclock secs ( 0.14 usr 0.01 sys + 43.03 cusr 6.41 csys = 49.59 CPU) Result: PASS Show quoted text

> I have not yet released this version, but will do so when it passes.

Too nice a one-liner to skip :) $ perl -pi -e's/\because/because/' TEST/dbfilealter_compress_gzip.cmd # gzip gives non-determinstic output ecause it embeds the time in the header ^ Other spell-check issues found with my pod-spell-check are attached. Happy editing :) -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.21 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Download pod-spell-check
application/octet-stream 8.1k

Message body not shown because it is not plain text.

Download fsdb.out
application/octet-stream 162.9k

Message body not shown because it is not plain text.

Download (untitled)
application/pgp-signature 490b

Message body not shown because it is not plain text.

Mon Jan 05 17:46:00 2015 johnh [...] isi.edu - Correspondence added

Subject:	Re: [rt.cpan.org #101220] Possible longdouble issue
Date:	Mon, 05 Jan 2015 14:45:37 -0800
To:	bug-Fsdb [...] rt.cpan.org
From:	John Heidemann <johnh [...] isi.edu>

On Fri, 02 Jan 2015 02:20:05 -0500, "h.m.brand@xs4all.nl via RT" wrote: Show quoted text

> Queue: Fsdb > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101220 > > >On Thu, 1 Jan 2015 18:53:42 -0500, "John Heidemann via RT" ><bug-Fsdb@rt.cpan.org> wrote: >

>> But to confirm, can you please post the file >> TEST/dbcolmovingstats_rounding_error.trial as an attachment to this >> ticket? (This is the output the test suite generates that does not end >> up matching what I expect in TEST/dbcolmovingstats_rounding_error.out.)

Ok, the bug you reported should be fixed in Fsdb-2.55, just push to CPAN. Also the many, many spelling errors you reported. (Thanks... mostly :-) It's unclear how one actually closes out tickets at rt.cpan.org, but that should close this bug report. Thanks! -John

Mon Jan 05 17:55:41 2015 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #101220] Possible longdouble issue
Date:	Mon, 5 Jan 2015 23:55:24 +0100
To:	bug-Fsdb [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Mon, 5 Jan 2015 17:46:01 -0500, "John Heidemann via RT" <bug-Fsdb@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=101220 > > > On Fri, 02 Jan 2015 02:20:05 -0500, "h.m.brand@xs4all.nl via RT" wrote:

> > Queue: Fsdb > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101220 > > > > >On Thu, 1 Jan 2015 18:53:42 -0500, "John Heidemann via RT" > ><bug-Fsdb@rt.cpan.org> wrote: > >

> >> But to confirm, can you please post the file > >> TEST/dbcolmovingstats_rounding_error.trial as an attachment to this > >> ticket? (This is the output the test suite generates that does not end > >> up matching what I expect in TEST/dbcolmovingstats_rounding_error.out.)

> > Ok, the bug you reported should be fixed in Fsdb-2.55, > just push to CPAN. > Also the many, many spelling errors you reported. > (Thanks... mostly :-) > > It's unclear how one actually closes out tickets at rt.cpan.org, > but that should close this bug report.

I'll close it for you. Thanks for your prompt fix. (Thanks on behalf of your users, as I do not (yet) use Fsdb) -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.21 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Download (untitled)
application/pgp-signature 490b

Message body not shown because it is not plain text.

Tue Jan 06 02:43:44 2015 HMBRAND [...] cpan.org - Fixed in 2.55 added

Tue Jan 06 02:43:45 2015 HMBRAND [...] cpan.org - Status changed from 'open' to 'resolved'