Skip Menu |

This queue is for tickets about the GnuPG-Interface CPAN distribution.

Report information
The Basics
Id: 101189
Status: resolved
Priority: 0/
Queue: GnuPG-Interface

People
Owner: Nobody in particular
Requestors: LRUPP [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.51
Fixed in: (no value)



Subject: get_keys does not know about record type "grp"
When I compile GnuPG::Interface with gpg 2.1.0, I get the following error during tests: [ 73s] t/detach_sign.t ............ [ 73s] Failed 2/2 subtests [ 74s] unknown record type grp at /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm line 599, <GEN27> line 5. [ 74s] unknown record type grp at /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm line 599, <GEN27> line 14. [ 74s] t/encrypt.t ................ ok [ 76s] t/encrypt_symmetrically.t .. ok [ 76s] t/export_keys.t ............ ok [ 76s] t/Fingerprint.t ............ ok [ 77s] unknown record type grp at /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm line 599, <GEN14> line 5. [ 77s] unknown record type grp at /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm line 599, <GEN14> line 22. [ 77s] t/get_public_keys.t ........ [ 77s] Failed 1/3 subtests [ 77s] unknown record type grp at /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm line 599, <GEN14> line 4. [ 77s] unknown record type grp at /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm line 599, <GEN14> line 13. ...and indeed there is no handling for record "grp" in sub get_keys() as far as I can see. http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob_plain;f=doc/DETAILS shows some information about the grp records, but I have no clue how this should be handled inside lib/GnuPG/Interface.pm ...
Subject: Re: [rt.cpan.org #101189] get_keys does not know about record type "grp"
Date: Mon, 29 Dec 2014 11:53:04 -0500
To: bug-GnuPG-Interface [...] rt.cpan.org
From: Alex Vandiver <alexmv [...] bestpractical.com>
On 12/29/2014 08:07 AM, Lars Vogdt via RT wrote: Show quoted text
> When I compile GnuPG::Interface with gpg 2.1.0, I get the following > error during tests: > > [ 73s] t/detach_sign.t ............ [ 73s] Failed 2/2 subtests [ > 74s] unknown record type grp at > /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm > line 599, <GEN27> line 5. [ 74s] unknown record type grp at > /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm > line 599, <GEN27> line 14. [ 74s] t/encrypt.t ................ ok [ > 76s] t/encrypt_symmetrically.t .. ok [ 76s] t/export_keys.t > ............ ok [ 76s] t/Fingerprint.t ............ ok [ 77s] > unknown record type grp at > /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm > line 599, <GEN14> line 5. [ 77s] unknown record type grp at > /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm > line 599, <GEN14> line 22. [ 77s] t/get_public_keys.t ........ [ > 77s] Failed 1/3 subtests [ 77s] unknown record type grp at > /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm > line 599, <GEN14> line 4. [ 77s] unknown record type grp at > /home/abuild/rpmbuild/BUILD/GnuPG-Interface-0.51/blib/lib/GnuPG/Interface.pm > line 599, <GEN14> line 13. > > > ...and indeed there is no handling for record "grp" in sub get_keys() > as far as I can see. > > http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob_plain;f=doc/DETAILS > shows some information about the grp records, but I have no clue how > this should be handled inside lib/GnuPG/Interface.pm ...
I _believe_ that keygrip records are irrelevant to GnuPG::Interface. Do tests pass with the below patch? - Alex -------------------------------- >8 -------------------------------- From bb83ea915fc5389f29f9c4ef413df4b5ff6c34ce Mon Sep 17 00:00:00 2001 From: Alex Vandiver <alexmv@bestpractical.com> Date: Mon, 29 Dec 2014 11:50:10 -0500 Subject: [PATCH] Skip keygrip records, now generated by GPG 2.1.x --- lib/GnuPG/Interface.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/GnuPG/Interface.pm b/lib/GnuPG/Interface.pm index 4d98064..7f69294 100644 --- a/lib/GnuPG/Interface.pm +++ b/lib/GnuPG/Interface.pm @@ -595,7 +595,7 @@ sub get_keys { my ($pos, $size, $data) = @fields[ 1,2,3 ]; $current_key->pubkey_data->[$pos+0] = Math::BigInt->from_hex('0x'.$data); } - elsif ( $record_type ne 'tru' ) { + elsif ( $record_type ne 'tru' and $record_type ne 'grp' ) { warn "unknown record type $record_type"; } } -- 2.2.1