Bug #101185 for Data-Password: allow to select a character set

Mon Dec 29 04:02:20 2014 frederic.van.espen [...] escaux.com - Ticket created

Subject:	allow to select a character set
Date:	Mon, 29 Dec 2014 10:02:10 +0100
To:	bug-Data-Password [...] rt.cpan.org
From:	Frederic Van Espen <frederic.van.espen [...] escaux.com>

Hi, We use Data::Password to verify password strength and then add the password hash in our LDAP server. Then we push it to google apps. We recently encountered an issue where one of our users used a few characters in the password that are in the extended ascii set. Google only allow standard ascii characters. Would you be willing to accept a patch that contains a feature to only allow standard ascii by setting a variable? Cheers, Frederic -- Frederic Van Espen Product Development Engineer ESCAUX ESCAUX, the nr 1 alternative in Unified Communication Chaussée de Bruxelles 408, 1300 Wavre, Belgium www.escaux.com

Mon Jan 05 12:50:42 2015 razinf [...] cpan.org - Correspondence added

Dear Frederic, I will consider accepting your patch. Please send my the patch and we will discuss it. Best regars, Oded On Mon Dec 29 04:02:20 2014, frederic.van.espen@escaux.com wrote: Show quoted text

> Hi, > > We use Data::Password to verify password strength and then add the password > hash in our LDAP server. Then we push it to google apps. We recently > encountered an issue where one of our users used a few characters in the > password that are in the extended ascii set. Google only allow standard > ascii characters. > > Would you be willing to accept a patch that contains a feature to only > allow standard ascii by setting a variable? > > Cheers, > > Frederic >

Mon Jan 05 12:50:42 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 06 08:43:41 2015 frederic.van.espen [...] escaux.com - Correspondence added

Subject:	Re: [rt.cpan.org #101185] allow to select a character set
Date:	Tue, 6 Jan 2015 14:43:30 +0100
To:	bug-Data-Password [...] rt.cpan.org
From:	Frederic Van Espen <frederic.van.espen [...] escaux.com>

Hello Oded, On Mon, Jan 5, 2015 at 6:50 PM, Oded S. Resnik via RT < bug-Data-Password@rt.cpan.org> wrote: Show quoted text

> I will consider accepting your patch. Please send my the patch and we will > discuss it. >

The patch is attached. Any feedback and comments are welcomed! Cheers, Frederic -- Frederic Van Espen Product Development Engineer ESCAUX ESCAUX, the nr 1 alternative in Unified Communication Chaussée de Bruxelles 408, 1300 Wavre, Belgium www.escaux.com

Message body is not shown because sender requested not to inline it.

Fri Jan 16 16:28:35 2015 razinf [...] cpan.org - Correspondence added

Dear Frederic, I've looked at the patch you submited, thanks. I've decided on a more flexible implementation so that users can set what they like. I've uploaded an new version to CPAN today, I hope you like my implementaion. Bye Oded

Fri Jan 16 16:30:06 2015 razinf [...] cpan.org - Correspondence added

Resolved in new version 1.12

Fri Jan 16 16:30:08 2015 razinf [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jan 16 16:30:15 2015 razinf [...] cpan.org - Taken

Mon Jan 19 02:44:01 2015 frederic.van.espen [...] escaux.com - Correspondence added

Subject:	Re: [rt.cpan.org #101185] allow to select a character set
Date:	Mon, 19 Jan 2015 08:43:47 +0100
To:	bug-Data-Password [...] rt.cpan.org
From:	Frederic Van Espen <frederic.van.espen [...] escaux.com>

Hello Oded, Perfect! That's more flexible, and simpler. Just a few grammar and typo issues in the documentation. Patch for that is attached! Cheers, Frederic On Fri, Jan 16, 2015 at 10:28 PM, Oded S. Resnik via RT < bug-Data-Password@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=101185 > > > Dear Frederic, > I've looked at the patch you submited, thanks. > I've decided on a more flexible implementation so that users can set what > they like. > > I've uploaded an new version to CPAN today, I hope you like my > implementaion. > > Bye > > Oded > > >

-- Frederic Van Espen Product Development Engineer ESCAUX ESCAUX, the nr 1 alternative in Unified Communication Chaussée de Bruxelles 408, 1300 Wavre, Belgium Direct: +3227887544 Main: +3226860900 www.escaux.com

Message body is not shown because sender requested not to inline it.