Skip Menu |

This queue is for tickets about the parent CPAN distribution.

Report information
The Basics
Id: 101162
Status: resolved
Priority: 0/
Queue: parent

People
Owner: Nobody in particular
Requestors: BULKDD [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.228
Fixed in: 0.229



Subject: [PATCH] allow PERL_DISABLE_PMC to be defined from anywhere
I enable PERL_DISABLE_PMC in a .h, not in CCFLAGS. CCFLAGS on Unix typically has no -Ds in it, build options go into config.h, not Config.pm's CCFLAGS. This change allows PERL_DISABLE_PMC option to pass tests regardless of where it is defined. Related to http://perl5.git.perl.org/perl.git/commit/ebfad2b9fea703468a88acb6a1afbb759366ffd5
Subject: 0001-allow-PERL_DISABLE_PMC-to-be-defined-from-anywhere.patch
From 8ff68eb3b519d43d83118a8f156f285170a46da8 Mon Sep 17 00:00:00 2001 From: bulk88 <bulk88@hotmail.com> Date: Sun, 28 Dec 2014 02:12:57 -0500 Subject: [PATCH] allow PERL_DISABLE_PMC to be defined from anywhere I enable PERL_DISABLE_PMC in a .h, not in CCFLAGS. CCFLAGS on Unix typically has no -Ds in it, build options go into config.h, not Config.pm's CCFLAGS. This change allows PERL_DISABLE_PMC option to pass tests regardless of where it is defined. --- t/parent-pmc.t | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/t/parent-pmc.t b/t/parent-pmc.t index 851a438..f9c0330 100755 --- a/t/parent-pmc.t +++ b/t/parent-pmc.t @@ -13,8 +13,15 @@ use Config; use lib 't/lib'; plan skip_all => ".pmc are only available with 5.6 and later" if $] < 5.006; +my $no_pmc; +foreach(Config::non_bincompat_options()) { + if($_ eq "PERL_DISABLE_PMC"){ + $no_pmc = 1; + last; + } +} plan skip_all => ".pmc are disabled in this perl" - if $Config{ccflags} =~ /(?<!\w)-DPERL_DISABLE_PMC\b/; + if $no_pmc; plan tests => 3; use vars qw($got_here); -- 1.7.9.msysgit.0
Subject: Re: [rt.cpan.org #101162] [PATCH] allow PERL_DISABLE_PMC to be defined from anywhere
Date: Sun, 11 Jan 2015 19:54:13 +0100
To: bug-parent [...] rt.cpan.org
From: Max Maischein <corion [...] cpan.org>
Hello Daniel, thanks for the patch! This is just to let you know that I plan to add the ability, but the check in the tests would not work on older versions of Perl (I think), so I'll have to find out which versions need the test and then adapt it. parent.pm is available for older versions of Perl too, and I'd like to allow seamless installation. I assume this will take (another) one or two weeks until I find proper time to investigate this - sorry for the holdup. Thanks again for the contribution, -max Am 28.12.2014 um 08:17 schrieb Daniel Dragan via RT: Show quoted text
> Sun Dec 28 02:17:34 2014: Request 101162 was acted upon. > Transaction: Ticket created by BULKDD > Queue: parent > Subject: [PATCH] allow PERL_DISABLE_PMC to be defined from anywhere > Broken in: 0.228 > Severity: (no value) > Owner: Nobody > Requestors: BULKDD@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=101162 > > > > I enable PERL_DISABLE_PMC in a .h, not in CCFLAGS. CCFLAGS on Unix > typically has no -Ds in it, build options go into config.h, not > Config.pm's CCFLAGS. This change allows PERL_DISABLE_PMC option to pass > tests regardless of where it is defined. > > Related to http://perl5.git.perl.org/perl.git/commit/ebfad2b9fea703468a88acb6a1afbb759366ffd5 >
From: paul [...] city-fan.org
On Sun Jan 11 13:54:57 2015, CORION wrote: Show quoted text
> Hello Daniel, > > thanks for the patch! > > This is just to let you know that I plan to add the ability, but the > check in the tests would not work on older versions of Perl (I think), > so I'll have to find out which versions need the test and then adapt > it. > parent.pm is available for older versions of Perl too, and I'd like to > allow seamless installation.
The Config::non_bincompat_options() function appears to have been introduced in Perl 5.13.10 - at least that's where it starts appearing in the documentation for Config. Running the test suite on older Perls results in this: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/compile-time-file............ok t/compile-time.................ok t/parent-classfromclassfile....ok t/parent-classfromfile.........ok t/parent-pmc...................Goto undefined subroutine &Config::non_bincompat_options at /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/Config_heavy.pl line 1240. # Looks like your test died before it could output anything. dubious Test returned status 255 (wstat 65280, 0xff00) t/parent-returns-false.........ok t/parent.......................ok Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/parent-pmc.t 255 65280 ?? ?? % ?? Failed 1/7 test scripts, 85.71% okay. 0/31 subtests failed, 100.00% okay. make: *** [test_dynamic] Error 255
Released with 0.239