Skip Menu |

This queue is for tickets about the Text-Todo CPAN distribution.

Report information
The Basics
Id: 101154
Status: resolved
Priority: 0/
Queue: Text-Todo
People
Owner: andrew [...] cpan.org
Requestors: svetoslav.chingov [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: v0.2.0
Fixed in: v0.2.1

History Show all quoted text
  Sat Dec 27 12:05:31 2014 svetoslav.chingov [...] gmail.com - Ticket created
Subject: Todo.pm fails on newer versions of Perl
This patch makes Todo.pm work on Perl version 5.18 and newer.
Subject: Todo.patch
--- Todo.pm 2014-12-27 18:53:01.053589408 +0200 +++ TodoNew.pm 2014-12-27 14:25:27.401541671 +0200 @@ -110,7 +110,7 @@ if ( my ( $pre, $post ) = $path_of{$ident}{$type} =~ /^(.*)$1(.*)\.txt$/ixms ) { - foreach my $f qw( todo done report ) { + foreach my $f (qw( todo done report )) { if ( !defined $path_of{$ident}{ $f . '_file' } ) { $path_of{$ident}{ $f . '_file' } = $pre . $f . $post . '.txt';
  Sat Dec 27 22:34:24 2014 andrew [...] afresh1.com - Correspondence added
Subject: Re: [rt.cpan.org #101154] Todo.pm fails on newer versions of Perl
Date: Sat, 27 Dec 2014 20:34:13 -0700
To: "svetoslav.chingov [...] gmail.com via RT" <bug-Text-Todo [...] rt.cpan.org>
From: Andrew Fresh <andrew [...] afresh1.com>
On Sat, Dec 27, 2014 at 12:05:32PM -0500, svetoslav.chingov@gmail.com via RT wrote: Show quoted text
> This patch makes Todo.pm work on Perl version 5.18 and newer.
Thank you for your report. I did have some other changes under way, long ago, so will have to figure out how to merge them and get a new release out. This patch looks good. Show quoted text
> --- Todo.pm 2014-12-27 18:53:01.053589408 +0200 > +++ TodoNew.pm 2014-12-27 14:25:27.401541671 +0200 > @@ -110,7 +110,7 @@ > if ( my ( $pre, $post ) > = $path_of{$ident}{$type} =~ /^(.*)$1(.*)\.txt$/ixms ) > { > - foreach my $f qw( todo done report ) { > + foreach my $f (qw( todo done report )) { > if ( !defined $path_of{$ident}{ $f . '_file' } ) { > $path_of{$ident}{ $f . '_file' } > = $pre . $f . $post . '.txt';
-- andrew - http://afresh1.com A printer consists of three main parts: the case, the jammed paper tray and the blinking red light.
  Sat Dec 27 22:34:24 2014 The RT System itself - Status changed from 'new' to 'open'
  Sat Dec 27 23:36:54 2014 andrew [...] cpan.org - Ticket deleted
  Sat Dec 27 23:36:59 2014 andrew [...] cpan.org - Status changed from 'deleted' to 'open'
  Sat Dec 27 23:37:01 2014 andrew [...] cpan.org - Ticket deleted
  Sat Dec 27 23:37:33 2014 andrew [...] cpan.org - Taken
  Sat Dec 27 23:37:37 2014 andrew [...] cpan.org - Status changed from 'deleted' to 'open'
  Sun Dec 28 01:54:50 2014 andrew [...] cpan.org - Correspondence added
I decided to create a branch and release 0.2.1 to resolve this. Happy to hear someone is using this.
  Sun Dec 28 01:54:55 2014 andrew [...] cpan.org - Status changed from 'open' to 'resolved'
  Sun Dec 28 01:54:56 2014 andrew [...] cpan.org - Fixed in v0.2.1 added
  Sun Dec 28 02:26:09 2014 ether [...] cpan.org - Ticket deleted
  Sun Dec 28 02:26:15 2014 ether [...] cpan.org - Status changed from 'deleted' to 'open'
  Sun Dec 28 02:26:22 2014 ether [...] cpan.org - Ticket deleted
  Sun Dec 28 02:26:34 2014 ether [...] cpan.org - Status changed from 'deleted' to 'open'
  Sun Dec 28 02:26:46 2014 ether [...] cpan.org - Status changed from 'open' to 'resolved'