Skip Menu |

This queue is for tickets about the XML-Parser CPAN distribution.

Report information
The Basics
Id: 101129
Status: resolved
Priority: 0/
Queue: XML-Parser

People
Owner: Nobody in particular
Requestors: marius [...] ieval.ro
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
0001-Add-a-failing-test-that-parses-using-Style-Stream-wh.patch
0002-Localize-_-where-needed-in-Style-Stream.patch
signature.asc



Subject: ::Style::Stream should localize $_
From XML::Parser::Style::Stream: sub doText { no strict 'refs'; my $expat = shift; $_ = $expat->{Text}; If $_ is read only when this function is called, the function will die with 'Modification of a read-only value attempted'. The fix is to localize $_ here (and everywhere else it is used like this). I can write a failing test case if it helps. I could also try to write a patch if needed.
Show quoted text
> I can write a failing test case if it helps. I could also try to write > a patch if needed.
That would help speed things along. https://github.com/toddr/XML-Parser
Subject: Re: [rt.cpan.org #101129] ::Style::Stream should localize $_
Date: Mon, 12 Jan 2015 09:53:11 +0200
To: "Todd Rinaldo via RT" <bug-XML-Parser [...] rt.cpan.org>
From: Marius Gavrilescu <marius [...] ieval.ro>
"Todd Rinaldo via RT" <bug-XML-Parser@rt.cpan.org> writes: Show quoted text
>> I can write a failing test case if it helps. I could also try to write >> a patch if needed.
> > That would help speed things along.
Here are two patches. The first adds a test case that fails with the current code. The second fixes the bug by localizing $_ in the subs that use it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

-- Marius Gavrilescu
Download signature.asc
application/pgp-signature 818b

Message body not shown because it is not plain text.

Ticket migrated to github as https://github.com/toddr/XML-Parser/issues/72