Bug #101086 for Eval-WithLexicals: Test failure with perl 5.21.7

Mon Dec 22 14:52:32 2014 SREZIC [...] cpan.org - Ticket created

Subject:

Test failure with perl 5.21.7

The test suite passes with perl 5.21.6, but fails with 5.21.7: PERL_DL_NONLAZY=1 "/opt/perl-5.21.7/bin/perl5.21.7" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/hints.t ... ok # Failed test 'Lexical stored ok' # at t/simple.t line 13. # Structures begin differing at: # $got->{$x} = Does not exist # $expected->{$x} = SCALAR(0x277f7d8) Global symbol "$x" requires explicit package name (did you forget to declare "my $x"?) at (eval) line 1. BEGIN not safe after errors--compilation aborted at (eval) line 3. # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 2. t/simple.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests

Mon Dec 22 17:40:38 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Mon Dec 22 14:52:32 2014, SREZIC wrote: Show quoted text

> The test suite passes with perl 5.21.6, but fails with 5.21.7: > > PERL_DL_NONLAZY=1 "/opt/perl-5.21.7/bin/perl5.21.7" "- > MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" > t/*.t > t/hints.t ... ok > > # Failed test 'Lexical stored ok' > # at t/simple.t line 13. > # Structures begin differing at: > # $got->{$x} = Does not exist > # $expected->{$x} = SCALAR(0x277f7d8) > Global symbol "$x" requires explicit package name (did you forget to > declare "my $x"?) at (eval) line 1. > BEGIN not safe after errors--compilation aborted at (eval) line 3. > # Tests were run but no plan was declared and done_testing() was not > seen. > # Looks like your test exited with 255 just after 2. > t/simple.t .. > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 1/2 subtests

Patch.

Subject:

open_FsI5DW6O.txt

diff -rup Eval-WithLexicals-1.003001-fdwIjF-orig/lib/Eval/WithLexicals.pm Eval-WithLexicals-1.003001-fdwIjF/lib/Eval/WithLexicals.pm --- Eval-WithLexicals-1.003001-fdwIjF-orig/lib/Eval/WithLexicals.pm 2014-12-22 14:35:47.000000000 -0800 +++ Eval-WithLexicals-1.003001-fdwIjF/lib/Eval/WithLexicals.pm 2014-12-22 14:38:45.000000000 -0800 @@ -131,7 +131,7 @@ sub _eval_do { sub capture_list { my $pad_capture = \&Eval::WithLexicals::Cage::pad_capture; - my @names = grep $_ ne '&', map $_->PV, grep $_->isa('B::PV'), + my @names = grep defined && $_ ne '&', map $_->PV, grep $_->can('PV'), svref_2object($pad_capture)->OUTSIDE->PADLIST->ARRAYelt(0)->ARRAY; $Eval::WithLexicals::current_code .= '+{ '.join(', ', map "'$_' => \\$_", @names).' };'

Mon Dec 22 17:40:39 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Dec 22 19:11:06 2014 ether [...] cpan.org - Taken

Mon Dec 22 19:12:32 2014 ether [...] cpan.org - Correspondence added

Thanks, released as 1.003002!

Mon Dec 22 19:12:34 2014 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jan 15 19:40:29 2015 ether [...] cpan.org - Fixed in 1.003002 added