Skip Menu |

This queue is for tickets about the Sys-Run-Safer CPAN distribution.

Report information
The Basics
Id: 101074
Status: resolved
Priority: 0/
Queue: Sys-Run-Safer

People
Owner: PERLANCAR [...] cpan.org
Requestors: RSAVAGE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.02
Fixed in: (no value)



Subject: Doc patches
Sounds like a good idea for a module. I would like to see some extras in the docs: 1) See Also to include Capture::Tiny 2) Comparisons with other modules. E.g. Advantages, disadvantages, in a tabular format 3) In one place the 3rd param is opts, and later it's progs. I guess that's a typo.
On Sun Dec 21 16:41:52 2014, RSAVAGE wrote: Show quoted text
> Sounds like a good idea for a module. > > I would like to see some extras in the docs: > > 1) See Also to include Capture::Tiny > > 2) Comparisons with other modules. E.g. Advantages, disadvantages, in > a tabular format > > 3) In one place the 3rd param is opts, and later it's progs. I guess > that's a typo.
Hi Ron, Ah, judging from the subject I thought *you* are the one providing patches :) For 1) and 2) I'm going to include only modules which are related to fixing/improving on the interface of system(), like IPC::System::Simple. There are loads of other modules providing extra functionality that system() doesn't provide, like capturing output (Capture::Tiny, IPC::Run, IPC::Cmd), timeouts, and so on. These will not be included because the scope is too wide. Except Proc::Govern, which I mention specifically because I'm planning to adopt the interface of Sys::Run::Safer in that module. As for 3), I'm not seeing 'progs' anywhere in the module, blog post, or git history. Regards,
Subject: Re: [rt.cpan.org #101074] Doc patches
Date: Wed, 24 Dec 2014 08:08:56 +1100
To: bug-Sys-Run-Safer [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi See below. On 23/12/14 23:53, Perl Ancar via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=101074 > > > On Sun Dec 21 16:41:52 2014, RSAVAGE wrote:
>> Sounds like a good idea for a module. >> >> I would like to see some extras in the docs: >> >> 1) See Also to include Capture::Tiny >> >> 2) Comparisons with other modules. E.g. Advantages, disadvantages, in >> a tabular format >> >> 3) In one place the 3rd param is opts, and later it's progs. I guess >> that's a typo.
> > Hi Ron, > > Ah, judging from the subject I thought *you* are the one providing patches :) > > For 1) and 2) I'm going to include only modules which are related to fixing/improving on the interface of system(), like IPC::System::Simple. There are loads of other modules providing extra functionality that system() doesn't provide, like capturing output (Capture::Tiny, IPC::Run, IPC::Cmd), timeouts, and so on. These will not be included because the scope is too wide. Except Proc::Govern, which I mention specifically because I'm planning to adopt the interface of Sys::Run::Safer in that module.
Sure. It's a complex topic. Show quoted text
> As for 3), I'm not seeing 'progs' anywhere in the module, blog post, or git history.
Can't see the problem now. Perhaps it's just that the order of option keys in the synopsis is different than as below... But under Functions: " Arguments ('*' denotes required arguments): args => array opts => array prog* => str " Should 'prog*' read 'progs*'? -- Ron Savage - savage.net.au
On Tue Dec 23 16:05:52 2014, ron@savage.net.au wrote: Show quoted text
> prog* => str > " > > Should 'prog*' read 'progs*'?
Nope, don't think so. The argument name is prog (singular).
Subject: Re: [rt.cpan.org #101074] Doc patches
Date: Wed, 24 Dec 2014 21:51:55 +1100
To: bug-Sys-Run-Safer [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi Ah, yes, understood, finally. On 24/12/14 18:59, Perl Ancar via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=101074 > > > On Tue Dec 23 16:05:52 2014, ron@savage.net.au wrote:
>> prog* => str >> " >> >> Should 'prog*' read 'progs*'?
> > Nope, don't think so. The argument name is prog (singular). > >
-- Ron Savage - savage.net.au
On Wed Dec 24 05:49:08 2014, ron@savage.net.au wrote: Show quoted text
> Hi > > Ah, yes, understood, finally. > > On 24/12/14 18:59, Perl Ancar via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=101074 > > > > > On Tue Dec 23 16:05:52 2014, ron@savage.net.au wrote:
> >> prog* => str > >> " > >> > >> Should 'prog*' read 'progs*'?
> > > > Nope, don't think so. The argument name is prog (singular). > > > >
>
Closing ticket.