Bug #101045 for JSON-SL: t/06-utf8.t fails with perl 5.21.7

Sat Dec 20 16:42:00 2014 SREZIC [...] cpan.org - Ticket created

CC:	ANDK [...] cpan.org
Subject:	t/06-utf8.t fails with perl 5.21.7

The 06-utf8.t test fails with perl 5.21.7: # Failed test 'have utf8 key' # at t/06-utf8.t line 19. # Looks like you failed 1 test of 3. t/06-utf8.t ............. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests This worked with perl 5.21.6, so it could be a perl regression or an intentional change. Regards, Slaven

Sat Dec 20 20:09:30 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sat Dec 20 16:42:00 2014, SREZIC wrote: Show quoted text

> The 06-utf8.t test fails with perl 5.21.7: > > # Failed test 'have utf8 key' > # at t/06-utf8.t line 19. > # Looks like you failed 1 test of 3. > t/06-utf8.t ............. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/3 subtests > > This worked with perl 5.21.6, so it could be a perl regression or an > intentional change.

The test does exists $res->{blahblahblah} which returns false, but a dump of the hash shows that the key does exist. So somehow the internals of the hash are getting out of synch. (A bisect would help.)

Sat Dec 20 20:09:31 2014 The RT System itself - Status changed from 'new' to 'open'

Sat Dec 20 21:12:49 2014 MNUNBERG [...] cpan.org - Correspondence added

Can you all check if this branch works or not? There is a known issue with UTF8, and I may be at fault here: https://github.com/mnunberg/perl-JSON-SL/tree/utf8_fix On Sat Dec 20 13:42:00 2014, SREZIC wrote: Show quoted text

> The 06-utf8.t test fails with perl 5.21.7: > > # Failed test 'have utf8 key' > # at t/06-utf8.t line 19. > # Looks like you failed 1 test of 3. > t/06-utf8.t ............. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/3 subtests > > This worked with perl 5.21.6, so it could be a perl regression or an > intentional change. > > Regards, > Slaven

Sat Dec 20 21:14:34 2014 MNUNBERG [...] cpan.org - Correspondence added

Specifically, this commit here: https://github.com/mnunberg/perl-JSON-SL/commit/b6b1bbcc32d71de4fe0ba4af9d87a7f3f96ebe29 On Sat Dec 20 18:12:49 2014, MNUNBERG wrote: Show quoted text

> Can you all check if this branch works or not? There is a known issue > with UTF8, and I may be at fault here: > > https://github.com/mnunberg/perl-JSON-SL/tree/utf8_fix > > On Sat Dec 20 13:42:00 2014, SREZIC wrote:

> > The 06-utf8.t test fails with perl 5.21.7: > > > > # Failed test 'have utf8 key' > > # at t/06-utf8.t line 19. > > # Looks like you failed 1 test of 3. > > t/06-utf8.t ............. > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/3 subtests > > > > This worked with perl 5.21.6, so it could be a perl regression or an > > intentional change. > > > > Regards, > > Slaven

Sat Dec 20 21:50:32 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sat Dec 20 21:12:49 2014, MNUNBERG wrote: Show quoted text

> Can you all check if this branch works or not? There is a known issue > with UTF8, and I may be at fault here: > > https://github.com/mnunberg/perl-JSON-SL/tree/utf8_fix

I tried that and still get the failure with 5.21.7. I suspect we have a perl bug here. Your utf8 fix ensures that the keys get stored correctly to begin with. But I’m now getting a hash for which ‘keys’ does indeed return the string that ‘exists’ claims does not exist!

Sat Dec 20 21:55:27 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sat Dec 20 21:50:32 2014, SPROUT wrote: Show quoted text

> On Sat Dec 20 21:12:49 2014, MNUNBERG wrote:

> > Can you all check if this branch works or not? There is a known issue > > with UTF8, and I may be at fault here: > > > > https://github.com/mnunberg/perl-JSON-SL/tree/utf8_fix

> > I tried that and still get the failure with 5.21.7. I suspect we have > a perl bug here. > > Your utf8 fix ensures that the keys get stored correctly to begin > with. But I’m now getting a hash for which ‘keys’ does indeed return > the string that ‘exists’ claims does not exist!

Never mind that. I was using the wrong branch. Your utf8_fix branch *does* fix the bug!

Tue Feb 24 12:30:43 2015 MNUNBERG [...] cpan.org - Correspondence added

Assuming this is fixed. On Sat Dec 20 18:55:27 2014, SPROUT wrote: Show quoted text

> On Sat Dec 20 21:50:32 2014, SPROUT wrote:

> > On Sat Dec 20 21:12:49 2014, MNUNBERG wrote:

> > > Can you all check if this branch works or not? There is a known > > > issue > > > with UTF8, and I may be at fault here: > > > > > > https://github.com/mnunberg/perl-JSON-SL/tree/utf8_fix

> > > > I tried that and still get the failure with 5.21.7. I suspect we > > have > > a perl bug here. > > > > Your utf8 fix ensures that the keys get stored correctly to begin > > with. But I’m now getting a hash for which ‘keys’ does indeed return > > the string that ‘exists’ claims does not exist!

> > Never mind that. I was using the wrong branch. Your utf8_fix branch > *does* fix the bug!

Tue Feb 24 12:30:52 2015 MNUNBERG [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Feb 24 12:30:53 2015 MNUNBERG [...] cpan.org - Fixed in 1.0.4 added

Tue Feb 24 13:21:21 2015 MNUNBERG [...] cpan.org - Correspondence added

Reopened because 1.0.4 is already released and doesn't contain the fix.

Tue Feb 24 13:21:27 2015 MNUNBERG [...] cpan.org - Status changed from 'resolved' to 'patched'