On 2015-01-03 10:01:29, MIROD wrote:
Show quoted text> On Sun Dec 21 09:23:07 2014, SREZIC wrote:
> > On 2014-12-21 05:59:11, andreas.koenig.7os6VVqR@franz.ak.mind.de
> > wrote:
> > > It's dependent on XML::Parser. Downgrading to
> > > TODDR/XML-Parser-2.41.tar.gz makes the tests pass again, as I just
> > > verified for a v5.21.6 and
> >
> > Confirmed, it fails for me too, with a newer XML::Parser and older
> > perls.
>
> A patch to XML::Parser to improve error messages interferes with the
> way XML::Twig uses die inside a handler to trigger an exception that's
> caught after parsing.
>
> I am investigating the patch which looks wrong to me.
>
The problematic change in XML::Parser was reverted and there are no problems if XML-Parser-2.44 is used. However, it could be that there are XML-Parser-2.43 installations out there in the wild, so maybe it's a good idea to force a better version in XML::Twig's Makefile.PL (e.g. using something like [untested]
$min_xml_parser_version = 0;
if (eval { require XML::Parser; 1 }) {
if ($XML::Parser::VERSION = 2.43) {
$min_xml_parser_version = 2.44;
}
}
...
PREREQ_PM => { ... 'XML::Parser' => $min_xml_parser_version ... }
A new XML-Twig release would also have the side-effect of "cleaning" up the CPAN Testers reports. Currently
http://matrix.cpantesters.org/?dist=XML-Twig+3.48 shows quite a lot of red spots...
