Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Locale-CLDR CPAN distribution.

Report information
The Basics
Id: 101040
Status: resolved
Priority: 0/
Queue: Locale-CLDR

People
Owner: JGNI [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: v0.26.3
Fixed in: v0.26.6



Subject: centimetre vs. centimeter
There are a number of test failures where units were expected in American English, but results came in British English. See http://matrix.cpantesters.org/?dist=Locale-CLDR for a fail/pass overview. v0.26.4 is also affected.
On Sat Dec 20 14:20:43 2014, SREZIC wrote: Show quoted text
> There are a number of test failures where units were expected in > American English, but results came in British English. See > http://matrix.cpantesters.org/?dist=Locale-CLDR for a fail/pass > overview. v0.26.4 is also affected.
I have been scratching my head over this for some time now. The Core package Locale::CLDR only has data for US English. To get the British English you need the Locale::CLDR::Locales::En package. I recently split out the core data into multiple packages. I think some of the test platforms have the old data lying around. I think the next release needs some diagnostics in the base package tests to see what language packages are on the system
Think I've found the problem. The test file was using en_GB as the locale. As this was not supposed to exist in the base package it should have fallen back to en, which contains the US spelling. I have fixed the locale in the test sweet and will set up a new version to test in the next 24 hours or so
On 2014-12-26 18:25:21, JGNI wrote: Show quoted text
> Think I've found the problem. The test file was using en_GB as the > locale. As this was not supposed to exist in the base package it > should have fallen back to en, which contains the US spelling. > > I have fixed the locale in the test sweet and will set up a new > version to test in the next 24 hours or so
The v0.26.6-TRIAL looks better, the centimeter vs. centimetre mismatch does not happen anymore. But still there are mismatches in other checks: # Failed test 'All languages' # at t/16-Names.t line 638. # Structures begin differing at: # $got->{en_US@alt=short} = 'US English' # $expected->{en_US@alt=short} = 'U.S. English' # Failed test 'All Territories' # at t/16-Names.t line 1127. # Structures begin differing at: # $got->{KN} = 'Saint Kitts and Nevis' # $expected->{KN} = 'St. Kitts & Nevis' # Failed test 'Key name from string' # at t/16-Names.t line 1131. # got: 'Case-Sensitive Sorting' # expected: 'Case Sensitive Sorting' # Looks like you failed 3 tests of 20. t/16-Names.t ................ -- # Failed test 'All languages' # at t/16-Names.t line 638. # Structures begin differing at: # $got->{wal} = 'Walamo' # $expected->{wal} = 'Wolaytta' # Failed test 'All Territories' # at t/16-Names.t line 1127. # Structures begin differing at: # $got->{TC} = 'Turks and Caicos Islands' # $expected->{TC} = 'Turks & Caicos Islands' -- # Failed test 'All Territories' # at t/16-Names.t line 1127. # Structures begin differing at: # $got->{SH} = 'Saint Helena' # $expected->{SH} = 'St. Helena' --
Show quoted text
> The v0.26.6-TRIAL looks better, the centimeter vs. centimetre mismatch > does not happen anymore. But still there are mismatches in other > checks: >
Same problem. Different test file. I've uploaded a new trial version which should solve this
On 2014-12-27 17:42:07, JGNI wrote: Show quoted text
> > The v0.26.6-TRIAL looks better, the centimeter vs. centimetre > > mismatch > > does not happen anymore. But still there are mismatches in other > > checks: > >
> > Same problem. Different test file. I've uploaded a new trial version > which should solve this
With Locale-CLDR-v0.26.6-TRIAL-2: # Failed test 'Locale name from current locale' # at t/16-Names.t line 16. # got: 'American English' # expected: 'British English' # Failed test 'Territory name from current locale' # at t/16-Names.t line 818. # got: 'United States' # expected: 'United Kingdom' # Looks like you failed 2 tests of 20. t/16-Names.t ................ Dubious, test returned 2 (wstat 512, 0x200) Failed 2/20 subtests t/17-DateTime.t ............. ok # Failed test 'Format currency with default currency' # at t/19-Currency.t line 16. # got: 'US$12,345,678.00' # expected: '£12,345,678.00' # Looks like you failed 1 test of 2. t/19-Currency.t .............
Thanks for helping. The next update should be in 5 hours or so. I'm flying blind for some of this as the tests all pass on my box. John
On 2014-12-28 09:49:22, JGNI wrote: Show quoted text
> Thanks for helping. The next update should be in 5 hours or so. > > I'm flying blind for some of this as the tests all pass on my box. >
BTW, it seems that using "...-TRIAL-n..." as a distribution name is problematic. These versions are not listed on the metacpan page at all, and on search.cpan.org it looks like it's indexed as a different distribution as Locale-CLDR, see here: http://search.cpan.org/~jgni/Locale-CLDR-v0.26.6-TRIAL-2/ Maybe it should be "...-TRIALn..." instead, without a dash after "TRIAL"?
On Sun Dec 28 10:52:25 2014, SREZIC wrote: Show quoted text
> On 2014-12-28 09:49:22, JGNI wrote:
> > Thanks for helping. The next update should be in 5 hours or so. > > > > I'm flying blind for some of this as the tests all pass on my box. > >
> > BTW, it seems that using "...-TRIAL-n..." as a distribution name is > problematic. These versions are not listed on the metacpan page at > all, and on search.cpan.org it looks like it's indexed as a different > distribution as Locale-CLDR, see here: > http://search.cpan.org/~jgni/Locale-CLDR-v0.26.6-TRIAL-2/ > > Maybe it should be "...-TRIALn..." instead, without a dash after > "TRIAL"?
That's deliberate. The distribution is marked internally as unstable. Build.PL sees that and appends the TRIAL when I create the distribution. As it's marked as unstable the PAUSE indexer does not index the files. This allows you to upload different versions of the Distribution so that the CPAN testers can test it with out it being marked as the current version on CPAN. I should have really have done that with all the distributions until I got the split distributions working. Well you live and learn John
On Sun Dec 28 10:52:25 2014, SREZIC wrote: Show quoted text
> On 2014-12-28 09:49:22, JGNI wrote:
> > Thanks for helping. The next update should be in 5 hours or so. > > > > I'm flying blind for some of this as the tests all pass on my box. > >
> > BTW, it seems that using "...-TRIAL-n..." as a distribution name is > problematic. These versions are not listed on the metacpan page at > all, and on search.cpan.org it looks like it's indexed as a different > distribution as Locale-CLDR, see here: > http://search.cpan.org/~jgni/Locale-CLDR-v0.26.6-TRIAL-2/ > > Maybe it should be "...-TRIALn..." instead, without a dash after > "TRIAL"?
Humm perhaps I'm wrong. will try the next upload with out the - as suggested
On 2014-12-28 11:02:59, JGNI wrote: Show quoted text
> On Sun Dec 28 10:52:25 2014, SREZIC wrote:
> > On 2014-12-28 09:49:22, JGNI wrote:
> > > Thanks for helping. The next update should be in 5 hours or so. > > > > > > I'm flying blind for some of this as the tests all pass on my box. > > >
> > > > BTW, it seems that using "...-TRIAL-n..." as a distribution name is > > problematic. These versions are not listed on the metacpan page at > > all, and on search.cpan.org it looks like it's indexed as a different > > distribution as Locale-CLDR, see here: > > http://search.cpan.org/~jgni/Locale-CLDR-v0.26.6-TRIAL-2/ > > > > Maybe it should be "...-TRIALn..." instead, without a dash after > > "TRIAL"?
> > That's deliberate. The distribution is marked internally as unstable. > Build.PL sees that and appends the TRIAL when I create the > distribution. As it's marked as unstable the PAUSE indexer does not > index the files. This allows you to upload different versions of the > Distribution so that the CPAN testers can test it with out it being > marked as the current version on CPAN.
Well, the problem is that the versions with "...-TRIAL-n-..." don't show up in the cpantesters listings. See here: http://matrix.cpantesters.org/?dist=Locale-CLDR It seems that using "...-TRIAL.n..." is fine (dot instead of a dash), or using a letter instead of a digit for the n. Also, CPAN::DistnameInfo cannot cope with such a distname correctly. Note the wrong "maturity" status ("released" instead of "developer"), and the wrong dist field: $ perl -MData::Dumper -MCPAN::DistnameInfo -e 'warn Dumper(CPAN::DistnameInfo->new("Locale-CLDR-v0.26.6-TRIAL-2.tar.gz"))' $VAR1 = bless( { 'extension' => 'tar.gz', 'filename' => 'Locale-CLDR-v0.26.6-TRIAL-2.tar.gz', 'version' => 'TRIAL2', 'distvname' => 'Locale-CLDR-v0.26.6-TRIAL-2', 'dist' => 'Locale-CLDR-v0.26.6', 'maturity' => 'released', 'pathname' => 'Locale-CLDR-v0.26.6-TRIAL-2.tar.gz' }, 'CPAN::DistnameInfo' ); This looks right, dist is "Locale-CLDR" and "maturity" is correct: $ perl -MData::Dumper -MCPAN::DistnameInfo -e 'warn Dumper(CPAN::DistnameInfo->new("Locale-CLDR-v0.26.6-TRIAL2.tar.gz"))' $VAR1 = bless( { 'extension' => 'tar.gz', 'filename' => 'Locale-CLDR-v0.26.6-TRIAL2.tar.gz', 'version' => 'v0.26.6-TRIAL2', 'distvname' => 'Locale-CLDR-v0.26.6-TRIAL2', 'dist' => 'Locale-CLDR', 'maturity' => 'developer', 'pathname' => 'Locale-CLDR-v0.26.6-TRIAL2.tar.gz' }, 'CPAN::DistnameInfo' ); Show quoted text
> > I should have really have done that with all the distributions until I > got the split distributions working. > > Well you live and learn > > John
On Sun Dec 28 11:09:11 2014, SREZIC wrote: Show quoted text
> On 2014-12-28 11:02:59, JGNI wrote:
> > On Sun Dec 28 10:52:25 2014, SREZIC wrote:
> > > On 2014-12-28 09:49:22, JGNI wrote:
> > > > Thanks for helping. The next update should be in 5 hours or so. > > > > > > > > I'm flying blind for some of this as the tests all pass on my > > > > box. > > > >
> > > > > > BTW, it seems that using "...-TRIAL-n..." as a distribution name is > > > problematic. These versions are not listed on the metacpan page at > > > all, and on search.cpan.org it looks like it's indexed as a > > > different > > > distribution as Locale-CLDR, see here: > > > http://search.cpan.org/~jgni/Locale-CLDR-v0.26.6-TRIAL-2/ > > > > > > Maybe it should be "...-TRIALn..." instead, without a dash after > > > "TRIAL"?
> > > > That's deliberate. The distribution is marked internally as unstable. > > Build.PL sees that and appends the TRIAL when I create the > > distribution. As it's marked as unstable the PAUSE indexer does not > > index the files. This allows you to upload different versions of the > > Distribution so that the CPAN testers can test it with out it being > > marked as the current version on CPAN.
> > Well, the problem is that the versions with "...-TRIAL-n-..." don't > show up in the cpantesters listings. See here: > http://matrix.cpantesters.org/?dist=Locale-CLDR > It seems that using "...-TRIAL.n..." is fine (dot instead of a dash), > or using a letter instead of a digit for the n. > > Also, CPAN::DistnameInfo cannot cope with such a distname correctly. > Note the wrong "maturity" status ("released" instead of "developer"), > and the wrong dist field: > > $ perl -MData::Dumper -MCPAN::DistnameInfo -e 'warn > Dumper(CPAN::DistnameInfo->new("Locale-CLDR-v0.26.6-TRIAL-2.tar.gz"))' > $VAR1 = bless( { > 'extension' => 'tar.gz', > 'filename' => 'Locale-CLDR-v0.26.6-TRIAL-2.tar.gz', > 'version' => 'TRIAL2', > 'distvname' => 'Locale-CLDR-v0.26.6-TRIAL-2', > 'dist' => 'Locale-CLDR-v0.26.6', > 'maturity' => 'released', > 'pathname' => 'Locale-CLDR-v0.26.6-TRIAL-2.tar.gz' > }, 'CPAN::DistnameInfo' ); > > This looks right, dist is "Locale-CLDR" and "maturity" is correct: > > $ perl -MData::Dumper -MCPAN::DistnameInfo -e 'warn > Dumper(CPAN::DistnameInfo->new("Locale-CLDR-v0.26.6-TRIAL2.tar.gz"))' > $VAR1 = bless( { > 'extension' => 'tar.gz', > 'filename' => 'Locale-CLDR-v0.26.6-TRIAL2.tar.gz', > 'version' => 'v0.26.6-TRIAL2', > 'distvname' => 'Locale-CLDR-v0.26.6-TRIAL2', > 'dist' => 'Locale-CLDR', > 'maturity' => 'developer', > 'pathname' => 'Locale-CLDR-v0.26.6-TRIAL2.tar.gz' > }, 'CPAN::DistnameInfo' ); > >
> > > > I should have really have done that with all the distributions until > > I > > got the split distributions working. > > > > Well you live and learn > > > > John
OK I'll rename the -2 version to .2 and see what happens
On 2014-12-28 11:20:12, JGNI wrote: Show quoted text
> On Sun Dec 28 11:09:11 2014, SREZIC wrote:
> > On 2014-12-28 11:02:59, JGNI wrote:
> > > On Sun Dec 28 10:52:25 2014, SREZIC wrote:
> > > > On 2014-12-28 09:49:22, JGNI wrote:
> > > > > Thanks for helping. The next update should be in 5 hours or so. > > > > > > > > > > I'm flying blind for some of this as the tests all pass on my > > > > > box. > > > > >
> > > > > > > > BTW, it seems that using "...-TRIAL-n..." as a distribution name is > > > > problematic. These versions are not listed on the metacpan page at > > > > all, and on search.cpan.org it looks like it's indexed as a > > > > different > > > > distribution as Locale-CLDR, see here: > > > > http://search.cpan.org/~jgni/Locale-CLDR-v0.26.6-TRIAL-2/ > > > > > > > > Maybe it should be "...-TRIALn..." instead, without a dash after > > > > "TRIAL"?
> > > > > > That's deliberate. The distribution is marked internally as unstable. > > > Build.PL sees that and appends the TRIAL when I create the > > > distribution. As it's marked as unstable the PAUSE indexer does not > > > index the files. This allows you to upload different versions of the > > > Distribution so that the CPAN testers can test it with out it being > > > marked as the current version on CPAN.
> > > > Well, the problem is that the versions with "...-TRIAL-n-..." don't > > show up in the cpantesters listings. See here: > > http://matrix.cpantesters.org/?dist=Locale-CLDR > > It seems that using "...-TRIAL.n..." is fine (dot instead of a dash), > > or using a letter instead of a digit for the n. > > > > Also, CPAN::DistnameInfo cannot cope with such a distname correctly. > > Note the wrong "maturity" status ("released" instead of "developer"), > > and the wrong dist field: > > > > $ perl -MData::Dumper -MCPAN::DistnameInfo -e 'warn > > Dumper(CPAN::DistnameInfo->new("Locale-CLDR-v0.26.6-TRIAL-2.tar.gz"))' > > $VAR1 = bless( { > > 'extension' => 'tar.gz', > > 'filename' => 'Locale-CLDR-v0.26.6-TRIAL-2.tar.gz', > > 'version' => 'TRIAL2', > > 'distvname' => 'Locale-CLDR-v0.26.6-TRIAL-2', > > 'dist' => 'Locale-CLDR-v0.26.6', > > 'maturity' => 'released', > > 'pathname' => 'Locale-CLDR-v0.26.6-TRIAL-2.tar.gz' > > }, 'CPAN::DistnameInfo' ); > > > > This looks right, dist is "Locale-CLDR" and "maturity" is correct: > > > > $ perl -MData::Dumper -MCPAN::DistnameInfo -e 'warn > > Dumper(CPAN::DistnameInfo->new("Locale-CLDR-v0.26.6-TRIAL2.tar.gz"))' > > $VAR1 = bless( { > > 'extension' => 'tar.gz', > > 'filename' => 'Locale-CLDR-v0.26.6-TRIAL2.tar.gz', > > 'version' => 'v0.26.6-TRIAL2', > > 'distvname' => 'Locale-CLDR-v0.26.6-TRIAL2', > > 'dist' => 'Locale-CLDR', > > 'maturity' => 'developer', > > 'pathname' => 'Locale-CLDR-v0.26.6-TRIAL2.tar.gz' > > }, 'CPAN::DistnameInfo' ); > > > >
> > > > > > I should have really have done that with all the distributions until > > > I > > > got the split distributions working. > > > > > > Well you live and learn > > > > > > John
> > OK I'll rename the -2 version to .2 and see what happens
This version is now correctly listed in the metacpan, search.cpan.org and cpantesters listings. But we have still fails, see http://217.199.168.174/cgi-bin/cpantestersmatrix.pl?dist=Locale-CLDR t/16-Names.t and t/19-Currency.t still fail because of UK vs. US mismatches.
Show quoted text
> > But we have still fails, see > http://217.199.168.174/cgi-bin/cpantestersmatrix.pl?dist=Locale-CLDR > t/16-Names.t and t/19-Currency.t still fail because of UK vs. US > mismatches.
I'm building a new version which should fix those. Unfortunately the build process takes about 4 hours as it builds the distributions for all the languages. I reckon it's got another 2 hours to run
TRIAL3 now passes. I'm rebuilding it as a production release and will release it at version 0.26.6
Thanks for your help.