Bug #101011 for Net-MAC-Vendor: DOS line-breaks not handled properly

Fri Dec 19 09:23:40 2014 mschmidt [...] ocedo.com - Ticket created

Subject:	DOS line-breaks not handled properly
Date:	Fri, 19 Dec 2014 15:23:27 +0100
To:	bug-Net-MAC-Vendor [...] rt.cpan.org
From:	Mario Schmidt <mschmidt [...] ocedo.com>

Hello maintainer, I think there's an issue with Net::MAC::Vendor v1.23 regarding line-breaks. IEEE seems to have changed the file format of oui.txt to contain DOS line-breaks (\r\n) which the module does not handle and results in $Cached being empty. Thanks for your hard work! Mario Schmidt

Fri Dec 26 19:57:23 2014 bdfoy [...] cpan.org - Correspondence added

I checked the oui.txt file and only see unix line endings. Can you show me what you were doing? Did you download the file yourself? Can you look at http://www.ieee.org/netstorage/standards/oui.txt directly and tell me what you see?

Fri Dec 26 19:57:24 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 08 03:18:21 2015 mschmidt [...] ocedo.com - Correspondence added

Subject:	Re: [rt.cpan.org #101011] DOS line-breaks not handled properly
Date:	Thu, 08 Jan 2015 09:18:05 +0100
To:	bug-Net-MAC-Vendor [...] rt.cpan.org
From:	Mario Schmidt <mschmidt [...] ocedo.com>

Hi, sorry for the delay, back to work now! $ wget http://www.ieee.org/netstorage/standards/oui.txt --2015-01-08 08:52:54-- http://www.ieee.org/netstorage/standards/oui.txt Resolving www.ieee.org (www.ieee.org)... 23.209.167.233 Connecting to www.ieee.org (www.ieee.org)|23.209.167.233|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 3534183 (3,4M) [text/plain] Saving to: ‘oui.txt’ 100%[==================================================================================================>] 3.534.183 2,74MB/s in 1,2s 2015-01-08 08:52:56 (2,74 MB/s) - ‘oui.txt’ saved [3534183/3534183] $ file oui.txt oui.txt: UTF-8 Unicode text, with CRLF line terminators So the oui.txt from the URL contains carriage return, line feed line-breaks. Net::MAC::Vendor does not handle these: perl -e "use Data::Dumper; use File::Spec; use Net::MAC::Vendor; Net::MAC::Vendor::load_cache('file://'.File::Spec->rel2abs('oui.txt')); print scalar keys \$Net::MAC::Vendor::Cached;" 0 Converting the oui.txt to Unix line-breaks makes it work: $ dos2unix oui.txt dos2unix: converting file oui.txt to Unix format ... $ perl -e "use Data::Dumper; use File::Spec; use Net::MAC::Vendor; Net::MAC::Vendor::load_cache('file://'.File::Spec->rel2abs('oui.txt')); print scalar keys \$Net::MAC::Vendor::Cached;" 20202 I've attached a trivial patch. Thanks for any feedback! On 27.12.2014 01:57, brian d foy via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=101011 > > > I checked the oui.txt file and only see unix line endings. Can you show me what you were doing? Did you download the file yourself? > > Can you look at http://www.ieee.org/netstorage/standards/oui.txt directly and tell me what you see? >

Message body is not shown because sender requested not to inline it.

Thu Jan 08 03:27:56 2015 mschmidt [...] ocedo.com - Correspondence added

Subject:	Re: [rt.cpan.org #101011] DOS line-breaks not handled properly
Date:	Thu, 08 Jan 2015 09:27:44 +0100
To:	bug-Net-MAC-Vendor [...] rt.cpan.org
From:	Mario Schmidt <mschmidt [...] ocedo.com>

A, before I forget it, letting the module handle the download also fails: $ perl -e "use Data::Dumper; use File::Spec; use Net::MAC::Vendor; Net::MAC::Vendor::load_cache(); print scalar keys \$Net::MAC::Vendor::Cached;" 0

Sun Jan 11 07:05:55 2015 bdfoy [...] cpan.org - Status changed from 'open' to 'patched'

Bug #101011 for Net-MAC-Vendor: DOS line-breaks not handled properly

Preferred bug tracker