Bug #100964 for Net-Amazon-Signature-V4: Patch to fix a few issues in Net-Amazon-Signature-V4

Wed Dec 17 07:53:27 2014 steven.hartland [...] multiplay.co.uk - Ticket created

Subject:	Patch to fix a few issues in Net-Amazon-Signature-V4
Date:	Wed, 17 Dec 2014 12:52:35 +0000
To:	bug-Net-Amazon-Signature-V4 [...] rt.cpan.org
From:	Steven Hartland <steven.hartland [...] multiplay.co.uk>

While trying to use this modules I came across a few issues so I've created the patch (attached) to fix these. The fixes are: * Remove dependency on perl 5.10 features. * Ensure a date is always present, using X-Amz-Date if present. * Remove spaces between Credential, SignedHeaders and Signature in the header as per spec. * Use \x0a line endings as per spec. Hopefully this can be incorporated in the next version. Regards Steve

Message body is not shown because sender requested not to inline it.

Fri Sep 11 08:50:40 2015 ilmari+cpan [...] ilmari.org - Correspondence added

Hi Tim, Any chance of getting this patch merged and released? Or, if you're not using the module any more, giving co-maint to someone who is? The X-Amz-Date issue is causing intermittent errors when using Paws, since it sets the Date and X-Amz-Date headers separately, and Amazon prefers the latter, while this module uses the former to sign (see https://github.com/pplu/aws-sdk-perl/pull/58). Thanks, Ilmari

Fri Sep 11 08:50:40 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 11 08:57:40 2015 tim [...] gurka.se - Correspondence added

CC:	Gonzalo Barco <gbarcouy [...] gmail.com>
Subject:	Re: [rt.cpan.org #100964] Patch to fix a few issues in Net-Amazon-Signature-V4
Date:	Fri, 11 Sep 2015 14:57:09 +0200
To:	bug-Net-Amazon-Signature-V4 [...] rt.cpan.org
From:	Tim Nordenfur <tim [...] gurka.se>

Hi Ilmari, Gonzalo Barco (GBARCO) has taken over development of Net::Amazon::Signature::V4. Cheers, Tim On Fri, Sep 11, 2015 at 2:50 PM, Dagfinn Ilmari Mannsaker via RT < bug-Net-Amazon-Signature-V4@rt.cpan.org> wrote: Show quoted text

> Queue: Net-Amazon-Signature-V4 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=100964 > > > Hi Tim, > > Any chance of getting this patch merged and released? Or, if you're not > using the module any more, giving co-maint to someone who is? > > The X-Amz-Date issue is causing intermittent errors when using Paws, since > it sets the Date and X-Amz-Date headers separately, and Amazon prefers the > latter, while this module uses the former to sign (see > https://github.com/pplu/aws-sdk-perl/pull/58). > > Thanks, > > Ilmari >

Thu Sep 24 18:42:38 2015 ether [...] cpan.org - Correspondence added

RT-Send-CC:

tim [...] gurka.se, gbarcouy [...] gmail.com

On 2015-09-11 05:57:40, tim@gurka.se wrote: Show quoted text

> Hi Ilmari, > > Gonzalo Barco (GBARCO) has taken over development of > Net::Amazon::Signature::V4.

Awesome! Is there a git repository available? Please let us know how we can help.

Wed Nov 23 12:22:48 2016 ether [...] cpan.org - Correspondence added

On 2015-09-24 15:42:38, ETHER wrote: Show quoted text

> On 2015-09-11 05:57:40, tim@gurka.se wrote:

> > Hi Ilmari, > > > > Gonzalo Barco (GBARCO) has taken over development of > > Net::Amazon::Signature::V4.

> > Awesome! > > Is there a git repository available? > > Please let us know how we can help.

Hi, over a year has passed. I'd still very much like to send you some patches for this distribution. I hope you are still alive! :)

Wed Nov 23 14:55:02 2016 DBOOK [...] cpan.org - Cc DBOOK added

Thu Mar 30 22:27:10 2017 DBOOK [...] cpan.org - Correspondence added

This patch has been applied in the testing release 0.15_01. Please test if it works for you. https://metacpan.org/release/DBOOK/Net-Amazon-Signature-V4-0.15_01

Fri Mar 31 07:08:31 2017 steven.hartland [...] multiplay.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #100964] Patch to fix a few issues in Net-Amazon-Signature-V4
Date:	Fri, 31 Mar 2017 12:08:12 +0100
To:	bug-Net-Amazon-Signature-V4 [...] rt.cpan.org
From:	Steven Hartland <steven.hartland [...] multiplay.co.uk>

Thank Dan, I've attached an additional patch we're also using here. This does the following: 1. Ensures the Host header is always present, as its required. 2. Sets the X-Amz-Content-Sha256 when we calculate the payload hash, as certain regions require it. 3. Always sets X-Amz-Date to workaround Amazon implementation not abiding by the spec and requiring X-Amz-Date in some regions. Regards Steve On 31/03/2017 03:27, Dan Book via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100964 > > > This patch has been applied in the testing release 0.15_01. Please test if it works for you. https://metacpan.org/release/DBOOK/Net-Amazon-Signature-V4-0.15_01

Message body is not shown because sender requested not to inline it.

Sat Apr 01 13:32:41 2017 DBOOK [...] cpan.org - Correspondence added

On Fri Mar 31 07:08:31 2017, steveh wrote: Show quoted text

> Thank Dan, I've attached an additional patch we're also using here. > > This does the following: > 1. Ensures the Host header is always present, as its required. > 2. Sets the X-Amz-Content-Sha256 when we calculate the payload hash, > as > certain regions require it. > 3. Always sets X-Amz-Date to workaround Amazon implementation not > abiding by the spec and requiring X-Amz-Date in some regions. > > Regards > Steve

Thanks. I have applied this additional patch in the testing release 0.15_02. https://metacpan.org/release/DBOOK/Net-Amazon-Signature-V4-0.15_02

Sat Apr 01 14:17:29 2017 steven.hartland [...] multiplay.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #100964] Patch to fix a few issues in Net-Amazon-Signature-V4
Date:	Sat, 1 Apr 2017 19:17:13 +0100
To:	bug-Net-Amazon-Signature-V4 [...] rt.cpan.org
From:	Steven Hartland <steven.hartland [...] multiplay.co.uk>

On 01/04/2017 18:32, Dan Book via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100964 > > > On Fri Mar 31 07:08:31 2017, steveh wrote:

>> Thank Dan, I've attached an additional patch we're also using here. >> >> This does the following: >> 1. Ensures the Host header is always present, as its required. >> 2. Sets the X-Amz-Content-Sha256 when we calculate the payload hash, >> as >> certain regions require it. >> 3. Always sets X-Amz-Date to workaround Amazon implementation not >> abiding by the spec and requiring X-Amz-Date in some regions. >> >> Regards >> Steve

> Thanks. I have applied this additional patch in the testing release 0.15_02. https://metacpan.org/release/DBOOK/Net-Amazon-Signature-V4-0.15_02

Thanks Dan, I'll get our internal FreeBSD port updated to that and do some testing when we're back in the office next week.

Fri Apr 28 20:36:35 2017 DBOOK [...] cpan.org - Correspondence added

Applied in 0.16

Fri Apr 28 20:36:41 2017 DBOOK [...] cpan.org - Status changed from 'open' to 'resolved'