Bug #100959 for XML-Parser: Test t/astress.t fails on perl 5.10.0

Wed Dec 17 03:00:11 2014 MICHIELB [...] cpan.org - Ticket created

Subject:

Test t/astress.t fails on perl 5.10.0

I was able to reproduce this on a 5.10.0 perl on both Linux and OS X. t/astress.t .. 1/27 not ok 5 not ok 6 not ok 7 not ok 8 not ok 9 not ok 10 not ok 11 not ok 14 not ok 18 not ok 19 not ok 20 not ok 21 not ok 22 not ok 23 not ok 24 t/astress.t .. Failed 15/27 subtests

Wed Dec 17 14:11:47 2014 rt-cpan [...] trout.me.uk - Correspondence added

This is because the code assumes that FileHandle has a read() method, which it does on more recent perls because of inheritance from IO::Handle, but isn't true on older perls. prove -bv t/astress.t t/astress.t .. 1..27 ok 1 ok 2 ok 3 Parse error: Can't locate object method "read" via package "FileHandle" at /root/.cpan/build/XML-Parser-2.43-haFpxP/blib/lib/XML/Parser/Expat.pm line 482. at line 10, column 34, byte 240 Handler couldn't resolve external entity at line 10, column 34, byte 240 error in processing external entity reference at line 10, column 34, byte 240 at /root/.cpan/build/XML-Parser-2.43-haFpxP/blib/lib/XML/Parser.pm line 187 ok 4 not ok 5 not ok 6 not ok 7 not ok 8 not ok 9 not ok 10 not ok 11 ok 12 ok 13 not ok 14 ok 15 ok 16 ok 17 not ok 18 not ok 19 not ok 20 not ok 21 not ok 22 not ok 23 not ok 24 ok 25 ok 26 ok 27 Failed 15/27 subtests

Wed Dec 17 14:11:48 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 12 02:06:06 2015 TODDR [...] cpan.org - Correspondence added

RT-Send-CC:

rt-cpan [...] trout.me.uk

This looks to have been broken for a while. For those still using 5.10, the solution appears to be to use FileHandle with your XML::Parser. How about this for a hack on the unit test problem? https://github.com/toddr/XML-Parser/commit/b576a78adec94b808146184eb9ee54be9488c79e

Mon Jan 12 02:39:01 2015 michiel.beijen [...] gmail.com - Correspondence added

CC:	MICHIELB [...] cpan.org
Subject:	Re: [rt.cpan.org #100959] Test t/astress.t fails on perl 5.10.0
Date:	Mon, 12 Jan 2015 08:38:19 +0100
To:	bug-XML-Parser [...] rt.cpan.org
From:	Michiel Beijen <michiel.beijen [...] gmail.com>

Hi Todd, On Mon, Jan 12, 2015 at 8:06 AM, Todd Rinaldo via RT <bug-XML-Parser@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100959 > > > This looks to have been broken for a while. For those still using 5.10, the solution appears to be to use FileHandle with your XML::Parser. > > How about this for a hack on the unit test problem? > > https://github.com/toddr/XML-Parser/commit/b576a78adec94b808146184eb9ee54be9488c79e

Great! Or maybe even use if $] < 5.012, FileHandle; although that is just nitpicking, it's only in the test file and your change already makes tests pass... thanks a lot. I'm still interested in 5.10.x mostly because my employer deploys stuff on CentOS/RHEL 6 and it comes with 5.10.1 as a system perl. -- Mike

Thu Jan 15 05:18:07 2015 MICHIELB [...] cpan.org - Correspondence added

Thanks, tests pass again on my 5.10.0 and 5.10.1 perls.

Thu Jan 15 05:18:14 2015 MICHIELB [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jan 15 05:18:15 2015 MICHIELB [...] cpan.org - Fixed in 2.44 added

Mon Feb 01 03:12:23 2016 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

rt-cpan [...] trout.me.uk, michiel.beijen [...] gmail.com

On 2015-01-12 02:06:06, TODDR wrote: Show quoted text

> This looks to have been broken for a while. For those still using > 5.10, the solution appears to be to use FileHandle with your > XML::Parser. > > How about this for a hack on the unit test problem? > > https://github.com/toddr/XML- > Parser/commit/b576a78adec94b808146184eb9ee54be9488c79e

As I see the same error in another distribution (libxml-perl, see http://www.cpantesters.org/cpan/report/0ada90c8-7d53-11e5-bd9c-5d080e4543d6 for a sample fail report) I think the fix should go to the .pm, not the .t file.

Mon Feb 01 03:12:24 2016 SREZIC [...] cpan.org - Status changed from 'resolved' to 'open'

Wed Apr 13 00:45:50 2016 TODDR [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Apr 13 00:45:50 2016 TODDR [...] cpan.org - Broken in 2.44 added

Wed Apr 13 00:45:51 2016 TODDR [...] cpan.org - Broken in 2.43 deleted