Skip Menu |

This queue is for tickets about the Map-Tube CPAN distribution.

Report information
The Basics
Id: 100772
Status: resolved
Priority: 0/
Queue: Map-Tube

People
Owner: MANWAR [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: 2.38



Subject: New utf8 flag breaks Map::Tube::Berlin (2.36)
Map::Tube 2.36 breaks the test suite of Map::Tube::Berlin. It looks like the new utf8 flag is causing the test fail, i.e. the both tests using utf8 characters are failing. I could add a utf8=>0 to the constructor in the test script. Which is quite counter-intuitive, because the source code of the file is already marked with "use utf8". I think the utf8 flag is not needed at all, in fact, earlier Map::Tube versions worked correctly wrt to utf8 handling. Map::Tube should assume that the incoming parameters are already correctly encoded (i.e. user is specifying "use utf8" in the source code, or properly decoding commandline arguments, or using a utf8 layer for opened files). It should not do any decoding itself. So I think you should revert the change in 2.36. Maybe you could leave the option as some kind of convenience functionality for users not properly mark their input parameters, but it should not be the default, and it should say in the documentation that using this option is not a good idea.
Dne Ne 07.pro.2014 10:53:07, SREZIC napsal(a): Show quoted text
> I think the utf8 flag is not needed at all, in fact, earlier Map::Tube > versions worked correctly wrt to utf8 handling. Map::Tube should > assume that the incoming parameters are already correctly encoded > (i.e. user is specifying "use utf8" in the source code, or properly > decoding commandline arguments, or using a utf8 layer for opened > files). It should not do any decoding itself. So I think you should > revert the change in 2.36. Maybe you could leave the option as some > kind of convenience functionality for users not properly mark their > input parameters, but it should not be the default, and it should say > in the documentation that using this option is not a good idea.
I think too. M.
Removed the conditional encoding/decoding (utf8) and left it to the wrapper class or script to handle it themselves. This new code has been pushed to CPAN and GitHub v2.38.
On 2014-12-07 12:28:10, MANWAR wrote: Show quoted text
> Removed the conditional encoding/decoding (utf8) and left it to the > wrapper class or script to handle it themselves. > > This new code has been pushed to CPAN and GitHub v2.38.
Thanks.