Bug #100751 for Time-HiRes: gcc 4.9.2 warnings

Sat Dec 06 15:17:31 2014 JHI [...] cpan.org - Ticket created

Subject:

gcc 4.9.2 warnings

HiRes.c: In function 'XS_Time__HiRes_clock_gettime': HiRes.c:1671:6: warning: variable 'clock_id' set but not used [-Wunused-but-set-variable] int clock_id; ^ HiRes.c: In function 'XS_Time__HiRes_clock_getres': HiRes.c:1741:6: warning: variable 'clock_id' set but not used [-Wunused-but-set-variable] int clock_id; ^ HiRes.xs: In function 'XS_Time__HiRes_clock': HiRes.xs:1250:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] RETVAL = clocks == -1 ? -1 : (NV)clocks / (NV)CLOCKS_PER_SEC; ^

Sat Aug 29 18:10:28 2015 rjbs [...] cpan.org - Correspondence added

Is this also fixed by your fix for #102718? -- rjbs

Sat Aug 29 18:10:28 2015 The RT System itself - Status changed from 'new' to 'open'

Sat Aug 29 19:27:39 2015 jhi [...] iki.fi - Correspondence added

Subject:	Re: [rt.cpan.org #100751] gcc 4.9.2 warnings
Date:	Sat, 29 Aug 2015 19:27:16 -0400
To:	bug-Time-HiRes [...] rt.cpan.org, JHI [...] cpan.org
From:	Jarkko Hietaniemi <jhi [...] iki.fi>

On Saturday-201508-29 18:10, Ricardo Signes via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100751 > > > Is this also fixed by your fix for #102718? >

It might be. Is there a repo I could check?

Sat Aug 29 19:37:26 2015 rjbs [...] cpan.org - Correspondence added

CC:	;
Subject:	Re: [rt.cpan.org #100751] gcc 4.9.2 warnings
Date:	Sat, 29 Aug 2015 19:37:11 -0400
To:	"jhi [...] iki.fi via RT" <bug-Time-HiRes [...] rt.cpan.org>
From:	Ricardo Signes <rjbs [...] cpan.org>

* "jhi@iki.fi via RT" <bug-Time-HiRes@rt.cpan.org> [2015-08-29T19:27:40] Show quoted text

> It might be. Is there a repo I could check?

https://github.com/rjbs/Time-HiRes has the lastest, as does https://metacpan.org/release/RJBS/Time-HiRes-1.9727_02 -- rjbs

Download signature.asc
application/pgp-signature 473b

Message body not shown because it is not plain text.

Sat Aug 29 20:00:00 2015 jhi [...] iki.fi - Correspondence added

Subject:	Re: [rt.cpan.org #100751] gcc 4.9.2 warnings
Date:	Sat, 29 Aug 2015 19:59:50 -0400
To:	bug-Time-HiRes [...] rt.cpan.org, JHI [...] cpan.org
From:	Jarkko Hietaniemi <jhi [...] iki.fi>

On Saturday-201508-29 19:37, Ricardo Signes via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100751 > > > * "jhi@iki.fi via RT" <bug-Time-HiRes@rt.cpan.org> [2015-08-29T19:27:40]

>> It might be. Is there a repo I could check?

> > https://github.com/rjbs/Time-HiRes > > has the lastest, as does > https://metacpan.org/release/RJBS/Time-HiRes-1.9727_02 >

The #102718 fix indeed works, but in OS X I noticed a new (unrelated to this bug) warning, because of unimplemented interfaces. Patch attached.

Message body is not shown because sender requested not to inline it.

Sat Aug 29 20:09:03 2015 jhi [...] iki.fi - Correspondence added

Subject:	Re: [rt.cpan.org #100751] gcc 4.9.2 warnings
Date:	Sat, 29 Aug 2015 20:08:49 -0400
To:	bug-Time-HiRes [...] rt.cpan.org
From:	Jarkko Hietaniemi <jhi [...] iki.fi>

On Saturday-201508-29 20:00, jhi@iki.fi via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100751 > > > On Saturday-201508-29 19:37, Ricardo Signes via RT wrote:

>> <URL: https://rt.cpan.org/Ticket/Display.html?id=100751 > >> >> * "jhi@iki.fi via RT" <bug-Time-HiRes@rt.cpan.org> [2015-08-29T19:27:40]

>>> It might be. Is there a repo I could check?

>> >> https://github.com/rjbs/Time-HiRes >> >> has the lastest, as does >> https://metacpan.org/release/RJBS/Time-HiRes-1.9727_02 >>

> > The #102718 fix indeed works, but in OS X I noticed a new (unrelated to > this bug) warning, because of unimplemented interfaces. Patch attached.

So the patch was against the blead T::H, sorry about that. Now testing with the repo. Show quoted text

> > >

Sat Aug 29 20:19:46 2015 jhi [...] iki.fi - Correspondence added

Subject:	Re: [rt.cpan.org #100751] gcc 4.9.2 warnings
Date:	Sat, 29 Aug 2015 20:19:31 -0400
To:	bug-Time-HiRes [...] rt.cpan.org
From:	Jarkko Hietaniemi <jhi [...] iki.fi>

On Saturday-201508-29 20:09, jhi@iki.fi via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100751 > > > On Saturday-201508-29 20:00, jhi@iki.fi via RT wrote:

>> <URL: https://rt.cpan.org/Ticket/Display.html?id=100751 > >> >> On Saturday-201508-29 19:37, Ricardo Signes via RT wrote:

>>> <URL: https://rt.cpan.org/Ticket/Display.html?id=100751 > >>> >>> * "jhi@iki.fi via RT" <bug-Time-HiRes@rt.cpan.org> [2015-08-29T19:27:40]

>>>> It might be. Is there a repo I could check?

>>> >>> https://github.com/rjbs/Time-HiRes >>> >>> has the lastest, as does >>> https://metacpan.org/release/RJBS/Time-HiRes-1.9727_02 >>>

>> >> The #102718 fix indeed works, but in OS X I noticed a new (unrelated to >> this bug) warning, because of unimplemented interfaces. Patch attached.

> > So the patch was against the blead T::H, sorry about that. Now testing > with the repo.

I'm confused about the results... and right now out of time. So please ignore the patch. But there's definitely some "unused" sprinkling needed around the clock_id when the APIs with clock_id args are not available, and we have just a croak() instead.

Fri Feb 12 21:08:18 2016 JHI [...] cpan.org - Correspondence added

This was resolved by the "rjbs" releases.

Fri Feb 12 21:08:24 2016 JHI [...] cpan.org - Status changed from 'open' to 'resolved'