Skip Menu |

This queue is for tickets about the Mail-Sender-Easy CPAN distribution.

Report information
The Basics
Id: 100675
Status: open
Priority: 0/
Queue: Mail-Sender-Easy

People
Owner: Nobody in particular
Requestors: jamesa [...] nationalfitness.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Re: Mail::Sender::Easy (inline image plus attached PDF like in example)
Date: Tue, 02 Dec 2014 14:50:50 -0700
To: Daniel Muey <dmuey [...] cpan.org>, Scott Welling <scottw [...] nffs.com>, bug-Mail-Sender-Easy [...] rt.cpan.org
From: James Alton <jamesa [...] nationalfitness.com>
I would like to submit this diff to Mail::Sender::Easy v0.0.5. It will allow inline images / attached PDFs (as the example for Mail::Sender::Easy shows) to work correctly with the latest version of Thunderbird. (Email client) The difference is that after applying this diff, the HTML part will have a mime type of multipart/related with another sub-branch and include the images there. (This is how Thunderbird does it when you send with an inline image and attached files.) I've also tested this using Gmail and iPhone "Mail" (iOS 7). (Both worked perfectly.) It will also allow using the '_no_custom_headers' option to avoid putting my program's path in the headers. 40d39 < my $no_custom_headers = delete $mail_ref->{'_no_custom_headers'}; 68,70c67 < unless ($no_custom_headers) { < local $Mail::Sender::SITE_HEADERS = join("\015\012", @siteheaders) || ''; < } --- Show quoted text
> local $Mail::Sender::SITE_HEADERS = join("\015\012",
@siteheaders) || ''; 88,91d84 < 'ctype' => 'multipart/related' < }); < < $sndr->Part({ 98a92 Show quoted text
> $sndr->EndPart('multipart/alternative');
119,133c113 < my @attach_array = keys %{ $attachments }; < < #sort attachments that define _inline attachments to be first < @attach_array = sort { ($attachments->{$b}{'_inline'} || '') cmp ($attachments->{$a}{'_inline'} || '') } @attach_array; < < my $processed_all_images; < < for my $attach (@attach_array) { < < #Encountered first attachment that isn't an image < if((not defined $attachments->{ $attach }{'_inline'}) && $html && !$processed_all_images) { < $sndr->EndPart('multipart/related'); < $sndr->EndPart('multipart/alternative'); < $processed_all_images = 1; < } --- Show quoted text
> for my $attach (keys %{ $attachments }) {
Thanks, James Alton
Thanks James, I’ll try to get to this ASAP. I will probably also move this to github at the same time to make pull requests possible. thanks! On Tue Dec 02 16:51:03 2014, jamesa@nationalfitness.com wrote: Show quoted text
> I would like to submit this diff to Mail::Sender::Easy v0.0.5. It will > allow inline images / attached PDFs (as the example for > Mail::Sender::Easy shows) to work correctly with the latest version of > Thunderbird. (Email client) > The difference is that after applying this diff, the HTML part will have > a mime type of multipart/related with another sub-branch and include the > images there. (This is how Thunderbird does it when you send with an > inline image and attached files.) > I've also tested this using Gmail and iPhone "Mail" (iOS 7). (Both > worked perfectly.) > It will also allow using the '_no_custom_headers' option to avoid > putting my program's path in the headers. > > 40d39 > < my $no_custom_headers = delete $mail_ref->{'_no_custom_headers'}; > 68,70c67 > < unless ($no_custom_headers) { > < local $Mail::Sender::SITE_HEADERS = join("\015\012", > @siteheaders) || ''; > < } > ---
> > local $Mail::Sender::SITE_HEADERS = join("\015\012",
> @siteheaders) || ''; > 88,91d84 > < 'ctype' => 'multipart/related' > < }); > < > < $sndr->Part({ > 98a92
> > $sndr->EndPart('multipart/alternative');
> 119,133c113 > < my @attach_array = keys %{ $attachments }; > < > < #sort attachments that define _inline attachments to be first > < @attach_array = sort { ($attachments->{$b}{'_inline'} || > '') cmp ($attachments->{$a}{'_inline'} || '') } @attach_array; > < > < my $processed_all_images; > < > < for my $attach (@attach_array) { > < > < #Encountered first attachment that isn't an image > < if((not defined $attachments->{ $attach }{'_inline'}) > && $html && !$processed_all_images) { > < $sndr->EndPart('multipart/related'); > < $sndr->EndPart('multipart/alternative'); > < $processed_all_images = 1; > < } > ---
> > for my $attach (keys %{ $attachments }) {
> > Thanks, > James Alton >
Subject: Re: [rt.cpan.org #100675] Re: Mail::Sender::Easy (inline image plus attached PDF like in example)
Date: Wed, 03 Dec 2014 09:55:47 -0700
To: bug-Mail-Sender-Easy [...] rt.cpan.org
From: James Alton <jamesa [...] nationalfitness.com>
Daniel, I would really appreciate the ability to do a git pull request, especially if it makes your job easier! Attached is the version of Easy.pm that I have after the diff. Thanks, James Alton National Fitness IT Dev On 12/03/2014 06:08 AM, Daniel Muey via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100675 > > > Thanks James, I’ll try to get to this ASAP. > > I will probably also move this to github at the same time to make pull requests possible. > > thanks! > > On Tue Dec 02 16:51:03 2014, jamesa@nationalfitness.com wrote:
>> I would like to submit this diff to Mail::Sender::Easy v0.0.5. It will >> allow inline images / attached PDFs (as the example for >> Mail::Sender::Easy shows) to work correctly with the latest version of >> Thunderbird. (Email client) >> The difference is that after applying this diff, the HTML part will have >> a mime type of multipart/related with another sub-branch and include the >> images there. (This is how Thunderbird does it when you send with an >> inline image and attached files.) >> I've also tested this using Gmail and iPhone "Mail" (iOS 7). (Both >> worked perfectly.) >> It will also allow using the '_no_custom_headers' option to avoid >> putting my program's path in the headers. >> >> 40d39 >> < my $no_custom_headers = delete $mail_ref->{'_no_custom_headers'}; >> 68,70c67 >> < unless ($no_custom_headers) { >> < local $Mail::Sender::SITE_HEADERS = join("\015\012", >> @siteheaders) || ''; >> < } >> ---
>>> local $Mail::Sender::SITE_HEADERS = join("\015\012",
>> @siteheaders) || ''; >> 88,91d84 >> < 'ctype' => 'multipart/related' >> < }); >> < >> < $sndr->Part({ >> 98a92
>>> $sndr->EndPart('multipart/alternative');
>> 119,133c113 >> < my @attach_array = keys %{ $attachments }; >> < >> < #sort attachments that define _inline attachments to be first >> < @attach_array = sort { ($attachments->{$b}{'_inline'} || >> '') cmp ($attachments->{$a}{'_inline'} || '') } @attach_array; >> < >> < my $processed_all_images; >> < >> < for my $attach (@attach_array) { >> < >> < #Encountered first attachment that isn't an image >> < if((not defined $attachments->{ $attach }{'_inline'}) >> && $html && !$processed_all_images) { >> < $sndr->EndPart('multipart/related'); >> < $sndr->EndPart('multipart/alternative'); >> < $processed_all_images = 1; >> < } >> ---
>>> for my $attach (keys %{ $attachments }) {
>> Thanks, >> James Alton >>
> >

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #100675] Re: Mail::Sender::Easy (inline image plus attached PDF like in example)
Date: Wed, 03 Dec 2014 10:01:53 -0700
To: bug-Mail-Sender-Easy [...] rt.cpan.org, Scott Welling <scottw [...] nffs.com>
From: James Alton <jamesa [...] nationalfitness.com>
Daniel, Bug in my fix, please don't apply yet! (Our users are seeing an attachment when there is no attachment. My initial thoughts on this are: a MIME boundary being opened and closed with no content.) James Alton National Fitness IT Dev On 12/03/2014 06:08 AM, Daniel Muey via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100675 > > > Thanks James, I’ll try to get to this ASAP. > > I will probably also move this to github at the same time to make pull requests possible. > > thanks! > > On Tue Dec 02 16:51:03 2014, jamesa@nationalfitness.com wrote:
>> I would like to submit this diff to Mail::Sender::Easy v0.0.5. It will >> allow inline images / attached PDFs (as the example for >> Mail::Sender::Easy shows) to work correctly with the latest version of >> Thunderbird. (Email client) >> The difference is that after applying this diff, the HTML part will have >> a mime type of multipart/related with another sub-branch and include the >> images there. (This is how Thunderbird does it when you send with an >> inline image and attached files.) >> I've also tested this using Gmail and iPhone "Mail" (iOS 7). (Both >> worked perfectly.) >> It will also allow using the '_no_custom_headers' option to avoid >> putting my program's path in the headers. >> >> 40d39 >> < my $no_custom_headers = delete $mail_ref->{'_no_custom_headers'}; >> 68,70c67 >> < unless ($no_custom_headers) { >> < local $Mail::Sender::SITE_HEADERS = join("\015\012", >> @siteheaders) || ''; >> < } >> ---
>>> local $Mail::Sender::SITE_HEADERS = join("\015\012",
>> @siteheaders) || ''; >> 88,91d84 >> < 'ctype' => 'multipart/related' >> < }); >> < >> < $sndr->Part({ >> 98a92
>>> $sndr->EndPart('multipart/alternative');
>> 119,133c113 >> < my @attach_array = keys %{ $attachments }; >> < >> < #sort attachments that define _inline attachments to be first >> < @attach_array = sort { ($attachments->{$b}{'_inline'} || >> '') cmp ($attachments->{$a}{'_inline'} || '') } @attach_array; >> < >> < my $processed_all_images; >> < >> < for my $attach (@attach_array) { >> < >> < #Encountered first attachment that isn't an image >> < if((not defined $attachments->{ $attach }{'_inline'}) >> && $html && !$processed_all_images) { >> < $sndr->EndPart('multipart/related'); >> < $sndr->EndPart('multipart/alternative'); >> < $processed_all_images = 1; >> < } >> ---
>>> for my $attach (keys %{ $attachments }) {
>> Thanks, >> James Alton >>
> >
Subject: Re: [rt.cpan.org #100675] Re: Mail::Sender::Easy (inline image plus attached PDF like in example)
Date: Wed, 03 Dec 2014 16:03:03 -0700
To: bug-Mail-Sender-Easy [...] rt.cpan.org, Scott Welling <scottw [...] nffs.com>
From: James Alton <jamesa [...] nationalfitness.com>
Daniel, I've created a git repository and made changes to fix the problem I found in the previous email. (Its fixed in v0.0.5.2 on the git repo below.) Then I ran a few tests (see t/Tests) on 4 different email readers with 6 different types of email. (I believe this should cover most of the email reading audience other than various web email readers.) https://github.com/nf-contribute/Mail-Sender-Easy-perl https://github.com/nf-contribute/Mail-Sender-Easy-perl/compare/v0.0.5...v0.0.5.2 (for changes from cpan.org version to latest I have on github) https://github.com/nf-contribute/Mail-Sender-Easy-perl/compare/v0.0.5.1...v0.0.5.2 (for the fix of "no attachments but attachments still shown" emails) Thanks, James Alton National Fitness IT Dev On 12/03/2014 10:01 AM, James Alton wrote: Show quoted text
> Daniel, > > Bug in my fix, please don't apply yet! > (Our users are seeing an attachment when there is no attachment. My > initial thoughts on this are: a MIME boundary being opened and closed > with no content.) > > James Alton > National Fitness > IT Dev > > On 12/03/2014 06:08 AM, Daniel Muey via RT wrote:
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=100675 > >> >> Thanks James, I’ll try to get to this ASAP. >> >> I will probably also move this to github at the same time to make pull requests possible. >> >> thanks! >> >> On Tue Dec 02 16:51:03 2014, jamesa@nationalfitness.com wrote:
>>> I would like to submit this diff to Mail::Sender::Easy v0.0.5. It will >>> allow inline images / attached PDFs (as the example for >>> Mail::Sender::Easy shows) to work correctly with the latest version of >>> Thunderbird. (Email client) >>> The difference is that after applying this diff, the HTML part will have >>> a mime type of multipart/related with another sub-branch and include the >>> images there. (This is how Thunderbird does it when you send with an >>> inline image and attached files.) >>> I've also tested this using Gmail and iPhone "Mail" (iOS 7). (Both >>> worked perfectly.) >>> It will also allow using the '_no_custom_headers' option to avoid >>> putting my program's path in the headers. >>> >>> 40d39 >>> < my $no_custom_headers = delete $mail_ref->{'_no_custom_headers'}; >>> 68,70c67 >>> < unless ($no_custom_headers) { >>> < local $Mail::Sender::SITE_HEADERS = join("\015\012", >>> @siteheaders) || ''; >>> < } >>> ---
>>>> local $Mail::Sender::SITE_HEADERS = join("\015\012",
>>> @siteheaders) || ''; >>> 88,91d84 >>> < 'ctype' => 'multipart/related' >>> < }); >>> < >>> < $sndr->Part({ >>> 98a92
>>>> $sndr->EndPart('multipart/alternative');
>>> 119,133c113 >>> < my @attach_array = keys %{ $attachments }; >>> < >>> < #sort attachments that define _inline attachments to be first >>> < @attach_array = sort { ($attachments->{$b}{'_inline'} || >>> '') cmp ($attachments->{$a}{'_inline'} || '') } @attach_array; >>> < >>> < my $processed_all_images; >>> < >>> < for my $attach (@attach_array) { >>> < >>> < #Encountered first attachment that isn't an image >>> < if((not defined $attachments->{ $attach }{'_inline'}) >>> && $html && !$processed_all_images) { >>> < $sndr->EndPart('multipart/related'); >>> < $sndr->EndPart('multipart/alternative'); >>> < $processed_all_images = 1; >>> < } >>> ---
>>>> for my $attach (keys %{ $attachments }) {
>>> Thanks, >>> James Alton >>>
>>
On Wed Dec 03 18:03:15 2014, jamesa@nationalfitness.com wrote: Show quoted text
> Daniel, > I've created a git repository and made changes to fix the problem
thanks, instead can you do a pull request using https://github.com/drmuey/p5-Mail-Sender-Easy ? thanks!
Also, can you do the _no_custom_headers as a separate pull request? It needs to be adjusted before sent to public so it'd be nice to have them in discreet chunks, thanks!
Subject: Re: [rt.cpan.org #100675] Re: Mail::Sender::Easy (inline image plus attached PDF like in example)
Date: Wed, 03 Dec 2014 17:01:14 -0700
To: bug-Mail-Sender-Easy [...] rt.cpan.org, Scott Welling <scottw [...] nffs.com>
From: James Alton <jamesa [...] nationalfitness.com>
I have stripped out _no_customer_headers parts and submitted a pull request. https://github.com/drmuey/p5-Mail-Sender-Easy/pull/1 (My intent with _no_custom_headers was not to remove attribution for the module, but to prevent data from leaking out out such as the hostname, path, username, etc. I've changed it on my side to include the first line (with your attribution) and optionally include the second line.) Thanks, James Alton National Fitness IT Dev On 12/03/2014 04:49 PM, Daniel Muey via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=100675 > > > Also, can you do the _no_custom_headers as a separate pull request? It needs to be adjusted before sent to public so it'd be nice to have them in discreet chunks, thanks! >
On Wed Dec 03 19:01:24 2014, jamesa@nationalfitness.com wrote: Show quoted text
> I have stripped out _no_customer_headers parts and submitted a pull > request. > https://github.com/drmuey/p5-Mail-Sender-Easy/pull/1
thanks! Show quoted text
> > (My intent with _no_custom_headers was not to remove attribution for > the > module, but to prevent data from leaking out out such as the hostname, > path, username, etc. I've changed it on my side to include the first > line (with your attribution) and optionally include the second line.)
sure, its a good idea, its just needs done per the other rt, thanks!