Bug #100608 for CSS-Simple: method read_file() not closing file handle

Sat Nov 29 09:51:04 2014 MANWAR [...] cpan.org - Ticket created

Subject:

method read_file() not closing file handle

Hi Kevin, I found the method read_file() not closing the file handler after slurping the contents of CSS file. open FILE, "<", $$params{filename} or croak $!; my $css = do { local( $/ ) ; <FILE> } ; should actually be: open FILE, "<", $$params{filename} or croak $!; my $css = do { local( $/ ) ; <FILE> } ; close FILE; Best Regards, Mohammad S Anwar

Fri Jul 10 20:22:10 2015 KAMELKEV [...] cpan.org - Correspondence added

Hi Mohammad, Good catch. I tend to be lazy about file handles, but this is definitely the correct thing to do. I just added your fix and pushed a new version, you should see it in 72 hours on CPAN. thanks, Kevin On Sat Nov 29 09:51:04 2014, MANWAR wrote: Show quoted text

> Hi Kevin, > > I found the method read_file() not closing the file handler after > slurping the contents of CSS file. > > open FILE, "<", $$params{filename} or croak $!; > my $css = do { local( $/ ) ; <FILE> } ; > > should actually be: > > open FILE, "<", $$params{filename} or croak $!; > my $css = do { local( $/ ) ; <FILE> } ; > close FILE; > > Best Regards, > Mohammad S Anwar

Fri Jul 10 20:22:11 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 10 20:22:18 2015 KAMELKEV [...] cpan.org - Status changed from 'open' to 'resolved'