Bug #100550 for Wx: Wx::ProgressDialog: missing methods

Tue Nov 25 12:24:24 2014 dolmen [...] cpan.org - Ticket created

Subject:

Wx::ProgressDialog: missing methods

In Wx 0.9923, the package Wx::ProgressDialog is missing useful methods:
- SetRange
- GetValue
- WasCancelled
- ...

Reference :
http://docs.wxwidgets.org/3.0/classwx_generic_progress_dialog.html

--
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/

Wed Nov 26 06:51:37 2014 steveco.1959 [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #100550] Wx::ProgressDialog: missing methods
Date:	Wed, 26 Nov 2014 11:51:20 +0000
To:	bug-Wx [...] rt.cpan.org, wxperl-users <wxperl-users [...] perl.org>
From:	Steve Cookson - gmail <steveco.1959 [...] gmail.com>

Hi Oliver, Thanks for this. If I make some patches, would you be able to test it? I've put some draft new code below (untested). It goes in wxPerl/XS/ProcessDialog.xs, at the end of the file. You can update the file and then "cd xPerl" "make" "make install". I am travelling at the moment, but as soon as I can I'll make the changes on github. If you can test the changes, then we'll try to get them uploaded as soon as we can. know what you think. Regards Steve. #if WXPERL_W_VERSION_GE( 2, 9, 0 ) wxString wxProgressDialog::GetMessage() int value int wxProgressDialog::GetRange() int value int wxProgressDialog::GetValue() int value #endif #if WXPERL_W_VERSION_GE( 2, 9, 1 ) void wxProgressDialog::SetRange(value) int value bool wxProgressDialog::WasCancelled() bool wxProgressDialog::WasSkipped() #endif On 25/11/14 17:24, Olivier Mengué via RT wrote: Show quoted text

> Tue Nov 25 12:24:24 2014: Request 100550 was acted upon. > Transaction: Ticket created by DOLMEN > Queue: Wx > Subject: Wx::ProgressDialog: missing methods > Broken in: 0.9923 > Severity: Wishlist > Owner: Nobody > Requestors: dolmen@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=100550 > > > > In Wx 0.9923, the package Wx::ProgressDialog is missing useful methods: > - SetRange > - GetValue > - WasCancelled > - ... > > Reference : > http://docs.wxwidgets.org/3.0/classwx_generic_progress_dialog.html > > > -- > Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/ > >

Wed Nov 26 06:51:38 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Nov 26 07:19:19 2014 steve.cookson [...] sca-uk.com - Correspondence added

Subject:	Re: [rt.cpan.org #100550] Wx::ProgressDialog: missing methods
Date:	Wed, 26 Nov 2014 12:19:02 +0000
To:	bug-Wx [...] rt.cpan.org, wxperl-users [...] perl.org
From:	Steve Cookson <steve.cookson [...] sca-uk.com>

On 26/11/14 11:51, Steve Cookson - gmail via RT wrote: Show quoted text

> wxString > wxProgressDialog::GetMessage() > int value

Actually, that should probably be wxString* wxProgressDialog::GetMessage() Sorry, Steve

Thu Nov 27 16:05:16 2014 dolmen [...] cpan.org - Correspondence added

Le 2014-11-26 12:51:37, steveco.1959@gmail.com a écrit :
Show quoted text

> Hi Oliver,
>
> Thanks for this. If I make some patches, would you be able to test
> it?

Yes.

Show quoted text

> I've put some draft new code below (untested). It goes in
> wxPerl/XS/ProcessDialog.xs, at the end of the file. You can update
> the
> file and then "cd xPerl" "make" "make install".
>
> I am travelling at the moment, but as soon as I can I'll make the
> changes on github.

The code is now on Github? Where?
META.yml still points to http://svn.code.sf.net/p/wxperl/code/wxPerl/

--
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/

Wed Dec 03 04:41:14 2014 steveco.1959 [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #100550] Wx::ProgressDialog: missing methods
Date:	Wed, 03 Dec 2014 09:40:55 +0000
To:	bug-Wx [...] rt.cpan.org, wxperl-users [...] perl.org
From:	Steve Cookson - gmail <steveco.1959 [...] gmail.com>

Hi Oliver, I just went in to make these changes and saw that they were already there. If you just download wxPerl again it should work alright. Do you think that it doesn't? What are you seeing? All of: wxProgressDialog::GetRange() wxProgressDialog::GetValue() wxProgressDialog::GetMessage() wxProgressDialog::SetRange( maximum ) wxProgressDialog::WasCancelled() wxProgressDialog::WasSkipped() seem to be there. Regards Steve On 27/11/14 21:05, Olivier Mengué via RT wrote: Show quoted text

> Thu Nov 27 16:05:16 2014: Request 100550 was acted upon. > Transaction: Correspondence added by DOLMEN > Queue: Wx > Subject: Wx::ProgressDialog: missing methods > Broken in: 0.9923 > Severity: Wishlist > Owner: Nobody > Requestors: dolmen@cpan.org > Status: open > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=100550 > > > > Le 2014-11-26 12:51:37, steveco.1959@gmail.com a écrit :

>> Hi Oliver, >> >> Thanks for this. If I make some patches, would you be able to test >> it?

> Yes. >

>> I've put some draft new code below (untested). It goes in >> wxPerl/XS/ProcessDialog.xs, at the end of the file. You can update >> the >> file and then "cd xPerl" "make" "make install". >> >> I am travelling at the moment, but as soon as I can I'll make the >> changes on github.

> The code is now on Github? Where? > META.yml still points to http://svn.code.sf.net/p/wxperl/code/wxPerl/ > > -- > Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/ > >