Bug #100528 for AnyEvent-HTTP: cookie support broken

Mon Nov 24 09:19:13 2014 abraxxa [...] cpan.org - Ticket created

Subject:

cookie support broken

It seems two variable names have been swapped, with this git diff applied it works that cookie learned by Set-Cookie response header is sent on the next request: git diff ./lib/site_perl/5.18.1/AnyEvent/HTTP.pm diff --git a/lib/site_perl/5.18.1/AnyEvent/HTTP.pm b/lib/site_perl/5.18.1/AnyEvent/HTTP.pm index 73312b7..ab36f50 100644 --- a/lib/site_perl/5.18.1/AnyEvent/HTTP.pm +++ b/lib/site_perl/5.18.1/AnyEvent/HTTP.pm @@ -491,7 +491,7 @@ sub cookie_jar_extract($$$$) { next unless ref $paths; if ($chost =~ /^\./) { - next unless $chost eq substr $host, -length $chost; + next unless $host eq substr $chost, -length $host; } elsif ($chost =~ /\./) { next unless $chost eq $host; } else {

Mon Nov 24 10:15:26 2014 schmorp [...] schmorp.de - Correspondence added

Subject:	Re: [rt.cpan.org #100528] cookie support broken
Date:	Mon, 24 Nov 2014 16:15:11 +0100
To:	Alexander Hartmaier via RT <bug-AnyEvent-HTTP [...] rt.cpan.org>
From:	Marc Lehmann <schmorp [...] schmorp.de>

Hi! Please send your bug report to the official contact/author address for the module in question (or send it to rt.cpan.org@schmorp.de, that's fine as well). What follows is the rationale for this request, you don't have to read it if you don't care. Why is this necessary? rt.cpan.org has many deficiencies which makes it tedious and hard to use, increasing the workload on the people who provide all the perl modules you probably appreciate (and that is really to be avoided - module authors should be able to invest all their time into improving their modules and not fighting with rt.cpan.org's bugs). Still, for some people, rt.cpan.org is useful to have, and some people even like it and really want to use it. That is fine, too. Unfortunately, the designers of rt.cpan.org didn't make their "service" optional - you can neither opt-in nor opt-out of rt.cpan.org as a module author. Just like a spammer, rt.cpan.org forces its "service" (whether wanted or unwanted) on everybody. Just like a spammer, they don't care for the people they actively hurt. Just like a spammer, they don't don't care to fix these issues and make their "service" ethically acceptable. You cannot even configure it to redirect tickets to somewhere else. Unfortunately, ignoring rt.cpan.org is not an option either: for people reporting possible bugs there is no indication that their report will be ignored, and for module authors it means they miss potentially vital bug reports such as yours (and of course it's a great impression if rt.cpan.org has lots of bug reports that are unanswered, making a module look unmaintained when in fact the opposite might be true). I am sorry that this wasted a bit of your time, but please understand that I am just as much a victim as you are - the problem is the unethical stance of the rt.cpan.org providers who force their "service" on everybody. Please redirect your bug report as stated in the beginning of this mail, and please consider petitioning the rt.cpan.org providers to stop their unethical behaviour and allow opt-in, opt-out, or some redirect option. One last issue: many people mail me that this can be "fixed" by including the bugtracker element in my module meta file. This is not true: 1. This field only affects search.cpan.org and maybe similar services. (Many people confuse rt.cpan.org with search.cpan.org for some reason). 2. It doesn't even work (there are still links to rt.cpan.org displayed). 3. Even if search.cpan.org does no longer display the link, it doesn't actually affect rt.cpan.org (and tests have shown that people go to rt.cpan.org regardless) Even *iff* rt.cpan.org would start listening on the bugtracker field, however, it's still wrong. I have a lot of modules, and each time a service like rt.cpan.org comes out, I would have to make dummy releases for all my modules. This not only creates a lot of extra work for me (I take releases very seriously) but also users, who would wonder why there is a new release. Thanks a lot, Marc Lehmann <rt.cpan.org@schmorp.de> Last updated: 2012-04-22

Mon Nov 24 10:15:26 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 24 11:36:36 2014 abraxxa [...] cpan.org - Correspondence added

Please fix your modules meta config to point at the bugtracker of your choice! I just clicked on the 'Issues' link on metacpan which even listed some open bugs. You cannot expect uses to know that you use a nonstandard bugtracker when neither the metadata nor the pod mentions it.

Mon Nov 24 13:02:02 2014 schmorp [...] schmorp.de - Correspondence added

Subject:	Re: [rt.cpan.org #100528] cookie support broken
Date:	Mon, 24 Nov 2014 19:01:48 +0100
To:	Alexander Hartmaier via RT <bug-AnyEvent-HTTP [...] rt.cpan.org>
From:	Marc Lehmann <schmorp [...] schmorp.de>

Since you didn't read (or understand) my standard reply, I guess you will not read (or understand) this reply either, but since I do believe in your good faith, I replied anyways. Note that I will not again waste this much time to reply on points that you can be expected to already know yourself - there are limits to my time, and deliberately wasting more is not well-received. Note also that you made not the slightest attempt to be helpful in this case, thereby forcing me to go online to check your original bug report. See below. On Mon, Nov 24, 2014 at 11:36:36AM -0500, Alexander Hartmaier via RT <bug-AnyEvent-HTTP@rt.cpan.org> wrote: Show quoted text

> Please fix your modules meta config to point at the bugtracker of your choice!

All my modules already specify the bugtracker of choice, namely none (I don't have a user-accessible bugtracker). The problem is that you used a bugtracker I didn't specify. I leave it up to you to find out why you did that. Show quoted text

> I just clicked on the 'Issues' link on metacpan which even listed some open bugs.

I hope you are aware that "metacpan" is not a module nor software nor a service by me, so if they sent you to the wrong bugtracker and that is a problem for you (it cetrainly is for me), you should complain to them. Or, in short, "I have zero control over what misinformation metacpan fabricates". Show quoted text

> You cannot expect uses to know that you use a nonstandard bugtracker > when neither the metadata nor the pod mentions it.

This would imply that rt.cpan.org is a "standard" bugtracker, but I see no evidence of why that would be so. It seems to be the standard bugtracker that metacpan substitutes when a project doesn't have one. Of course, another problem is you: I already explained this to some detail, but, being the unhelpful person you are, you instead opted to write a pretty dumb e-mail to me, telling me what to do and what not, when it would have cost you less time to find out that it is pointless. Lastly, I did visit your bugreport, and your patch is obviously wrong - the current code matches www.google.com against a chost of .google.com, while your code would not (wrong). Conversely, your code would match google.com against a chost of .google.com, which is also wrong, while the current code in the module doesn't. So, why do you think the code is currently wrong? -- The choice of a Deliantra, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / schmorp@schmorp.de -=====/_/_//_/\_,_/ /_/\_\

Mon Nov 24 13:12:32 2014 MLEHMANN [...] cpan.org - Status changed from 'open' to 'resolved'