Bug #100482 for DBIx-Class-ResultSet-RecursiveUpdate: Need proper fix for table aliases

Thu Nov 20 16:14:00 2014 ether [...] cpan.org - Ticket created

Subject:

Need proper fix for table aliases

CE has had this patch applied locally for quite some time: https://gist.github.com/karenetheridge/5d2457221bacfbd3fa68 I understand from ribasushi that this isn't quite the right thing to do, but nevertheless it would be nice to have some sort of fix rolled into the real distribution.

Tue Aug 09 11:31:02 2016 ribasushi [...] leporine.io - Correspondence added

On Thu Nov 20 22:14:00 2014, ETHER wrote: Show quoted text

> CE has had this patch applied locally for quite some time: > > https://gist.github.com/karenetheridge/5d2457221bacfbd3fa68 > > I understand from ribasushi that this isn't quite the right thing to > do, but nevertheless it would be nice to have some sort of fix rolled > into the real distribution.

The wheel has finally stopped at this corner of the codebase. Ether: do you happen to have a testcase that goes with the above patch? I.e. I need something that FAILS on current RU as it is on CPAN 0.34, yet passes with your changes applied. Thanks

Tue Aug 09 11:31:02 2016 The RT System itself - Status changed from 'new' to 'open'

Tue Aug 09 11:39:14 2016 ribasushi [...] leporine.io - Cc RIBASUSHI added

Tue Aug 09 13:11:31 2016 ether [...] cpan.org - Correspondence added

On 2016-08-09 08:31:02, RIBASUSHI wrote: Show quoted text

> The wheel has finally stopped at this corner of the codebase. Ether: > do you happen to have a testcase that goes with the above patch? I.e. > I need something that FAILS on current RU as it is on CPAN 0.34, yet > passes with your changes applied.

I do not, but I can remove the patch and fire up a jenkins instance and see what explodes, to see if that can give us a good test case.

Tue Aug 09 13:26:52 2016 ether [...] cpan.org - Correspondence added

On 2016-08-09 10:11:31, ETHER wrote: Show quoted text

> On 2016-08-09 08:31:02, RIBASUSHI wrote: >

> > The wheel has finally stopped at this corner of the codebase. Ether: > > do you happen to have a testcase that goes with the above patch? I.e. > > I need something that FAILS on current RU as it is on CPAN 0.34, yet > > passes with your changes applied.

> > I do not, but I can remove the patch and fire up a jenkins instance > and see what explodes, to see if that can give us a good test case.

Gerda -- if you can recall why you made that patch, that would be fantastic. I found the commit where you applied the patch to the CE codebase, but there are no seemly-relevant commits adjacent to it, and there was no commentary or explanation attached; I didn't see a local github repository for it in the CE organization. (The patch was made at 2014-06-05 20:29:49 -0400.)

Tue Aug 09 13:56:50 2016 ribasushi [...] leporine.io - Correspondence added

On Tue Aug 09 19:11:31 2016, ETHER wrote: Show quoted text

> > I do not, but I can remove the patch and fire up a jenkins instance > and see what explodes, to see if that can give us a good test case.

( the email interface is down, you will eventually receive this twice ) Ok, in this case wait a bit. I am almost finished with some changes to ::RU, I suppose starting testing after those are applied to your local tree is the saner thing to do, given the effort on your side is non-trivial. More in a bit.

Tue Aug 09 16:46:37 2016 ribasushi [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date:	Tue, 9 Aug 2016 19:18:27 +0200
To:	bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From:	Peter Rabbitson <ribasushi [...] cpan.org>

On 08/09/2016 07:11 PM, Karen Etheridge via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 2016-08-09 08:31:02, RIBASUSHI wrote: >

>> The wheel has finally stopped at this corner of the codebase. Ether: >> do you happen to have a testcase that goes with the above patch? I.e. >> I need something that FAILS on current RU as it is on CPAN 0.34, yet >> passes with your changes applied.

> I do not, but I can remove the patch and fire up a jenkins instance and see what explodes, to see if that can give us a good test case.

Ok, in this case wait a bit. I am almost finished with some changes to ::RU, I suppose starting testing after those are applied to your local tree is the saner thing to do, given the effort on your side is non-trivial. More in a bit.

Thu Apr 06 16:25:13 2017 ether [...] cpan.org - Correspondence added

RT-Send-CC:

ribasushi [...] cpan.org

On 2016-08-09 10:56:50, RIBASUSHI wrote: Show quoted text

> Ok, in this case wait a bit. > > I am almost finished with some changes to ::RU, I suppose starting > testing after those are applied to your local tree is the saner thing > to do, given the effort on your side is non-trivial. > > More in a bit.

Checking in... are there any new developments on this front?

Fri Apr 07 04:27:06 2017 perl [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date:	Fri, 7 Apr 2017 10:18:30 +0200
To:	bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From:	Peter Rabbitson <perl [...] leporine.io>

On 04/06/2017 10:25 PM, Karen Etheridge via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 2016-08-09 10:56:50, RIBASUSHI wrote: >

>> Ok, in this case wait a bit. >> >> I am almost finished with some changes to ::RU, I suppose starting >> testing after those are applied to your local tree is the saner thing >> to do, given the effort on your side is non-trivial. >> >> More in a bit.

> > Checking in... are there any new developments on this front? >

All work is blocked on #dbic-cabal getting their act together: https://twitter.com/ribasushi/status/847472053514981376 https://twitter.com/ribasushi/status/847558617926688768 Cheers

Fri Apr 07 12:21:13 2017 karen [...] froods.org - Correspondence added

Subject:	Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date:	Fri, 7 Apr 2017 09:20:57 -0700
To:	bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From:	Karen Etheridge <karen [...] froods.org>

can you clarify what you need from the dbic cabal, or in the DBIx-Class codebase, to move forward? On Fri, Apr 7, 2017 at 1:27 AM, Peter Rabbitson via RT < bug-DBIx-Class-ResultSet-RecursiveUpdate@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 04/06/2017 10:25 PM, Karen Etheridge via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > > > On 2016-08-09 10:56:50, RIBASUSHI wrote: > >

> >> Ok, in this case wait a bit. > >> > >> I am almost finished with some changes to ::RU, I suppose starting > >> testing after those are applied to your local tree is the saner thing > >> to do, given the effort on your side is non-trivial. > >> > >> More in a bit.

> > > > Checking in... are there any new developments on this front? > >

> > All work is blocked on #dbic-cabal getting their act together: > https://twitter.com/ribasushi/status/847472053514981376 > https://twitter.com/ribasushi/status/847558617926688768 > > Cheers >

Fri Apr 07 12:27:47 2017 perl [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date:	Fri, 7 Apr 2017 18:27:23 +0200
To:	bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From:	Peter Rabbitson <perl [...] leporine.io>

On 04/07/2017 06:21 PM, Karen Etheridge via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > can you clarify what you need from the dbic cabal, or in the DBIx-Class > codebase, to move forward? >

https://github.com/dbsrgits/dbix-class/commit/7293955#diff-14a995427a39511927479ae4ffbbb9c7R2282

Fri Apr 07 12:54:17 2017 karen [...] froods.org - Correspondence added

Subject:	Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date:	Fri, 7 Apr 2017 09:54:04 -0700
To:	bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From:	Karen Etheridge <karen [...] froods.org>

super, thanks! is that available in a branch, or does it have accompanying commits? I will try to find someone to merge it soon. On Fri, Apr 7, 2017 at 9:27 AM, Peter Rabbitson via RT < bug-DBIx-Class-ResultSet-RecursiveUpdate@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > On 04/07/2017 06:21 PM, Karen Etheridge via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > > > can you clarify what you need from the dbic cabal, or in the DBIx-Class > > codebase, to move forward? > >

> > https://github.com/dbsrgits/dbix-class/commit/7293955#diff- > 14a995427a39511927479ae4ffbbb9c7R2282 >

Fri Apr 07 13:03:05 2017 perl [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #100482] Need proper fix for table aliases
Date:	Fri, 7 Apr 2017 19:02:44 +0200
To:	bug-DBIx-Class-ResultSet-RecursiveUpdate [...] rt.cpan.org
From:	Peter Rabbitson <perl [...] leporine.io>

On 04/07/2017 06:54 PM, Karen Etheridge via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=100482 > > > super, thanks! is that available in a branch, or does it have accompanying > commits? I will try to find someone to merge it soon. >

This is the "cap commit" of about ~2k lines of changes spread over 20ish commits. This is all already in master and tested against a massove portion of CPAN ( well it was tested 6 months ago, don't know what the state is today ). What is missing is a dev-release-cycle ( a minimum on 2 months would be needed ) and a release.