Skip Menu |

This queue is for tickets about the Geo-Coder-Google CPAN distribution.

Report information
The Basics
Id: 100471
Status: resolved
Priority: 0/
Queue: Geo-Coder-Google
People
Owner: justin.d.hunter [...] gmail.com
Requestors: ksm [...] jobindex.dk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.14
Fixed in: (no value)

History Show all quoted text
  Thu Nov 20 09:37:47 2014 ksm [...] jobindex.dk - Ticket created
Subject: Geo::Coder::Google::V3 no longer working for non-Maps for Work requests
Date: Thu, 20 Nov 2014 15:37:36 +0100
To: bug-Geo-Coder-Google [...] rt.cpan.org
From: "Klaus S. Madsen" <ksm [...] jobindex.dk>
Hi, When a non-"Maps for Work" request is being sent to Google, the supplied API-key is not included in the query-string. This has worked until today, but now Google is (reasonably enough) rejecting these requests with the error "Over query limit". Adding the key to the query-string solves this issue. As a side issue, the documentation for the Geocoder API states that HTTPS is enforced for API-requests that include a key. So the module might as well always access the API through HTTPS. The attached patch implement both changes. As I don't have a Maps for Work account to test with, I haven't tested that part of the module. -- Klaus S. Madsen, Udvikler, ksm@jobindex.dk Jobindex A/S, Holger Danskes Vej 91, 2000 Frederiksberg Tlf +45 38 32 33 55, Dir +45 38 32 33 70 http://www.jobindex.dk/

Message body is not shown because sender requested not to inline it.

  Thu Nov 20 10:09:53 2014 justin.d.hunter [...] gmail.com - Status changed from 'new' to 'patched'
  Thu Nov 20 10:09:53 2014 justin.d.hunter [...] gmail.com - Taken
  Thu Nov 20 10:09:53 2014 justin.d.hunter [...] gmail.com - Broken in 0.14 added
  Thu Nov 20 10:10:23 2014 justin.d.hunter [...] gmail.com - Correspondence added
0.14_01 shipped to CPAN. On Thu Nov 20 09:37:47 2014, ksm@jobindex.dk wrote: Show quoted text
> Hi, > > When a non-"Maps for Work" request is being sent to Google, the supplied > API-key is not included in the query-string. > > This has worked until today, but now Google is (reasonably enough) > rejecting these requests with the error "Over query limit". Adding the > key to the query-string solves this issue. > > As a side issue, the documentation for the Geocoder API states that > HTTPS is enforced for API-requests that include a key. So the module > might as well always access the API through HTTPS. > > The attached patch implement both changes. As I don't have a Maps for > Work account to test with, I haven't tested that part of the module. >
  Tue May 26 21:25:53 2015 DROLSKY [...] cpan.org - Correspondence added
On Thu Nov 20 10:10:23 2014, arcanez wrote: Show quoted text
> 0.14_01 shipped to CPAN.
I just installed 0.14_02 to deal with this. It'd be great to get a non-dev release out with this change.
  Tue May 26 21:57:13 2015 justin.d.hunter [...] gmail.com - Status changed from 'patched' to 'resolved'
  Tue May 26 21:57:35 2015 justin.d.hunter [...] gmail.com - Correspondence added
I have released 0.15 On Tue May 26 21:25:53 2015, DROLSKY wrote: Show quoted text
> On Thu Nov 20 10:10:23 2014, arcanez wrote:
> > 0.14_01 shipped to CPAN.
> > I just installed 0.14_02 to deal with this. It'd be great to get a > non-dev release out with this change.