| Subject: | Test failures prior to perl v5.14 |
| Date: | Mon, 17 Nov 2014 12:13:13 +0000 |
| To: | "bug-FindBin-libs [...] rt.cpan.org" <bug-FindBin-libs [...] rt.cpan.org> |
| From: | Dominic Humphries <dominich [...] broadbean.com> |
Hi,
I'm unable to install FindBin::libs for Perl versions prior to v5.14.4 - including 5.8.9, 5.10.1, and 5.12.5 - due to test failures:
t/02-export-base.t:
1..4
ok 1 - Empty: Testophile::junk
not ok 2 - Non-empty: Testophile::lib
# Failed test 'Non-empty: Testophile::lib'
# at t/02-export-base.t line 55.
not ok 3 - Non-empty: Testophile::found
# Failed test 'Non-empty: Testophile::found'
# at t/02-export-base.t line 55.
ok 4 - Empty: Testophile::foobar
# Looks like you failed 2 tests of 4.
This is fixed by the below patch:
--- lib/FindBin/libs.pm 2014-11-17 11:46:31.284128536 +0000
+++ libs.pm 2014-11-17 11:47:30.218258390 +0000
@@ -81,7 +81,7 @@
die "Cwd fails abs_path test && lacks 'rel2abs'\n";
}
- my $ref = *{ qualify_to_ref 'abs_path', __PACKAGE__ };
+ my $ref = qualify_to_ref 'abs_path', __PACKAGE__;
undef &{ *$ref };
Also, in test t/09-base-subdir-scalar.t there are failures:
Searching /data0/www/adcourier.broadbean/.cpanm/work/1416224459.32283/FindBin-libs-2.11/t for 'blib'...
Found */blib:
/data0/www/adcourier.broadbean/.cpanm/work/1416224459.32283/FindBin-libs-2.11/blib/blort
Exporting: @Testophile::snark
not ok 1 - Exported scalar '$snark'
This appears to be caused by the installation for v5.8.9 using FindBin::libs_5_8 - which doesn't understand the "scalar" option and therefore exports to @snark rather than $snark. Not sure if this is something you'd want to fix in the test or in the module..
Kind regards
Dominic