Skip Menu |

This queue is for tickets about the Net-SSLeay-OO CPAN distribution.

Report information
The Basics
Id: 100364
Status: new
Priority: 0/
Queue: Net-SSLeay-OO
People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sat Nov 15 15:14:49 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Ticket created
Subject: [PATCH] Dodge bleadperl (5.21.6) warning
See attachment. Though not created with git-format-patch, this should still be compatible with git-am.
Subject: open_PQms0BDj.txt
From: Father Chrysostomos <sprout@cpan.org> Dodge new bleadperl (5.21.6) warning t/00-load.t .......... # oh look a warning: Constants from lexical variables potentially modified elsewhere are deprecated at /Users/sprout/.cpan/build/Net-SSLeay-OO-0.02-0NOCZK/blib/lib/Net/SSLeay/OO/Constants.pm line 60. t/00-load.t .......... 1/? # Failed test 'no warnings issued' # at t/00-load.t line 48. # got: '1' # expected: '0' # Looks like you failed 1 test of 22. Perl sees the later $val = $FALLBACK{$thingy}; and assumes that this could be intended as a closure. (It’s not quite smart enough to fig- ure out that that code path cannot be reached from sub(){$val}.) diff -rup Net-SSLeay-OO-0.02-0NOCZK-orig/lib/Net/SSLeay/OO/Constants.pm Net-SSLeay-OO-0.02-0NOCZK/lib/Net/SSLeay/OO/Constants.pm --- Net-SSLeay-OO-0.02-0NOCZK-orig/lib/Net/SSLeay/OO/Constants.pm 2009-10-06 00:00:36.000000000 -0700 +++ Net-SSLeay-OO-0.02-0NOCZK/lib/Net/SSLeay/OO/Constants.pm 2014-11-15 12:10:00.000000000 -0800 @@ -57,7 +57,8 @@ sub import { no strict 'refs'; my $val = eval { &{"Net::SSLeay::$thingy"}() }; if ( defined $val ) { - *{ $target . "::" . $thingy } = sub() {$val}; + my $v = $val; + *{ $target . "::" . $thingy } = sub() {$v}; } elsif ( exists $FALLBACK{$thingy} ) { $val = $FALLBACK{$thingy};