Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Plack-Test-Agent CPAN distribution.

Report information
The Basics
Id: 100338
Status: resolved
Priority: 0/
Queue: Plack-Test-Agent
People
Owner: Nobody in particular
Requestors: olaf [...] wundersolutions.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.20111011
Fixed in: 1.3

History Show all quoted text
  Fri Nov 14 14:18:46 2014 olaf [...] wundersolutions.com - Ticket created
Subject: Value of server is ignored
The interface around the server attribute is kind of weird. If you don't pass in a server class then start_server() is not called when the object is created. However, if you _do_ pass in a server class then server class is ignored when start_server is called. Also, the server() attribute is then set to a Test::TCP object. It feels like a) the server attribute passed to new() should actually be called server_class b) the server attribute should then also be passed to Plack::Loader Happy to provide a patch if you'd accept this.
  Tue Jan 06 06:55:13 2015 olaf [...] wundersolutions.com - Correspondence added
On Fri Nov 14 14:18:46 2014, OALDERS wrote: Show quoted text
> The interface around the server attribute is kind of weird. > > If you don't pass in a server class then start_server() is not called > when the object is created. However, if you _do_ pass in a server > class then server class is ignored when start_server is called. Also, > the server() attribute is then set to a Test::TCP object. > > It feels like > > a) the server attribute passed to new() should actually be called > server_class > b) the server attribute should then also be passed to Plack::Loader > > Happy to provide a patch if you'd accept this.
Fixed in 1.3
  Tue Jan 06 06:55:15 2015 olaf [...] wundersolutions.com - Status changed from 'new' to 'resolved'
  Tue Jan 06 06:55:16 2015 olaf [...] wundersolutions.com - Fixed in 1.3 added