Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-MinimumPerl CPAN distribution.

Report information
The Basics
Id: 100322
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-MinimumPerl
People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc: ether [...] cpan.org
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Nov 13 16:10:45 2014 dagolden [...] cpan.org - Ticket created
Subject: Skip test files that aren't perl files
The scanner picks up everything in t, even text files. So for example, a text file with a URL gets detected as a needing 5.10 because of "//". I can force it to skip by setting the encoding to bytes, but that's a crude approach. Better would be to actually check only perl files (.pm, .pl, .t, or a shebang).
  Thu Nov 13 16:55:03 2014 ether [...] cpan.org - Correspondence added
On 2014-11-13 13:10:45, DAGOLDEN wrote: Show quoted text
> The scanner picks up everything in t, even text files. So for > example, a text file with a URL gets detected as a needing 5.10 > because of "//". > > I can force it to skip by setting the encoding to bytes, but that's a > crude approach. > > Better would be to actually check only perl files (.pm, .pl, .t, or a > shebang).
Ideally this should be an in-core filefinder, as many other plugins would find it useful as well (e.g. [Test::Compile], [PodWeaver]). I'll look tonight at writing such a finder.
  Thu Nov 13 16:55:03 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Nov 16 00:13:28 2014 ether [...] cpan.org - Correspondence added
On 2014-11-13 13:55:03, ETHER wrote: Show quoted text
> Ideally this should be an in-core filefinder, as many other plugins > would find it useful as well (e.g. [Test::Compile], [PodWeaver]). > > I'll look tonight at writing such a finder.
Done, in https://github.com/rjbs/Dist-Zilla/pull/378
  Thu Nov 20 10:44:28 2014 dagolden [...] cpan.org - Correspondence added
That file finder isn't enough. The problem is random t files that aren't even perl. (t/data/foo.txt) Look at how MinimumPerlFast does it -- it just checks suffixes. That's much easier to do and doesn't block on people to write finder or rjbs to merge and release them.
  Thu Nov 20 10:47:22 2014 dagolden [...] cpan.org - Correspondence added
Ditto AutoPrereqs. See how it skips all sorts of things: https://github.com/rjbs/Dist-Zilla/blob/master/lib/Dist/Zilla/Plugin/AutoPrereqs.pm#L144-L150
  Tue May 19 11:15:59 2015 dagolden [...] cpan.org - Correspondence added
Ping. This is still not fixed. If you're not interested in keeping this module up, would you be willing to transfer primary maintainership to me instead? Regards, David
  Sat Jun 11 16:39:55 2016 ether [...] cpan.org - Cc ETHER added