| Subject: | Tests failing under PPI 1.220 and Perl::Critic 1.123 |
From CPAN shell:
Test Summary Report
-------------------
t/ConstantBeforeLt.t (Wstat: 256 Tests: 49 Failed: 2)
Failed tests: 29-30
Non-zero exit status: 1
t/NotWithCompare.t (Wstat: 256 Tests: 116 Failed: 1)
Failed test: 104
Non-zero exit status: 1
I expect that the ConstantBeforeLt needs to be changed in response to the PPI 1.220 interface change to PPI::Statement::Sub::prototype https://github.com/adamkennedy/PPI/commit/18adbca35b4cba94988027a26ab350bc528104a3
Details:
KRYDE/Perl-Critic-Pulp-85.tar.gz
/bin/make -- OK
Running make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/ConstantBeforeLt.t ............... 1/49 Use of uninitialized value in string eq at /root/.local/share/.cpan/build/Perl-Critic-Pulp-85-cCiVoV/blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ConstantBeforeLt.pm line 114.
Use of uninitialized value in string eq at /root/.local/share/.cpan/build/Perl-Critic-Pulp-85-cCiVoV/blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ConstantBeforeLt.pm line 114.
# Failed test 'sub FOO () { 123; }'
# at t/ConstantBeforeLt.t line 99.
# Structures begin differing at:
# $got->[0] = Does not exist
# $expected->[0] = 'FOO'
# Failed test 'sub FOO () { 123; };'
# at t/ConstantBeforeLt.t line 99.
# Structures begin differing at:
# $got->[0] = Does not exist
# $expected->[0] = 'FOO'
t/ConstantBeforeLt.t ............... 33/49 # Saw 2 warning(s):
#
# Trace begun at t/MyTestHelpers.pm line 55
# MyTestHelpers::nowarnings_handler('Use of uninitialized value in string eq at /root/.local/share/.cpan/build/Perl-Critic-Pulp-85-cCiVoV/blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ConstantBeforeLt.pm line 114.^J') called at /root/.local/share/.cpan/build/Perl-Critic-Pulp-85-cCiVoV/blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ConstantBeforeLt.pm line 114
# Perl::Critic::Policy::ValuesAndExpressions::ConstantBeforeLt::_use_constants('PPI::Statement::Sub=HASH(0x3009078)') called at t/ConstantBeforeLt.t line 98
#
#
# Trace begun at t/MyTestHelpers.pm line 55
# MyTestHelpers::nowarnings_handler('Use of uninitialized value in string eq at /root/.local/share/.cpan/build/Perl-Critic-Pulp-85-cCiVoV/blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ConstantBeforeLt.pm line 114.^J') called at /root/.local/share/.cpan/build/Perl-Critic-Pulp-85-cCiVoV/blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ConstantBeforeLt.pm line 114
# Perl::Critic::Policy::ValuesAndExpressions::ConstantBeforeLt::_use_constants('PPI::Statement::Sub=HASH(0x30116a0)') called at t/ConstantBeforeLt.t line 98
#
# Exit code 1 for warnings
# Looks like you failed 2 tests of 49.
# Looks like your test exited with 1 just after 49.
t/ConstantBeforeLt.t ............... Dubious, test returned 1 (wstat 256, 0x100)
Failed 2/49 subtests
and
# Failed test 'str: sub FOO () { 123 }
# ! FOO < 100 || $bar > 200'
# at t/NotWithCompare.t line 220.
# got: '0'
# expected: '1'
# Looks like you failed 1 test of 116.
t/NotWithCompare.t ................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/116 subtests