Bug #100290 for Perl-Critic-Pulp: Recognize Modern::Perl

Wed Nov 12 11:07:07 2014 EDAVIS [...] cpan.org - Ticket created

Subject:

Recognize Modern::Perl

Putting 'use Modern::Perl;' in your script means you require at least perl 5.10. Compatibility::PerlMinimumVersionAndWhy should recognize this and treat 'use Modern::Perl;' as equivalent to an explicit perl version requirement.

Wed Nov 12 12:06:37 2014 ether [...] cpan.org - Correspondence added

On 2014-11-12 08:07:07, EDAVIS wrote: Show quoted text

> Putting 'use Modern::Perl;' in your script means you require at least > perl 5.10. > Compatibility::PerlMinimumVersionAndWhy should recognize this and > treat 'use Modern::Perl;' as equivalent to an explicit perl version > requirement.

See also the similar check in Module::CPANTS::Analyse, which recognizes a bunch of common modules that add version requirements and/or strict and warning pragmas.

Wed Nov 12 12:06:37 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Nov 13 03:49:24 2014 user42_kevin [...] yahoo.com.au - Correspondence added

CC:	bug-Perl-Critic-Pulp [...] rt.cpan.org
Subject:	Re: [rt.cpan.org #100290] Recognize Modern::Perl
Date:	Thu, 13 Nov 2014 19:47:22 +1100
To:	EDAVIS [...] cpan.org
From:	Kevin Ryde <user42_kevin [...] yahoo.com.au>

"EDAVIS via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text

> > Putting 'use Modern::Perl;' in your script means you require at least > perl 5.10.

Hmm. Personally I don't think I rate that sort of thing. Not that I object to more than one way to do it ... I go from Perl::Critic::Document highest_explicit_perl_version(). How would they feel about looking for extra pragmatic modules which are proxies for a minimum version? That might give the benefit to all perlcritic policies.

Wed Dec 31 08:45:12 2014 EDAVIS [...] cpan.org - Correspondence added

There was some (quite unnecessary IMHO) controversy about this in Perl::Critic, see https://github.com/Perl-Critic/Perl-Critic/issues/270

Sun Jan 04 01:59:31 2015 user42_kevin [...] yahoo.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #100290] Recognize Modern::Perl
Date:	Sun, 04 Jan 2015 17:55:36 +1100
To:	"EDAVIS via RT" <bug-Perl-Critic-Pulp [...] rt.cpan.org>
From:	Kevin Ryde <user42_kevin [...] yahoo.com.au>

"EDAVIS via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text

> > There was some (quite unnecessary IMHO) controversy about this in > Perl::Critic, see > https://github.com/Perl-Critic/Perl-Critic/issues/270

Hmm. No offence, but the dates idea seems to obscure the actual requirements. At any rate I put a bit in version 89 to treat as 5.10.

Sat Feb 28 05:52:00 2015 EDAVIS [...] cpan.org - Correspondence added

Thanks for looking at this. However, even with version 89 I still see warnings such as ./job:9:1:_perl_5006_pragmas requires 5.006 [Compatibility::PerlMinimumVersionAndWhy] ((no explanation)) even when the first line of code in the file is use Modern::Perl '2014'; I agree, the year specification stuff seems a bit daft. I think I would just make all minimum version rules turn themselves off for any 'Modern::Perl' declaration, whatever the year. The tendency in recent perl releases has been for new features to only be enabled when a new enough perl version is declared - so there is less risk of accidentally using new perl features without a version requirement.

Sat Mar 07 03:24:48 2015 user42_kevin [...] yahoo.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #100290] Recognize Modern::Perl
Date:	Sat, 07 Mar 2015 19:18:30 +1100
To:	"EDAVIS via RT" <bug-Perl-Critic-Pulp [...] rt.cpan.org>
From:	Kevin Ryde <user42_kevin [...] yahoo.com.au>

"EDAVIS via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text

> > ./job:9:1:_perl_5006_pragmas requires 5.006 [Compatibility::PerlMinimumVersionAndWhy] ((no explanation))

Thanks. I wrote a bit and then never hooked it in. Version 90 should be better. Show quoted text

> I agree, the year specification stuff seems a bit daft. I think I > would just make all minimum version rules turn themselves off for any > 'Modern::Perl' declaration, whatever the year.

That's an idea. If Modern::Perl is a moving target anyway then I suppose there's no minimum perl compatibility to think about at all.

Sun Jun 14 04:50:05 2015 KRYDE [...] cpan.org - Correspondence added

I've left it as meaning 5.10 for now, though if it gives some code interface for interpreting its years etc (and if anyone uses that feature :-) then maybe could follow that in the future.

Sun Jun 14 04:50:07 2015 KRYDE [...] cpan.org - Status changed from 'open' to 'resolved'