Skip Menu |

This queue is for tickets about the PadWalker CPAN distribution.

Report information
The Basics
Id: 100262
Status: open
Priority: 0/
Queue: PadWalker

People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.2



Subject: [PATCH] Don’t use CvPADLIST on XSUBs
Bleadperl now repurposes the field for XSUBs, so your module fails an assertion. See the attachment.
Subject: open_vL4aQv3t.txt
diff -rup PadWalker-1.98-r4qSuD-orig/PadWalker.xs PadWalker-1.98-r4qSuD/PadWalker.xs --- PadWalker-1.98-r4qSuD-orig/PadWalker.xs 2013-10-27 03:11:36.000000000 -0700 +++ PadWalker-1.98-r4qSuD/PadWalker.xs 2014-11-10 21:56:04.000000000 -0800 @@ -538,6 +538,8 @@ CV* cv; HV* ret = newHV(); HV* ignore = newHV(); PPCODE: + if (CvISXSUB(cv)) + die("PadWalker: cv has no padlist"); padlist_into_hash(CvPADLIST(cv), ret, ignore, 0, CvDEPTH(cv)); SvREFCNT_dec((SV*) ignore); EXTEND(SP, 1);
Subject: [PATCH] Don’t use CvPADLIST on XSUBs
Bleadperl now repurposes the field for XSUBs, so your module fails an assertion. See the attachment.
Subject: open_vL4aQv3t.txt
diff -rup PadWalker-1.98-r4qSuD-orig/PadWalker.xs PadWalker-1.98-r4qSuD/PadWalker.xs --- PadWalker-1.98-r4qSuD-orig/PadWalker.xs 2013-10-27 03:11:36.000000000 -0700 +++ PadWalker-1.98-r4qSuD/PadWalker.xs 2014-11-10 21:56:04.000000000 -0800 @@ -538,6 +538,8 @@ CV* cv; HV* ret = newHV(); HV* ignore = newHV(); PPCODE: + if (CvISXSUB(cv)) + die("PadWalker: cv has no padlist"); padlist_into_hash(CvPADLIST(cv), ret, ignore, 0, CvDEPTH(cv)); SvREFCNT_dec((SV*) ignore); EXTEND(SP, 1);
Sorry. This is a duplicate of #100262. I don’t know how that happened.
On Tue Nov 11 01:09:24 2014, SPROUT wrote: Show quoted text
> Bleadperl now repurposes the field for XSUBs, so your module fails an > assertion. See the attachment.
I did something different at https://github.com/bulk88/PadWalker/commits/master but it needed to be updated since CvRESERVED doesnt exist ion blead anymore.
From: paul [...] city-fan.org
On Tue Nov 11 01:09:22 2014, SPROUT wrote: Show quoted text
> Bleadperl now repurposes the field for XSUBs, so your module fails an > assertion. See the attachment.
I now get the linker complaining about undefined symbol CvISXSUB with perl 5.8.8; this patch appears to help: --- PadWalker.xs +++ PadWalker.xs @@ -10,6 +10,10 @@ # define CxOLD_OP_TYPE(cx) (0 + (cx)->blk_eval.old_op_type) #endif +#ifndef CvISXSUB +#define CvISXSUB(sv) CvXSUB(sv) +#endif + /* For development testing */ #ifdef PADWALKER_DEBUGGING # define debug_print(x) printf x
This looks to have been fixed in 2.2?
On Fri Nov 06 23:43:10 2015, TODDR wrote: Show quoted text
> This looks to have been fixed in 2.2?