Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the LWP-UserAgent-Mockable CPAN distribution.

Report information
The Basics
Id: 100193
Status: resolved
Priority: 0/
Queue: LWP-UserAgent-Mockable
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.10
Fixed in: (no value)

History Show all quoted text
  Fri Nov 07 17:30:18 2014 ANDK [...] cpan.org - Ticket created
Subject: Fails with perls > 5.21.3
The commit v5.21.3-521-gcfc7ef1 broke most of the tests. Sample fail report: http://www.cpantesters.org/cpan/report/4a79da32-59b8-11e4-b04e-79d5bb36d621 A discussion about the change took place at https://rt.perl.org/Ticket/Display.html?id=122757 HTH&&Thanks, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)
  Sat Nov 08 02:40:58 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Fri Nov 07 17:30:18 2014, ANDK wrote: Show quoted text
> The commit v5.21.3-521-gcfc7ef1 broke most of the tests. Sample fail > report: > > http://www.cpantesters.org/cpan/report/4a79da32-59b8-11e4-b04e- > 79d5bb36d621 > > A discussion about the change took place at > https://rt.perl.org/Ticket/Display.html?id=122757 > > HTH&&Thanks, > (Disclaimer: this was discovered by statistical analysis, I'm not > speaking as a user)
Patch.
Subject: open_Z0cSpUJE.txt
diff -rup LWP-UserAgent-Mockable-wwHFeJ-orig/lib/LWP/UserAgent/Mockable.pm LWP-UserAgent-Mockable-wwHFeJ/lib/LWP/UserAgent/Mockable.pm --- LWP-UserAgent-Mockable-wwHFeJ-orig/lib/LWP/UserAgent/Mockable.pm 2009-05-25 08:52:01.000000000 -0700 +++ LWP-UserAgent-Mockable-wwHFeJ/lib/LWP/UserAgent/Mockable.pm 2014-11-07 23:38:15.000000000 -0800 @@ -71,7 +71,7 @@ sub __reset { $self->{ actions } = retrieve( $file ); - $wrappers->{ pre } = wrap LWP::UserAgent::simple_request, + $wrappers->{ pre } = wrap 'LWP::UserAgent::simple_request', pre => sub { my ( $wrapped, $request ) = @_; @@ -99,7 +99,7 @@ sub __reset { $_[ -1 ] = $response; }; } else { - $wrappers->{ pre } = wrap LWP::UserAgent::simple_request, + $wrappers->{ pre } = wrap 'LWP::UserAgent::simple_request', pre => sub { my ( $wrapped, $request ) = @_; @@ -120,7 +120,7 @@ sub __reset { # This does mean that, when both pre- and post-record callbacks are being # used, that the post-callback will take precedence. - $wrappers->{ post } = wrap LWP::UserAgent::simple_request, + $wrappers->{ post } = wrap 'LWP::UserAgent::simple_request', post => sub { my $response = $_[ -1 ]; if ( $callbacks->{ record }) {
  Sat Nov 08 02:40:59 2014 The RT System itself - Status changed from 'new' to 'open'
  Thu Sep 10 05:41:38 2015 michael.jemmeson [...] gmail.com - Correspondence added
On Sat Nov 08 07:40:58 2014, SPROUT wrote: Show quoted text
> On Fri Nov 07 17:30:18 2014, ANDK wrote:
> > The commit v5.21.3-521-gcfc7ef1 broke most of the tests. Sample fail > > report: > > > > http://www.cpantesters.org/cpan/report/4a79da32-59b8-11e4-b04e- > > 79d5bb36d621 > > > > A discussion about the change took place at > > https://rt.perl.org/Ticket/Display.html?id=122757 > > > > HTH&&Thanks, > > (Disclaimer: this was discovered by statistical analysis, I'm not > > speaking as a user)
> > Patch.
Thanks - patch applied. Not yet tested with > 5.21.3. I will wait for cpantesters to return (or me to build a more recent Perl) before closing ticket.
  Thu Sep 10 05:41:44 2015 michael.jemmeson [...] gmail.com - Status changed from 'open' to 'patched'
  Thu Sep 10 15:39:04 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-09-10 05:41:38, mjemmeson wrote: Show quoted text
> On Sat Nov 08 07:40:58 2014, SPROUT wrote:
> > On Fri Nov 07 17:30:18 2014, ANDK wrote:
> > > The commit v5.21.3-521-gcfc7ef1 broke most of the tests. Sample > > > fail > > > report: > > > > > > http://www.cpantesters.org/cpan/report/4a79da32-59b8-11e4-b04e- > > > 79d5bb36d621 > > > > > > A discussion about the change took place at > > > https://rt.perl.org/Ticket/Display.html?id=122757 > > > > > > HTH&&Thanks, > > > (Disclaimer: this was discovered by statistical analysis, I'm not > > > speaking as a user)
> > > > Patch.
> > > Thanks - patch applied. Not yet tested with > 5.21.3. > > I will wait for cpantesters to return (or me to build a more recent > Perl) before closing ticket.
The preliminary matrix looks good: http://fast-matrix.cpantesters.org/?dist=LWP-UserAgent-Mockable%201.11
  Tue Sep 22 06:51:56 2015 michael.jemmeson [...] gmail.com - Correspondence added
Patch applied and released in v1.11
  Tue Sep 22 06:51:59 2015 michael.jemmeson [...] gmail.com - Status changed from 'patched' to 'resolved'