Bug #100067 for future: repeat does not capture failure of 'while' etc.. conditions

Wed Nov 05 11:42:07 2014 leonerd-cpan [...] leonerd.org.uk - Ticket created

Subject:

repeat does not capture failure of 'while' etc.. conditions

This correctly captures failure: my $f = repeat { die "I failed in body" } while => sub { 0 }; $f->failure and print STDERR "Future caught failure: " . $f->failure; output: Future caught failure: I failed in body at ... This doesn't: my $f = repeat { Future->done } while => sub { die "I failed in the while condition" }; $f->failure and print STDERR "Future caught failure: " . $f->failure; Output: I failed in the while condition at ... -- Paul Evans

Wed Nov 05 12:03:17 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Fixed in attached patch -- Paul Evans

Subject:

rt100067.patch

=== modified file 'lib/Future/Utils.pm' --- lib/Future/Utils.pm 2014-07-17 11:21:45 +0000 +++ lib/Future/Utils.pm 2014-11-05 17:01:49 +0000 @@ -280,7 +280,14 @@ return $return; } - if( !$cond->( $trial ) ^ $sense ) { + my $stop; + if( not eval { $stop = !$cond->( $trial ) ^ $sense; 1 } ) { + $return ||= $trial->new; + $return->fail( $@ ); + return $return; + } + + if( $stop ) { # Return result $return ||= $trial->new; $trial->on_done( $return ); === modified file 't/32utils-repeat.t' --- t/32utils-repeat.t 2014-07-17 10:14:30 +0000 +++ t/32utils-repeat.t 2014-11-05 17:01:49 +0000 @@ -96,7 +96,7 @@ is( scalar $future->get, "four", '$future->get' ); } -# code dies +# body code dies { my $future; @@ -113,6 +113,15 @@ is( $future->failure, "It failed\n", 'repeat until failure after code exception' ); } +# condition code dies (RT100067) +{ + my $future = repeat { + Future->done(1); + } while => sub { die "it dies!\n" }; + + is( $future->failure, "it dies!\n", 'repeat while failure after condition exception' ); +} + # Non-Future return fails { my $future;

Wed Nov 05 12:03:17 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'

Thu Nov 27 05:36:36 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Released in 0.30 -- Paul Evans

Thu Nov 27 05:36:39 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Thu Nov 27 05:36:39 2014 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.30 added